From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 00/55] Unaligned access for user-only
Date: Mon, 2 Aug 2021 18:13:48 -1000 [thread overview]
Message-ID: <20210803041443.55452-1-richard.henderson@linaro.org> (raw)
This began with Peter wanting a cpu_ldst.h interface that can handle
alignment info for Arm M-profile system mode, which will also compile
for user-only without ifdefs. This is patch 32.
Once I had that interface, I thought I might as well enforce the
requested alignment in user-only. There are plenty of cases where
we ought to have been doing that for quite a while. This took rather
more work than I imagined to start.
So far only x86 host has been fully converted to handle unaligned
operations in user-only mode. I'll get to the others later. But
the added testcase is fairly broad, and caught lots of bugs and/or
missing code between target/ and linux-user/.
Changes for v2:
* Cleanup prctl(2), add support for prctl(PR_GET/SET_UNALIGN).
* Adjustments for ppc and sparc reporting address during alignment fault.
r~
Richard Henderson (55):
hw/core: Make do_unaligned_access noreturn
hw/core: Make do_unaligned_access available to user-only
target/alpha: Implement do_unaligned_access for user-only
target/arm: Implement do_unaligned_access for user-only
target/hppa: Implement do_unaligned_access for user-only
target/microblaze: Do not set MO_ALIGN for user-only
target/mips: Implement do_unaligned_access for user-only
target/ppc: Move SPR_DSISR setting to powerpc_excp
target/ppc: Set fault address in ppc_cpu_do_unaligned_access
target/ppc: Implement do_unaligned_access for user-only
target/riscv: Implement do_unaligned_access for user-only
target/s390x: Implement do_unaligned_access for user-only
target/sh4: Set fault address in superh_cpu_do_unaligned_access
target/sh4: Implement do_unaligned_access for user-only
target/sparc: Remove DEBUG_UNALIGNED
target/sparc: Split out build_sfsr
target/sparc: Set fault address in sparc_cpu_do_unaligned_access
target/sparc: Implement do_unaligned_access for user-only
target/xtensa: Implement do_unaligned_access for user-only
accel/tcg: Report unaligned atomics for user-only
accel/tcg: Drop signness in tracing in cputlb.c
tcg: Expand MO_SIZE to 3 bits
tcg: Rename TCGMemOpIdx to MemOpIdx
tcg: Split out MemOpIdx to exec/memopidx.h
trace/mem: Pass MemOpIdx to trace_mem_get_info
accel/tcg: Pass MemOpIdx to atomic_trace_*_post
plugins: Reorg arguments to qemu_plugin_vcpu_mem_cb
trace: Split guest_mem_before
target/arm: Use MO_128 for 16 byte atomics
target/i386: Use MO_128 for 16 byte atomics
target/ppc: Use MO_128 for 16 byte atomics
target/s390x: Use MO_128 for 16 byte atomics
target/hexagon: Implement cpu_mmu_index
accel/tcg: Add cpu_{ld,st}*_mmu interfaces
accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h
target/mips: Use cpu_*_data_ra for msa load/store
target/mips: Use 8-byte memory ops for msa load/store
target/s390x: Use cpu_*_mmu instead of helper_*_mmu
target/sparc: Use cpu_*_mmu instead of helper_*_mmu
target/arm: Use cpu_*_mmu instead of helper_*_mmu
tcg: Move helper_*_mmu decls to tcg/tcg-ldst.h
tcg: Add helper_unaligned_mmu for user-only sigbus
tcg/i386: Support raising sigbus for user-only
tests/tcg/multiarch: Add sigbus.c
linux-user: Split out do_prctl and subroutines
linux-user: Disable more prctl subcodes
hw/core/cpu: Re-sort the non-pointers to the end of CPUClass
linux-user: Add code for PR_GET/SET_UNALIGN
hw/core/cpu: Move cpu properties to cpu-sysemu.c
hw/core/cpu: Add prctl-unalign-sigbus property for user-only
target/alpha: Reorg fp memory operations
target/alpha: Reorg integer memory operations
target/alpha: Implement prctl_unalign_sigbus
target/hppa: Implement prctl_unalign_sigbus
target/sh4: Implement prctl_unalign_sigbus
docs/devel/loads-stores.rst | 52 +-
accel/tcg/atomic_template.h | 73 ++-
accel/tcg/internal.h | 4 +
hw/core/cpu-common.h | 17 +
include/exec/cpu_ldst.h | 332 ++++++-------
include/exec/memop.h | 14 +-
include/exec/memopidx.h | 55 +++
include/hw/core/cpu.h | 14 +-
include/hw/core/tcg-cpu-ops.h | 15 +-
include/qemu/plugin.h | 26 +-
include/tcg/tcg-ldst.h | 79 ++++
include/tcg/tcg.h | 197 +-------
linux-user/aarch64/target_syscall.h | 23 -
linux-user/mips/target_syscall.h | 6 -
linux-user/mips64/target_syscall.h | 6 -
target/alpha/cpu.h | 9 +-
target/arm/internals.h | 3 +-
target/hexagon/cpu.h | 9 +
target/hppa/cpu.h | 5 +-
target/microblaze/cpu.h | 2 +-
target/mips/tcg/tcg-internal.h | 4 +-
target/nios2/cpu.h | 4 +-
target/ppc/internal.h | 4 +-
target/riscv/cpu.h | 2 +-
target/s390x/s390x-internal.h | 4 +-
target/sh4/cpu.h | 8 +-
target/xtensa/cpu.h | 4 +-
tcg/i386/tcg-target.h | 2 -
trace/mem.h | 63 ---
accel/tcg/cpu-exec-common.c | 12 +
accel/tcg/cputlb.c | 495 +++++++------------
accel/tcg/plugin-gen.c | 5 +-
accel/tcg/user-exec.c | 435 +++++++----------
hw/core/cpu-common.c | 18 +-
hw/core/cpu-sysemu.c | 24 +
hw/core/cpu-user.c | 37 ++
linux-user/aarch64/cpu_loop.c | 4 +
linux-user/arm/cpu_loop.c | 43 +-
linux-user/hppa/cpu_loop.c | 2 +-
linux-user/mips/cpu_loop.c | 20 +-
linux-user/ppc/cpu_loop.c | 2 +-
linux-user/riscv/cpu_loop.c | 7 +
linux-user/sh4/cpu_loop.c | 8 +
linux-user/sparc/cpu_loop.c | 11 +
linux-user/syscall.c | 709 +++++++++++++++++-----------
plugins/api.c | 19 +-
plugins/core.c | 10 +-
target/alpha/cpu.c | 2 +-
target/alpha/mem_helper.c | 8 +-
target/alpha/translate.c | 188 ++++----
target/arm/cpu.c | 2 +-
target/arm/cpu_tcg.c | 2 +-
target/arm/helper-a64.c | 77 +--
target/arm/m_helper.c | 8 +-
target/arm/translate-a64.c | 2 +-
target/hppa/cpu.c | 16 +-
target/hppa/translate.c | 19 +-
target/i386/tcg/mem_helper.c | 4 +-
target/m68k/op_helper.c | 3 +-
target/microblaze/translate.c | 16 +
target/mips/cpu.c | 2 +-
target/mips/tcg/msa_helper.c | 395 ++++------------
target/mips/tcg/op_helper.c | 3 +-
target/mips/tcg/user/tlb_helper.c | 23 +-
target/ppc/cpu_init.c | 2 +-
target/ppc/excp_helper.c | 35 +-
target/ppc/mem_helper.c | 1 -
target/ppc/translate.c | 12 +-
target/riscv/cpu.c | 2 +-
target/riscv/cpu_helper.c | 8 +-
target/s390x/cpu.c | 2 +-
target/s390x/tcg/excp_helper.c | 28 +-
target/s390x/tcg/mem_helper.c | 31 +-
target/sh4/cpu.c | 2 +-
target/sh4/op_helper.c | 8 +-
target/sh4/translate.c | 50 +-
target/sparc/cpu.c | 2 +-
target/sparc/ldst_helper.c | 38 +-
target/sparc/mmu_helper.c | 92 +++-
target/xtensa/cpu.c | 2 +-
target/xtensa/helper.c | 30 +-
tcg/optimize.c | 2 +-
tcg/tcg-op.c | 60 +--
tcg/tcg.c | 3 +-
tcg/tci.c | 15 +-
tests/tcg/multiarch/sigbus.c | 68 +++
accel/tcg/atomic_common.c.inc | 43 +-
accel/tcg/ldst_common.c.inc | 307 ++++++++++++
target/s390x/tcg/translate_vx.c.inc | 2 +-
tcg/aarch64/tcg-target.c.inc | 18 +-
tcg/arm/tcg-target.c.inc | 14 +-
tcg/i386/tcg-target.c.inc | 128 ++++-
tcg/mips/tcg-target.c.inc | 16 +-
tcg/ppc/tcg-target.c.inc | 18 +-
tcg/riscv/tcg-target.c.inc | 20 +-
tcg/s390/tcg-target.c.inc | 14 +-
tcg/sparc/tcg-target.c.inc | 20 +-
tcg/tcg-ldst.c.inc | 2 +-
hw/core/meson.build | 4 +
trace-events | 18 +-
100 files changed, 2549 insertions(+), 2235 deletions(-)
create mode 100644 hw/core/cpu-common.h
create mode 100644 include/exec/memopidx.h
create mode 100644 include/tcg/tcg-ldst.h
delete mode 100644 trace/mem.h
create mode 100644 hw/core/cpu-user.c
create mode 100644 tests/tcg/multiarch/sigbus.c
create mode 100644 accel/tcg/ldst_common.c.inc
--
2.25.1
next reply other threads:[~2021-08-03 4:16 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 4:13 Richard Henderson [this message]
2021-08-03 4:13 ` [PATCH v2 01/55] hw/core: Make do_unaligned_access noreturn Richard Henderson
2021-08-03 10:01 ` Philippe Mathieu-Daudé
2021-08-03 15:47 ` Alex Bennée
2021-08-03 18:02 ` Richard Henderson
2021-08-03 4:13 ` [PATCH v2 02/55] hw/core: Make do_unaligned_access available to user-only Richard Henderson
2021-08-03 9:59 ` Philippe Mathieu-Daudé
2021-08-03 15:51 ` Alex Bennée
2021-08-03 4:13 ` [PATCH v2 03/55] target/alpha: Implement do_unaligned_access for user-only Richard Henderson
2021-08-18 8:45 ` Philippe Mathieu-Daudé
2021-08-03 4:13 ` [PATCH v2 04/55] target/arm: " Richard Henderson
2021-08-03 4:13 ` [PATCH v2 05/55] target/hppa: " Richard Henderson
2021-08-18 8:46 ` Philippe Mathieu-Daudé
2021-08-03 4:13 ` [PATCH v2 06/55] target/microblaze: Do not set MO_ALIGN " Richard Henderson
2021-08-04 9:25 ` Edgar E. Iglesias
2021-08-03 4:13 ` [PATCH v2 07/55] target/mips: Implement do_unaligned_access " Richard Henderson
2021-08-19 19:33 ` Peter Maydell
2021-08-03 4:13 ` [PATCH v2 08/55] target/ppc: Move SPR_DSISR setting to powerpc_excp Richard Henderson
2021-08-03 4:13 ` [PATCH v2 09/55] target/ppc: Set fault address in ppc_cpu_do_unaligned_access Richard Henderson
2021-08-03 4:13 ` [PATCH v2 10/55] target/ppc: Implement do_unaligned_access for user-only Richard Henderson
2021-08-03 4:13 ` [PATCH v2 11/55] target/riscv: " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 12/55] target/s390x: " Richard Henderson
2021-08-18 8:47 ` Philippe Mathieu-Daudé
2021-08-03 4:14 ` [PATCH v2 13/55] target/sh4: Set fault address in superh_cpu_do_unaligned_access Richard Henderson
2021-08-03 4:14 ` [PATCH v2 14/55] target/sh4: Implement do_unaligned_access for user-only Richard Henderson
2021-08-03 4:14 ` [PATCH v2 15/55] target/sparc: Remove DEBUG_UNALIGNED Richard Henderson
2021-08-18 8:36 ` Mark Cave-Ayland
2021-08-03 4:14 ` [PATCH v2 16/55] target/sparc: Split out build_sfsr Richard Henderson
2021-08-18 8:38 ` Mark Cave-Ayland
2021-08-03 4:14 ` [PATCH v2 17/55] target/sparc: Set fault address in sparc_cpu_do_unaligned_access Richard Henderson
2021-08-18 8:47 ` Mark Cave-Ayland
2021-08-03 4:14 ` [PATCH v2 18/55] target/sparc: Implement do_unaligned_access for user-only Richard Henderson
2021-08-18 8:48 ` Mark Cave-Ayland
2021-08-03 4:14 ` [PATCH v2 19/55] target/xtensa: " Richard Henderson
2021-08-03 5:38 ` Max Filippov
2021-08-18 8:48 ` Philippe Mathieu-Daudé
2021-08-03 4:14 ` [PATCH v2 20/55] accel/tcg: Report unaligned atomics " Richard Henderson
2021-08-03 15:54 ` Alex Bennée
2021-08-18 8:51 ` Philippe Mathieu-Daudé
2021-08-18 17:47 ` Richard Henderson
2021-08-03 4:14 ` [PATCH v2 21/55] accel/tcg: Drop signness in tracing in cputlb.c Richard Henderson
2021-08-03 15:58 ` Alex Bennée
2021-08-03 4:14 ` [PATCH v2 22/55] tcg: Expand MO_SIZE to 3 bits Richard Henderson
2021-08-03 4:14 ` [PATCH v2 23/55] tcg: Rename TCGMemOpIdx to MemOpIdx Richard Henderson
2021-08-03 4:14 ` [PATCH v2 24/55] tcg: Split out MemOpIdx to exec/memopidx.h Richard Henderson
2021-08-03 4:14 ` [PATCH v2 25/55] trace/mem: Pass MemOpIdx to trace_mem_get_info Richard Henderson
2021-08-03 4:14 ` [PATCH v2 26/55] accel/tcg: Pass MemOpIdx to atomic_trace_*_post Richard Henderson
2021-08-03 4:14 ` [PATCH v2 27/55] plugins: Reorg arguments to qemu_plugin_vcpu_mem_cb Richard Henderson
2021-08-03 4:14 ` [PATCH v2 28/55] trace: Split guest_mem_before Richard Henderson
2021-08-18 8:58 ` Philippe Mathieu-Daudé
2021-08-03 4:14 ` [PATCH v2 29/55] target/arm: Use MO_128 for 16 byte atomics Richard Henderson
2021-08-03 4:14 ` [PATCH v2 30/55] target/i386: " Richard Henderson
2021-08-18 8:59 ` Philippe Mathieu-Daudé
2021-08-03 4:14 ` [PATCH v2 31/55] target/ppc: " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 32/55] target/s390x: " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 33/55] target/hexagon: Implement cpu_mmu_index Richard Henderson
2021-08-03 4:14 ` [PATCH v2 34/55] accel/tcg: Add cpu_{ld,st}*_mmu interfaces Richard Henderson
2021-08-18 9:01 ` Philippe Mathieu-Daudé
2021-08-18 17:50 ` Richard Henderson
2021-08-03 4:14 ` [PATCH v2 35/55] accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h Richard Henderson
2021-08-03 4:14 ` [PATCH v2 36/55] target/mips: Use cpu_*_data_ra for msa load/store Richard Henderson
2021-08-03 4:14 ` [PATCH v2 37/55] target/mips: Use 8-byte memory ops " Richard Henderson
2021-08-18 9:21 ` Philippe Mathieu-Daudé
2021-08-18 17:55 ` Richard Henderson
2021-08-03 4:14 ` [PATCH v2 38/55] target/s390x: Use cpu_*_mmu instead of helper_*_mmu Richard Henderson
2021-08-03 11:44 ` David Hildenbrand
2021-08-03 4:14 ` [PATCH v2 39/55] target/sparc: " Richard Henderson
2021-08-03 9:55 ` Philippe Mathieu-Daudé
2021-08-18 8:51 ` Mark Cave-Ayland
2021-08-03 4:14 ` [PATCH v2 40/55] target/arm: " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 41/55] tcg: Move helper_*_mmu decls to tcg/tcg-ldst.h Richard Henderson
2021-08-03 4:14 ` [PATCH v2 42/55] tcg: Add helper_unaligned_mmu for user-only sigbus Richard Henderson
2021-08-03 4:14 ` [PATCH v2 43/55] tcg/i386: Support raising sigbus for user-only Richard Henderson
2021-08-03 4:14 ` [PATCH v2 44/55] tests/tcg/multiarch: Add sigbus.c Richard Henderson
2021-08-03 4:14 ` [PATCH v2 45/55] linux-user: Split out do_prctl and subroutines Richard Henderson
2021-08-03 4:14 ` [PATCH v2 46/55] linux-user: Disable more prctl subcodes Richard Henderson
2021-08-03 4:14 ` [PATCH v2 47/55] hw/core/cpu: Re-sort the non-pointers to the end of CPUClass Richard Henderson
2021-08-03 4:14 ` [PATCH v2 48/55] linux-user: Add code for PR_GET/SET_UNALIGN Richard Henderson
2021-08-03 4:14 ` [PATCH v2 49/55] hw/core/cpu: Move cpu properties to cpu-sysemu.c Richard Henderson
2021-08-03 4:14 ` [PATCH v2 50/55] hw/core/cpu: Add prctl-unalign-sigbus property for user-only Richard Henderson
2021-08-03 4:14 ` [PATCH v2 51/55] target/alpha: Reorg fp memory operations Richard Henderson
2021-08-03 4:14 ` [PATCH v2 52/55] target/alpha: Reorg integer " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 53/55] target/alpha: Implement prctl_unalign_sigbus Richard Henderson
2021-08-03 4:14 ` [PATCH v2 54/55] target/hppa: " Richard Henderson
2021-08-03 4:14 ` [PATCH v2 55/55] target/sh4: " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803041443.55452-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.