* [PATCH] perf/x86: remove unused assignment to pointer e
@ 2021-08-04 11:57 Colin King
2021-08-05 9:34 ` [tip: perf/core] " tip-bot2 for Colin Ian King
2021-08-26 8:09 ` [tip: perf/core] perf/x86: Remove unused assignment to pointer 'e' tip-bot2 for Colin Ian King
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2021-08-04 11:57 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Thomas Gleixner, Borislav Petkov, x86, H . Peter Anvin,
linux-perf-users
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer e is being assigned a value that is never read, the assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/x86/events/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index 1eb45139fcc6..4110fe1b783e 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -1087,10 +1087,8 @@ int x86_schedule_events(struct cpu_hw_events *cpuc, int n, int *assign)
* validate an event group (assign == NULL)
*/
if (!unsched && assign) {
- for (i = 0; i < n; i++) {
- e = cpuc->event_list[i];
+ for (i = 0; i < n; i++)
static_call_cond(x86_pmu_commit_scheduling)(cpuc, i, assign[i]);
- }
} else {
for (i = n0; i < n; i++) {
e = cpuc->event_list[i];
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [tip: perf/core] perf/x86: remove unused assignment to pointer e
2021-08-04 11:57 [PATCH] perf/x86: remove unused assignment to pointer e Colin King
@ 2021-08-05 9:34 ` tip-bot2 for Colin Ian King
2021-08-26 8:09 ` [tip: perf/core] perf/x86: Remove unused assignment to pointer 'e' tip-bot2 for Colin Ian King
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Colin Ian King @ 2021-08-05 9:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: Colin Ian King, Peter Zijlstra (Intel), x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 79551ec0782895af27d6aa9b3abb6d547b7260d3
Gitweb: https://git.kernel.org/tip/79551ec0782895af27d6aa9b3abb6d547b7260d3
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Wed, 04 Aug 2021 12:57:10 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 04 Aug 2021 15:16:39 +02:00
perf/x86: remove unused assignment to pointer e
The pointer e is being assigned a value that is never read, the assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210804115710.109608-1-colin.king@canonical.com
---
arch/x86/events/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index c0167d5..f4e5fa7 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -1085,10 +1085,8 @@ int x86_schedule_events(struct cpu_hw_events *cpuc, int n, int *assign)
* validate an event group (assign == NULL)
*/
if (!unsched && assign) {
- for (i = 0; i < n; i++) {
- e = cpuc->event_list[i];
+ for (i = 0; i < n; i++)
static_call_cond(x86_pmu_commit_scheduling)(cpuc, i, assign[i]);
- }
} else {
for (i = n0; i < n; i++) {
e = cpuc->event_list[i];
^ permalink raw reply related [flat|nested] 3+ messages in thread* [tip: perf/core] perf/x86: Remove unused assignment to pointer 'e'
2021-08-04 11:57 [PATCH] perf/x86: remove unused assignment to pointer e Colin King
2021-08-05 9:34 ` [tip: perf/core] " tip-bot2 for Colin Ian King
@ 2021-08-26 8:09 ` tip-bot2 for Colin Ian King
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Colin Ian King @ 2021-08-26 8:09 UTC (permalink / raw)
To: linux-tip-commits
Cc: Colin Ian King, Peter Zijlstra (Intel), Ingo Molnar, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 4f32da76a1401dcd088930f0ac8658425524368b
Gitweb: https://git.kernel.org/tip/4f32da76a1401dcd088930f0ac8658425524368b
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Wed, 04 Aug 2021 12:57:10 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 26 Aug 2021 09:14:36 +02:00
perf/x86: Remove unused assignment to pointer 'e'
The pointer 'e' is being assigned a value that is never read, the assignment
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20210804115710.109608-1-colin.king@canonical.com
---
arch/x86/events/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index 3092fbf..2a57dbe 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -1087,10 +1087,8 @@ int x86_schedule_events(struct cpu_hw_events *cpuc, int n, int *assign)
* validate an event group (assign == NULL)
*/
if (!unsched && assign) {
- for (i = 0; i < n; i++) {
- e = cpuc->event_list[i];
+ for (i = 0; i < n; i++)
static_call_cond(x86_pmu_commit_scheduling)(cpuc, i, assign[i]);
- }
} else {
for (i = n0; i < n; i++) {
e = cpuc->event_list[i];
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-26 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 11:57 [PATCH] perf/x86: remove unused assignment to pointer e Colin King
2021-08-05 9:34 ` [tip: perf/core] " tip-bot2 for Colin Ian King
2021-08-26 8:09 ` [tip: perf/core] perf/x86: Remove unused assignment to pointer 'e' tip-bot2 for Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.