From: Mark Brown <broonie@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: bjorn.andersson@linaro.org, robh@kernel.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org Subject: Re: [PATCH v3 05/20] ASoC: dt-bindings: replace q6afe bindings with q6dsp-audio-ports Date: Wed, 4 Aug 2021 18:53:34 +0100 [thread overview] Message-ID: <20210804175334.GE26252@sirena.org.uk> (raw) In-Reply-To: <20210803125411.28066-6-srinivas.kandagatla@linaro.org> [-- Attachment #1: Type: text/plain, Size: 845 bytes --] On Tue, Aug 03, 2021 at 01:53:56PM +0100, Srinivas Kandagatla wrote: > DSP Audio Ports bindings have been documented with DSP services bindings > which makes it difficult to reuse them, so pull them out in to a dedicated > bindings. > Also as part of this change convert them into yaml format. > This patch also removes q6afe bindings as dsp services are now documented in > apr bindings. This feels like it's multiple changes stuffed into one commit which makes it difficult to review, especially since I'm having a hard time connecting the code changes with the description. For example this says it removes the "q6afe bindings" but we seem to be adding some in the newly added YAML file. At the very least the commit message needs to be improved but I think this probably needs to be split out into separate changes each doing one thing. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: robh@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, devicetree@vger.kernel.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v3 05/20] ASoC: dt-bindings: replace q6afe bindings with q6dsp-audio-ports Date: Wed, 4 Aug 2021 18:53:34 +0100 [thread overview] Message-ID: <20210804175334.GE26252@sirena.org.uk> (raw) In-Reply-To: <20210803125411.28066-6-srinivas.kandagatla@linaro.org> [-- Attachment #1: Type: text/plain, Size: 845 bytes --] On Tue, Aug 03, 2021 at 01:53:56PM +0100, Srinivas Kandagatla wrote: > DSP Audio Ports bindings have been documented with DSP services bindings > which makes it difficult to reuse them, so pull them out in to a dedicated > bindings. > Also as part of this change convert them into yaml format. > This patch also removes q6afe bindings as dsp services are now documented in > apr bindings. This feels like it's multiple changes stuffed into one commit which makes it difficult to review, especially since I'm having a hard time connecting the code changes with the description. For example this says it removes the "q6afe bindings" but we seem to be adding some in the newly added YAML file. At the very least the commit message needs to be improved but I think this probably needs to be split out into separate changes each doing one thing. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-04 17:53 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-03 12:53 [PATCH v3 00/20] ASoC: qcom: Add AudioReach support Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 01/20] soc: dt-bindings: qcom: apr: convert to yaml Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 02/20] soc: qcom: apr: make code more reuseable Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 03/20] soc: dt-bindings: qcom: add gpr bindings Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 04/20] soc: qcom: apr: Add GPR support Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 05/20] ASoC: dt-bindings: replace q6afe bindings with q6dsp-audio-ports Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-04 17:53 ` Mark Brown [this message] 2021-08-04 17:53 ` Mark Brown 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-11 18:19 ` Rob Herring 2021-08-11 18:19 ` Rob Herring 2021-08-03 12:53 ` [PATCH v3 06/20] ASoC: dt-bindings: replace q6afe-clk with q6dsp audio clk bindings Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-11 18:24 ` Rob Herring 2021-08-11 18:24 ` Rob Herring 2021-08-03 12:53 ` [PATCH v3 07/20] ASoC: dt-bindings: replace q6asm with q6dsp audio stream bindings Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:53 ` [PATCH v3 08/20] ASoC: qdsp6: q6afe-dai: move lpass audio ports to common file Srinivas Kandagatla 2021-08-03 12:53 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 09/20] ASoC: qdsp6: q6afe-clocks: move audio-clocks " Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 10/20] ASoC: dt-bindings: q6dsp: add q6apm-dai compatible Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-04 18:01 ` Mark Brown 2021-08-04 18:01 ` Mark Brown 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 11/20] ASoC: dt-bindings: q6dsp: add q6apm-bedai compatible Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-04 18:01 ` Mark Brown 2021-08-04 18:01 ` Mark Brown 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-05 9:16 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 12/20] ASoC: dt-bindings: q6dsp-clocks: add q6prm clocks compatible Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-04 18:02 ` Mark Brown 2021-08-04 18:02 ` Mark Brown 2021-08-05 9:17 ` Srinivas Kandagatla 2021-08-05 9:17 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 13/20] ASoC: qdsp6: audioreach: add basic pkt alloc support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 14:19 ` Amadeusz Sławiński 2021-08-03 14:39 ` Srinivas Kandagatla 2021-08-04 18:09 ` Mark Brown 2021-08-04 18:09 ` Mark Brown 2021-08-05 9:17 ` Srinivas Kandagatla 2021-08-05 9:17 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 14/20] ASoC: qdsp6: audioreach: add q6apm support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 14:20 ` Amadeusz Sławiński 2021-08-03 14:48 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 15/20] ASoC: qdsp6: audioreach: add module configuration command helpers Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 16/20] ASoC: qdsp6: audioreach: add topology support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 14:21 ` Amadeusz Sławiński 2021-08-03 14:47 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 17/20] ASoC: qdsp6: audioreach: add q6apm-dai support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 18/20] ASoC: qdsp6: audioreach: add bedai support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 19/20] ASoC: qdsp6: audioreach: add q6prm support Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 12:54 ` [PATCH v3 20/20] ASoC: qdsp6: audioreach: add support for q6prm-clocks Srinivas Kandagatla 2021-08-03 12:54 ` Srinivas Kandagatla 2021-08-03 15:00 ` [PATCH v3 00/20] ASoC: qcom: Add AudioReach support Pierre-Louis Bossart 2021-08-03 15:03 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210804175334.GE26252@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bgoswami@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=perex@perex.cz \ --cc=plai@codeaurora.org \ --cc=robh@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.