drivers/net/wwan/wwan_core.c:566 wwan_port_fops_open() warn: passing a valid pointer to 'PTR_ERR'

drivers/net/wwan/wwan_core.c:566 wwan_port_fops_open() warn: passing a valid pointer to 'PTR_ERR'

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Loic Poulain <loic.poulain@linaro.org>

Hi Loic,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   251a1524293d0a90c4d5060f65f42a3016280049
commit: 89212e160b81e778f829b89743570665810e3b13 net: wwan: Fix WWAN config symbols
date:   7 weeks ago
:::::: branch date: 5 hours ago
:::::: commit date: 7 weeks ago
config: nios2-randconfig-m031-20210804 (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/net/wwan/wwan_core.c:566 wwan_port_fops_open() warn: passing a valid pointer to 'PTR_ERR'
drivers/net/wwan/wwan_core.c:914 wwan_rtnl_newlink() warn: passing a valid pointer to 'PTR_ERR'

Old smatch warnings:
arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: uninitialized symbol 'sp'.

vim +/PTR_ERR +566 drivers/net/wwan/wwan_core.c

9a44c1cc638876 Loic Poulain 2021-04-16  558  
9a44c1cc638876 Loic Poulain 2021-04-16  559  static int wwan_port_fops_open(struct inode *inode, struct file *file)
9a44c1cc638876 Loic Poulain 2021-04-16  560  {
9a44c1cc638876 Loic Poulain 2021-04-16  561  	struct wwan_port *port;
9a44c1cc638876 Loic Poulain 2021-04-16  562  	int err = 0;
9a44c1cc638876 Loic Poulain 2021-04-16  563  
9a44c1cc638876 Loic Poulain 2021-04-16  564  	port = wwan_port_get_by_minor(iminor(inode));
9a44c1cc638876 Loic Poulain 2021-04-16  565  	if (IS_ERR(port))
9a44c1cc638876 Loic Poulain 2021-04-16 @566  		return PTR_ERR(port);
9a44c1cc638876 Loic Poulain 2021-04-16  567  
9a44c1cc638876 Loic Poulain 2021-04-16  568  	file->private_data = port;
9a44c1cc638876 Loic Poulain 2021-04-16  569  	stream_open(inode, file);
9a44c1cc638876 Loic Poulain 2021-04-16  570  
9a44c1cc638876 Loic Poulain 2021-04-16  571  	err = wwan_port_op_start(port);
9a44c1cc638876 Loic Poulain 2021-04-16  572  	if (err)
9a44c1cc638876 Loic Poulain 2021-04-16  573  		put_device(&port->dev);
9a44c1cc638876 Loic Poulain 2021-04-16  574  
9a44c1cc638876 Loic Poulain 2021-04-16  575  	return err;
9a44c1cc638876 Loic Poulain 2021-04-16  576  }
9a44c1cc638876 Loic Poulain 2021-04-16  577  

:::::: The code at line 566 was first introduced by commit
:::::: 9a44c1cc63887627284ae232a9626a9f1cd066fc net: Add a WWAN subsystem

:::::: TO: Loic Poulain <loic.poulain@linaro.org>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31968 bytes --]