From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: Marcelo Schmitt <firstname.lastname@example.org> Cc: Jonathan Cameron <email@example.com>, <firstname.lastname@example.org>, "Rob Herring" <email@example.com>, <Michael.Hennerich@analog.com>, <firstname.lastname@example.org>, <email@example.com>, Nuno Sa <Nuno.Sa@analog.com> Subject: Re: [PATCH 00/17] iio:adc:ad7280a Cleanup and proposed staging graduation. Date: Thu, 5 Aug 2021 13:51:53 +0100 [thread overview] Message-ID: <20210805135153.00004133@Huawei.com> (raw) In-Reply-To: <YQtgZMWv5nfMgP8firstname.lastname@example.org> On Thu, 5 Aug 2021 00:52:04 -0300 Marcelo Schmitt <email@example.com> wrote: > [...] > > > > > > > Note there is loads of stuff that isn't implemented as it was developed alongside > > > this patch series to verify individual patches rather than with the intent of > > > actually emulating the device. > > > > > OK, will be aware of that. > > > > > It's hard coded to 2 a chain of 3 ad7280a devices because that seemed to hit most possible > > > corner cases. > > > > > > The top commit has the launch string I'm using. You'll need a filesystem, but > > > you can probably use one of the convenient ones debian posts as nocloud cloud > > > images. > > > > > > There is some info on that on people.kernel.org/jic23 as I wrote up how to test > > > CXL stuff on ARM recently and gave guidance on easy ways to get a filesystem. > > > http://cdimage.debian.org/cdimage/cloud/sid/daily/20210702-691/debian-sid-nocloud-arm64-daily-20210702-691.qcow2 > > > will probably work and is more recent than the one linked from that blog post. > > > > I was using a debian imgage created from following the instructions on a > > tutorial pointed by the QEMU docs. > > https://translatedcode.wordpress.com/2017/07/24/installing-debian-on-qemus-64-bit-arm-virt-board/ > > Anyhow, I'll chance to the nocloud one if see things don't get working. > > > > > > > > Give me a shout if you need more specific guidance than this very very rough guide! > > > > Sure, let's see if I can get through it now. Otherwise ... > > I've managed to get it running and see the emulated ad7280a working. > Still getting some trouble with the ad7150 emulation though. > I added a pull request with some comments about the ad7150 emulation on the > github repository. Will take a look at some point. Thanks. > Overall I don't think it was so hacky, I just wonder if it could have been > done more cleanly by passing a custom dtb in the launching string. The hacks > at virt.c are mostly to add the busses, add the device nodes, and connect > device gpio to interrupt lines. We could do it all by editing a dt, right? > Anyhow, thanks a lot for sharing this stuff. That's the alternative, though you also need to actually create the relevant devices. The dtb stuff is lengthy but really simple to do, it's also somewhat resilient to other changes in how the virt model works (address changes etc). Given I was there anyway, it seemed easier to do it all in one place. > > > > > > > > > I mentioned this thread in the diversion the rust on linux thread took into > > > use of QEMU to emulate devices which motivated me to stop being lazy and at least > > > post this hideous version. Probably the most useful bit is how to get a working > > > spi device emulated on the arm virt machine as that is very handy for all manner > > > of testing. One day someone might implement a large set of IIO device emulation > > > and bolt it into a CI... > > > > Agree, it's hard to get IIO drivers runtime tested because we often don't > > have the required hardware to do it. I think emulation would help us with > > that or, at least, would give us a little bit more confidence in our > > changes than just relying on sharp eyes and compile/static tests. > > Puching that into a CI would also be rather nice. > > > > > > > > Jonathan > > > > > > > > > > > > > > > > > Being able to see it running, I may feel more confident to provide a review > > > > > for this set :) > > Guess I've been too optimistic. The way things are going I may take a few > more weeks to have a closer look at all the patches. I'll try to make it > before the next merge window or give up otherwise. It's not reasonable to > ask you wait more since this set has been sitting on the list for so long. Don't worry about it. Driver was in staging a long time. It can wait as long as we know it will move forwards eventually! Jonathan > > > [...]
prev parent reply other threads:[~2021-08-05 12:52 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 11:34 Jonathan Cameron 2021-06-14 11:34 ` [PATCH 01/17] staging:iio:adc:ad7280a: Fix handing of device address bit reversing Jonathan Cameron 2021-06-14 11:34 ` [PATCH 02/17] staging:iio:adc:ad7280a: Register define cleanup Jonathan Cameron 2021-06-14 11:34 ` [PATCH 03/17] staging:iio:adc:ad7280a: rename _read() to _read_reg() Jonathan Cameron 2021-06-14 11:34 ` [PATCH 04/17] staging:iio:adc:ad7280a: Split buff into tx and rx parts Jonathan Cameron 2021-06-14 11:34 ` [PATCH 05/17] staging:iio:adc:ad7280a: Use bitfield ops to managed fields in transfers Jonathan Cameron 2021-06-14 11:34 ` [PATCH 06/17] staging:iio:adc:ad7280a: Switch to standard event control Jonathan Cameron 2021-06-14 11:34 ` [PATCH 07/17] staging:iio:adc:ad7280a: Standardize extended ABI naming Jonathan Cameron 2021-06-14 11:34 ` [PATCH 08/17] staging:iio:adc:ad7280a: Drop unused timestamp channel Jonathan Cameron 2021-06-14 11:34 ` [PATCH 09/17] staging:iio:adc:ad7280a: Trivial comment formatting cleanup Jonathan Cameron 2021-06-14 11:35 ` [PATCH 10/17] staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control Jonathan Cameron 2021-06-14 11:35 ` [PATCH 11/17] staging:iio:adc:ad7280a: Cleanup includes Jonathan Cameron 2021-06-14 11:35 ` [PATCH 12/17] staging:iio:ad7280a: Reflect optionality of irq in ABI Jonathan Cameron 2021-06-14 11:35 ` [PATCH 13/17] staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev Jonathan Cameron 2021-06-14 11:35 ` [PATCH 14/17] staging:iio:adc:ad7280a: Use device properties to replace platform data Jonathan Cameron 2021-06-14 11:35 ` [PATCH 15/17] dt-bindings:iio:adc:ad7280a: Add binding Jonathan Cameron 2021-06-24 20:28 ` Rob Herring 2021-06-14 11:35 ` [PATCH 16/17] iio:adc:ad7280a: Document ABI for cell balance switches Jonathan Cameron 2021-06-14 11:35 ` [PATCH 17/17] iio:adc:ad7280a: Move out of staging Jonathan Cameron 2021-06-22 17:36 ` [PATCH 00/17] iio:adc:ad7280a Cleanup and proposed staging graduation Marcelo Schmitt 2021-06-23 8:37 ` Jonathan Cameron 2021-07-11 14:50 ` Jonathan Cameron 2021-07-12 18:08 ` Marcelo Schmitt 2021-08-05 3:52 ` Marcelo Schmitt 2021-08-05 12:51 ` Jonathan Cameron [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210805135153.00004133@Huawei.com \ --firstname.lastname@example.org \ --cc=Michael.Hennerich@analog.com \ --cc=Nuno.Sa@analog.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 00/17] iio:adc:ad7280a Cleanup and proposed staging graduation.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.