Re: [Buildroot] [PATCH 1/2] package/systemd: set machine id file instalation as optional choice

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Bartosz,

On Sun, 17 Nov 2019 12:33:44 +0100
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> In case of e.g writable systems there is no neccesity to have
> pre-installed empty machine-id file on target because systemd
> generates that automatically during system boot.
> Also in case of having empty machine-id file we are not able
> to use a service with ConditionFirstBoot because systemd recognizes
> machine-id file in system therefore we can't detect new system instance boots up.
> Set this option as enable by default to keep compatibility with old builds.
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  package/systemd/Config.in  | 13 +++++++++++++
>  package/systemd/systemd.mk |  2 ++
>  2 files changed, 15 insertions(+)

This series of two patches has been sitting on the mailing list for a
long time. The feedback of Jérémy was not very positive (i.e quite
negative) and you said yourself on this patch "I had finally a couple
of time to double-check that and I agree with Jeremy that I was wrong
therefore let's reject this patch as it turned out as an unthought
idea.", but then you said you were mistaken, Jeremy asked for
clarifications which were never given.

So at this point, I'm going to mark those two patches as Rejected.
However, if you believe there is still something to improve, do not
hesitate to reopen the discussion.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot