From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steves.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
rf@opensource.wolfsonmicro.com, shumingf@realtek.com,
srinivas.kandagatla@linaro.org, krzk@kernel.org, dmurphy@ti.com,
jack.yu@realtek.com, nuno.sa@analog.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
ryan.lee.maxim@gmail.com, steves.lee.maxim@gmail.com
Subject: Re: [PATCH] ASoC: max98390: Add support change dsm param name
Date: Fri, 6 Aug 2021 12:03:01 +0100 [thread overview]
Message-ID: <20210806110301.GW26252@sirena.org.uk> (raw)
In-Reply-To: <20210806080834.16705-1-steves.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Fri, Aug 06, 2021 at 05:08:34PM +0900, Steve Lee wrote:
> ret = request_firmware(&fw, filename, component->dev);
> if (ret) {
> - ret = request_firmware(&fw, "dsm_param.bin", component->dev);
> + ret = request_firmware(&fw, "dsmparam.bin", component->dev);
This will break anything using dsm_param.bin as the default - why make
the change?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Steve Lee <steves.lee@maximintegrated.com>
Cc: jack.yu@realtek.com, alsa-devel@alsa-project.org,
ryan.lee.maxim@gmail.com, ckeepax@opensource.cirrus.com,
steves.lee.maxim@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, krzk@kernel.org, lgirdwood@gmail.com,
nuno.sa@analog.com, geert@linux-m68k.org, dmurphy@ti.com,
shumingf@realtek.com, rf@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: max98390: Add support change dsm param name
Date: Fri, 6 Aug 2021 12:03:01 +0100 [thread overview]
Message-ID: <20210806110301.GW26252@sirena.org.uk> (raw)
In-Reply-To: <20210806080834.16705-1-steves.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Fri, Aug 06, 2021 at 05:08:34PM +0900, Steve Lee wrote:
> ret = request_firmware(&fw, filename, component->dev);
> if (ret) {
> - ret = request_firmware(&fw, "dsm_param.bin", component->dev);
> + ret = request_firmware(&fw, "dsmparam.bin", component->dev);
This will break anything using dsm_param.bin as the default - why make
the change?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-06 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 8:08 [PATCH] ASoC: max98390: Add support change dsm param name Steve Lee
2021-08-06 11:03 ` Mark Brown [this message]
2021-08-06 11:03 ` Mark Brown
2021-08-09 0:57 ` [EXTERNAL] " Steve Lee
2021-08-09 0:57 ` Steve Lee
2021-08-09 12:21 ` Mark Brown
2021-08-09 12:21 ` Mark Brown
2021-08-09 13:55 ` Steve Lee
2021-08-09 13:55 ` Steve Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806110301.GW26252@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee.maxim@gmail.com \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.