All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	u-boot-amlogic@groups.io, u-boot@lists.denx.de,
	Guillaume La Roque <glaroque@baylibre.com>
Subject: Re: [PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN
Date: Fri, 6 Aug 2021 08:47:42 -0400	[thread overview]
Message-ID: <20210806124742.GW858@bill-the-cat> (raw)
In-Reply-To: <87pmurj57d.fsf@baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

On Fri, Aug 06, 2021 at 11:24:54AM +0200, Mattijs Korpershoek wrote:
> Hi Tom, Neil,
> 
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
> > On 05/08/2021 19:16, Tom Rini wrote:
> >> On Thu, Aug 05, 2021 at 06:20:53PM +0200, Neil Armstrong wrote:
> >>> On 05/08/2021 17:17, Mattijs Korpershoek wrote:
> >>>> Permit redefining SYS_MALLOC_LEN for board specific configs.
> >>>> This is especially useful for Android with AVB, which requires a malloc
> >>>> length of 128M.
> >>>>
> >>>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> >>>> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> >>>> ---
> >>>>  include/configs/meson64.h | 2 ++
> >>>>  1 file changed, 2 insertions(+)
> >>>>
> >>>> diff --git a/include/configs/meson64.h b/include/configs/meson64.h
> >>>> index fb7f16d148..f9bb0240d2 100644
> >>>> --- a/include/configs/meson64.h
> >>>> +++ b/include/configs/meson64.h
> >>>> @@ -32,7 +32,9 @@
> >>>>  #define CONFIG_CPU_ARMV8
> >>>>  #define CONFIG_REMAKE_ELF
> >>>>  #define CONFIG_SYS_MAXARGS		32
> >>>> +#ifndef CONFIG_SYS_MALLOC_LEN
> >>>>  #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
> >>>> +#endif
> >>>>  #define CONFIG_SYS_CBSIZE		1024
> >>>>  
> >>>>  #define CONFIG_SYS_SDRAM_BASE		0
> >>>>
> >>>
> >>> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> >> 
> >> I prefer to see these as SZ_xxx, but also what's the minimum DRAM you're
> >> going to see on a meson64 platform?  And if it's 1GB or more, why not
> >> just use 128MB for everyone?
> >> 
> >
> > We can get down to 256MiB DRAM (very rare), but 512MiB is used on La Frite.
> In that case, I think it's more reasonable to keep the change as-is.
> I'll send a v2 replacing (32 << 20) by SZ_32M

tbh, using SZ_xxx isn't a big enough issue to v2 things over.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-08-06 12:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 15:17 [PATCH 0/9] meson64_android: Android boot flow using abootimg Mattijs Korpershoek
2021-08-05 15:17 ` [PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN Mattijs Korpershoek
2021-08-05 16:20   ` Neil Armstrong
2021-08-05 17:16     ` Tom Rini
2021-08-06  7:54       ` Neil Armstrong
2021-08-06  9:24         ` Mattijs Korpershoek
2021-08-06 12:47           ` Tom Rini [this message]
2021-08-06 12:46         ` Tom Rini
2021-08-05 15:17 ` [PATCH 2/9] configs: meson64_android: increase SYS_MALLOC_LEN to 128M for AVB Mattijs Korpershoek
2021-08-05 16:20   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 3/9] configs: meson64_android: implement AVB support Mattijs Korpershoek
2021-08-05 16:20   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 4/9] configs: meson64_android: implement A/B slot support Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 5/9] configs: meson64_android: define BOOT_CMD macro Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 6/9] configs: meson64_android: boot android via abootimg Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 7/9] configs: sei510/sei610: reformat PARTS_default Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 8/9] configs: sei510/sei610: don't use hard-coded gpt uuids Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 15:17 ` [PATCH 9/9] configs: sei510/610: android bootflow via abootimg Mattijs Korpershoek
2021-08-05 16:21   ` Neil Armstrong
2021-08-05 17:23 ` [PATCH 0/9] meson64_android: Android boot flow using abootimg Tom Rini
2021-08-06  7:57   ` Neil Armstrong
2021-08-06 15:36     ` Mattijs Korpershoek
2021-08-06 15:56       ` Tom Rini
2021-08-10  8:41         ` Neil Armstrong
2021-08-10  8:47 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806124742.GW858@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=glaroque@baylibre.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.