[PATCH linux-next] scripts/sorttable: remove duplicate include in sorttable.c

[PATCH linux-next] scripts/sorttable: remove duplicate include in sorttable.c

[cgel.zte]

From: yong yiran <yong.yiran@zte.com.cn>

'sorttable.h' included in 'sorttable.c' is duplicated.
Remove all but the first include of sorttable.h from sorttable.c.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
---
 scripts/sorttable.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index 0ef3abfc4a51..cb080c71a66c 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -188,7 +188,6 @@ static inline unsigned int get_secindex(unsigned int shndx,
 /* 32 bit and 64 bit are very similar */
 #include "sorttable.h"
 #define SORTTABLE_64
-#include "sorttable.h"
 
 static int compare_relative_table(const void *a, const void *b)
 {
-- 
2.25.1

Re: [PATCH linux-next] scripts/sorttable: remove duplicate include in sorttable.c

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3616 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210805]

url:    https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/scripts-sorttable-remove-duplicate-include-in-sorttable-c/20210806-153154
base:    18aeb561e3fdbd385379d82b079c3dec1f57793e
config: powerpc-randconfig-s032-20210804 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 10.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/c9d4c7820745856a5b314bf2149ae80176674daa
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review cgel-zte-gmail-com/scripts-sorttable-remove-duplicate-include-in-sorttable-c/20210806-153154
        git checkout c9d4c7820745856a5b314bf2149ae80176674daa
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/cc1eeVKJ.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
--
   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/cc8dIuyE.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
   make[2]: *** [scripts/Makefile.host:95: scripts/sorttable] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1295: scripts] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:227: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/ccikgeur.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
   make[2]: *** [scripts/Makefile.host:95: scripts/sorttable] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1295: scripts] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:227: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39622 bytes --]

Re: [PATCH linux-next] scripts/sorttable: remove duplicate include in sorttable.c

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3687 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210805]

url:    https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/scripts-sorttable-remove-duplicate-include-in-sorttable-c/20210806-153154
base:    18aeb561e3fdbd385379d82b079c3dec1f57793e
config: powerpc-randconfig-s032-20210804 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 10.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/c9d4c7820745856a5b314bf2149ae80176674daa
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review cgel-zte-gmail-com/scripts-sorttable-remove-duplicate-include-in-sorttable-c/20210806-153154
        git checkout c9d4c7820745856a5b314bf2149ae80176674daa
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/cc1eeVKJ.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
--
   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/cc8dIuyE.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
   make[2]: *** [scripts/Makefile.host:95: scripts/sorttable] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1295: scripts] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:227: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   scripts/sorttable.c: In function 'do_file':
>> scripts/sorttable.c:379:8: warning: implicit declaration of function 'do_sort_64'; did you mean 'do_sort_32'? [-Wimplicit-function-declaration]
     379 |   rc = do_sort_64(ghdr, fname, custom_sort);
         |        ^~~~~~~~~~
         |        do_sort_32
   /usr/bin/ld: /tmp/ccikgeur.o: in function `main':
>> sorttable.c:(.text.startup+0x618): undefined reference to `do_sort_64'
   collect2: error: ld returned 1 exit status
   make[2]: *** [scripts/Makefile.host:95: scripts/sorttable] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1295: scripts] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:227: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39622 bytes --]