From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Corey Minyard <minyard@acm.org>
Cc: kernel@pengutronix.de, alsa-devel@alsa-project.org,
linux-parisc@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Helge Deller <deller@gmx.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-scsi@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
netdev@vger.kernel.org, linux-serial@vger.kernel.org,
linux-input@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
openipmi-developer@lists.sourceforge.net,
Jaroslav Kysela <perex@perex.cz>,
Jiri Slaby <jirislaby@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void
Date: Sat, 7 Aug 2021 11:11:35 +0200 [thread overview]
Message-ID: <20210807091135.xgenctifq3wgn3ro@pengutronix.de> (raw)
In-Reply-To: <20210806174927.GJ3406@minyard.net>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
Hello,
On Fri, Aug 06, 2021 at 12:49:27PM -0500, Corey Minyard wrote:
> On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> > -int ipmi_si_remove_by_dev(struct device *dev)
> > +void ipmi_si_remove_by_dev(struct device *dev)
>
> This function is also used by ipmi_si_platform.c, so you can't change
> this.
Did you see that I adapted ipmi_si_platform.c below? That is an instance
of "Make [ipmi_si_remove_by_dev] return void, too, as for all other
callers the value is ignored, too." (In ipmi_si_platform.c the return
value is used in a struct platform_driver::remove function. The value
returned there is ignored, see commit
e5e1c209788138f33ca6558bf9f572f6904f486d.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Corey Minyard <minyard@acm.org>
Cc: linux-input@vger.kernel.org, alsa-devel@alsa-project.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Helge Deller <deller@gmx.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
netdev@vger.kernel.org, kernel@pengutronix.de,
linux-scsi@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
openipmi-developer@lists.sourceforge.net,
Jiri Slaby <jirislaby@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void
Date: Sat, 7 Aug 2021 11:11:35 +0200 [thread overview]
Message-ID: <20210807091135.xgenctifq3wgn3ro@pengutronix.de> (raw)
In-Reply-To: <20210806174927.GJ3406@minyard.net>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
Hello,
On Fri, Aug 06, 2021 at 12:49:27PM -0500, Corey Minyard wrote:
> On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> > -int ipmi_si_remove_by_dev(struct device *dev)
> > +void ipmi_si_remove_by_dev(struct device *dev)
>
> This function is also used by ipmi_si_platform.c, so you can't change
> this.
Did you see that I adapted ipmi_si_platform.c below? That is an instance
of "Make [ipmi_si_remove_by_dev] return void, too, as for all other
callers the value is ignored, too." (In ipmi_si_platform.c the return
value is used in a struct platform_driver::remove function. The value
returned there is ignored, see commit
e5e1c209788138f33ca6558bf9f572f6904f486d.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-07 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:39 [PATCH] parisc: Make struct parisc_driver::remove() return void Uwe Kleine-König
2021-08-06 9:39 ` Uwe Kleine-König
2021-08-06 15:20 ` kernel test robot
2021-08-06 17:49 ` Corey Minyard
2021-08-06 17:49 ` Corey Minyard
2021-08-07 9:11 ` Uwe Kleine-König [this message]
2021-08-07 9:11 ` Uwe Kleine-König
2021-08-06 18:46 ` Dmitry Torokhov
2021-08-06 18:46 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210807091135.xgenctifq3wgn3ro@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alsa-devel@alsa-project.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=minyard@acm.org \
--cc=netdev@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.