* [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable
2021-08-07 10:22 [PATCH 0/4] Remove unused variable Saurav Girepunje
@ 2021-08-07 10:22 ` Saurav Girepunje
2021-08-07 14:50 ` Fabio Aiuto
2021-08-07 10:22 ` [PATCH 2/4] staging: rtl8188eu :os_dep :os_intfs : remove " Saurav Girepunje
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Saurav Girepunje @ 2021-08-07 10:22 UTC (permalink / raw)
To: gregkh, Larry.Finger, saurav.girepunje, insafonov, straube.linux,
martin, will+git, dan.carpenter, apais, yashsri421, fabioaiuto83,
marcocesati, ross.schm.dev, linux-staging, linux-kernel
Remove unused variable data and data_len from mon_recv_decrypted() in mon.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
index 73b9599fe0dc..7c7cb29ee005 100644
--- a/drivers/staging/rtl8188eu/os_dep/mon.c
+++ b/drivers/staging/rtl8188eu/os_dep/mon.c
@@ -58,8 +58,7 @@ static void mon_recv_decrypted(struct net_device *dev, const u8 *data,
netif_rx(skb);
}
-static void mon_recv_encrypted(struct net_device *dev, const u8 *data,
- int data_len)
+static void mon_recv_encrypted(struct net_device *dev)
{
if (net_ratelimit())
netdev_info(dev, "Encrypted packets are not supported");
@@ -93,7 +92,7 @@ void rtl88eu_mon_recv_hook(struct net_device *dev, struct recv_frame *frame)
if (attr->bdecrypted)
mon_recv_decrypted(dev, data, data_len, iv_len, icv_len);
else
- mon_recv_encrypted(dev, data, data_len);
+ mon_recv_encrypted(dev);
}
/**
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable
2021-08-07 10:22 ` [PATCH 1/4] staging: rtl8188eu: os_dep: " Saurav Girepunje
@ 2021-08-07 14:50 ` Fabio Aiuto
2021-08-07 19:00 ` SAURAV GIREPUNJE
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Aiuto @ 2021-08-07 14:50 UTC (permalink / raw)
To: Saurav Girepunje
Cc: gregkh, Larry.Finger, insafonov, straube.linux, martin, will+git,
dan.carpenter, apais, yashsri421, marcocesati, ross.schm.dev,
linux-staging, linux-kernel
Hello Saurav,
On Sat, Aug 07, 2021 at 03:52:29PM +0530, Saurav Girepunje wrote:
> Remove unused variable data and data_len from mon_recv_decrypted() in mon.c
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
did you rebase you local tree on current staging-testing?
rtl8188eu has been deleted... now there's r8188eu.
thank you,
fabio
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable
2021-08-07 14:50 ` Fabio Aiuto
@ 2021-08-07 19:00 ` SAURAV GIREPUNJE
0 siblings, 0 replies; 7+ messages in thread
From: SAURAV GIREPUNJE @ 2021-08-07 19:00 UTC (permalink / raw)
To: Fabio Aiuto
Cc: gregkh, Larry.Finger, saurav.girepunje, insafonov, straube.linux,
martin, will+git, dan.carpenter, apais, yashsri421, marcocesati,
ross.schm.dev, linux-staging, linux-kernel
On 07 Aug 2021 16:50, Fabio Aiuto wrote:
> Hello Saurav,
>
> On Sat, Aug 07, 2021 at 03:52:29PM +0530, Saurav Girepunje wrote:
> > Remove unused variable data and data_len from mon_recv_decrypted() in mon.c
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
>
> did you rebase you local tree on current staging-testing?
> rtl8188eu has been deleted... now there's r8188eu.
>
> thank you,
>
> fabio
I had not done. Now I did it.
thanks fabio for pointing this.
saurav
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4] staging: rtl8188eu :os_dep :os_intfs : remove unused variable
2021-08-07 10:22 [PATCH 0/4] Remove unused variable Saurav Girepunje
2021-08-07 10:22 ` [PATCH 1/4] staging: rtl8188eu: os_dep: " Saurav Girepunje
@ 2021-08-07 10:22 ` Saurav Girepunje
2021-08-07 10:22 ` [PATCH 3/4] staging: rtl8192e: rtl8192e: rtl_core: remove unused global variable Saurav Girepunje
2021-08-07 10:22 ` [PATCH 4/4] staging: rtl8723bs: os_dep: remove unused variable Saurav Girepunje
3 siblings, 0 replies; 7+ messages in thread
From: Saurav Girepunje @ 2021-08-07 10:22 UTC (permalink / raw)
To: gregkh, Larry.Finger, saurav.girepunje, insafonov, straube.linux,
martin, will+git, dan.carpenter, apais, yashsri421, fabioaiuto83,
marcocesati, ross.schm.dev, linux-staging, linux-kernel
Remove unused variable pnetdev from loadparam in os_intfs.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index a826228cbbe9..81360cee7140 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -136,7 +136,7 @@ MODULE_PARM_DESC(monitor_enable, "Enable monitor interface (default: false)");
static int netdev_close(struct net_device *pnetdev);
-static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
+static void loadparam(struct adapter *padapter)
{
struct registry_priv *registry_par = &padapter->registrypriv;
@@ -315,7 +315,7 @@ struct net_device *rtw_init_netdev(void)
pnetdev->watchdog_timeo = HZ * 3; /* 3 second timeout */
pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
- loadparam(padapter, pnetdev);
+ loadparam(padapter);
return pnetdev;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] staging: rtl8192e: rtl8192e: rtl_core: remove unused global variable
2021-08-07 10:22 [PATCH 0/4] Remove unused variable Saurav Girepunje
2021-08-07 10:22 ` [PATCH 1/4] staging: rtl8188eu: os_dep: " Saurav Girepunje
2021-08-07 10:22 ` [PATCH 2/4] staging: rtl8188eu :os_dep :os_intfs : remove " Saurav Girepunje
@ 2021-08-07 10:22 ` Saurav Girepunje
2021-08-07 10:22 ` [PATCH 4/4] staging: rtl8723bs: os_dep: remove unused variable Saurav Girepunje
3 siblings, 0 replies; 7+ messages in thread
From: Saurav Girepunje @ 2021-08-07 10:22 UTC (permalink / raw)
To: gregkh, Larry.Finger, saurav.girepunje, insafonov, straube.linux,
martin, will+git, dan.carpenter, apais, yashsri421, fabioaiuto83,
marcocesati, ross.schm.dev, linux-staging, linux-kernel
Remove unused global variable channels from rtl_core.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index e85d9c2cdc96..dffae61b517b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -23,7 +23,6 @@
#include "rtl_pm.h"
int hwwep = 1;
-static int channels = 0x3fff;
static char *ifname = "wlan%d";
@@ -2642,8 +2641,6 @@ MODULE_FIRMWARE(RTL8192E_DATA_IMG_FW);
module_param(ifname, charp, 0644);
module_param(hwwep, int, 0644);
-module_param(channels, int, 0644);
MODULE_PARM_DESC(ifname, " Net interface name, wlan%d=default");
MODULE_PARM_DESC(hwwep, " Try to use hardware WEP support(default use hw. set 0 to use software security)");
-MODULE_PARM_DESC(channels, " Channel bitmask for specific locales. NYI");
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/4] staging: rtl8723bs: os_dep: remove unused variable
2021-08-07 10:22 [PATCH 0/4] Remove unused variable Saurav Girepunje
` (2 preceding siblings ...)
2021-08-07 10:22 ` [PATCH 3/4] staging: rtl8192e: rtl8192e: rtl_core: remove unused global variable Saurav Girepunje
@ 2021-08-07 10:22 ` Saurav Girepunje
3 siblings, 0 replies; 7+ messages in thread
From: Saurav Girepunje @ 2021-08-07 10:22 UTC (permalink / raw)
To: gregkh, Larry.Finger, saurav.girepunje, insafonov, straube.linux,
martin, will+git, dan.carpenter, apais, yashsri421, fabioaiuto83,
marcocesati, ross.schm.dev, linux-staging, linux-kernel
Remove below unused static variable from os_intfs.c
rtw_enusbss
rtw_hwpdn_mode
rtw_hwpwrp_detect
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 724909078d80..71c9e7eec206 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -109,11 +109,6 @@ static int rtw_antdiv_cfg = 1; /* 0:OFF , 1:ON, 2:decide by Efuse config */
static int rtw_antdiv_type; /* 0:decide by efuse 1: for 88EE, 1Tx and 1RxCG are diversity.(2 Ant with SPDT), 2: for 88EE, 1Tx and 2Rx are diversity.(2 Ant, Tx and RxCG are both on aux port, RxCS is on main port), 3: for 88EE, 1Tx and 1RxCG are fixed.(1Ant, Tx and RxCG are both on aux port) */
-static int rtw_enusbss;/* 0:disable, 1:enable */
-
-static int rtw_hwpdn_mode = 2;/* 0:disable, 1:enable, 2: by EFUSE config */
-
-static int rtw_hwpwrp_detect; /* HW power ping detect 0:disable , 1:enable */
static int rtw_hw_wps_pbc;
@@ -159,9 +154,6 @@ module_param(rtw_wifi_spec, int, 0644);
module_param(rtw_antdiv_cfg, int, 0644);
module_param(rtw_antdiv_type, int, 0644);
-module_param(rtw_enusbss, int, 0644);
-module_param(rtw_hwpdn_mode, int, 0644);
-module_param(rtw_hwpwrp_detect, int, 0644);
module_param(rtw_hw_wps_pbc, int, 0644);
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread