[Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11

[Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11

[Fabrice Fontaine]

libvirt unconditionally uses HWCAP_CPUID on arm which is only available
since kernel 4.11 and
https://github.com/torvalds/linux/commit/77c97b4ee21290f5f083173d957843b615abbff2
resulting in the following build failure since the addition of the
packahe in commit ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:

../src/cpu/cpu_arm.c: In function 'virCPUarmCpuDataFromRegs':
../src/cpu/cpu_arm.c:562:20: error: 'HWCAP_CPUID' undeclared (first use in this function); did you mean 'HWCAP_PMULL'?
     if (!(hwcaps & HWCAP_CPUID)) {
                    ^~~~~~~~~~~
                    HWCAP_PMULL

Fixes:
 - http://autobuild.buildroot.org/results/85bf7b4dad73a748bf439e63874eb64d9a53088f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libvirt/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
index 2f191882cc..e231511906 100644
--- a/package/libvirt/Config.in
+++ b/package/libvirt/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBVIRT_ARCH_SUPPORTS
 	bool
-	default y if BR2_aarch64
+	default y if BR2_aarch64 && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11
 	default y if BR2_i386
 	default y if BR2_x86_64
 	depends on BR2_USE_MMU # fork()
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11

[Thomas Petazzoni]

On Sat,  7 Aug 2021 18:27:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libvirt unconditionally uses HWCAP_CPUID on arm which is only available
> since kernel 4.11 and
> https://github.com/torvalds/linux/commit/77c97b4ee21290f5f083173d957843b615abbff2
> resulting in the following build failure since the addition of the
> packahe in commit ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:
> 
> ../src/cpu/cpu_arm.c: In function 'virCPUarmCpuDataFromRegs':
> ../src/cpu/cpu_arm.c:562:20: error: 'HWCAP_CPUID' undeclared (first use in this function); did you mean 'HWCAP_PMULL'?
>      if (!(hwcaps & HWCAP_CPUID)) {
>                     ^~~~~~~~~~~
>                     HWCAP_PMULL
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/85bf7b4dad73a748bf439e63874eb64d9a53088f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libvirt/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 2f191882cc..e231511906 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LIBVIRT_ARCH_SUPPORTS
>  	bool
> -	default y if BR2_aarch64
> +	default y if BR2_aarch64 && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11

What bothers me is that for kernel headers dependencies, we normally
have a comment. Is it worth it in this case? Perhaps not.

Yann, Arnout, Peter?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11

[Yann E. MORIN]

Fabrice, All,

On 2021-08-07 18:27 +0200, Fabrice Fontaine spake thusly:
> libvirt unconditionally uses HWCAP_CPUID on arm which is only available
> since kernel 4.11 and
> https://github.com/torvalds/linux/commit/77c97b4ee21290f5f083173d957843b615abbff2
> resulting in the following build failure since the addition of the
> packahe in commit ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:
> 
> ../src/cpu/cpu_arm.c: In function 'virCPUarmCpuDataFromRegs':
> ../src/cpu/cpu_arm.c:562:20: error: 'HWCAP_CPUID' undeclared (first use in this function); did you mean 'HWCAP_PMULL'?
>      if (!(hwcaps & HWCAP_CPUID)) {
>                     ^~~~~~~~~~~
>                     HWCAP_PMULL

The isue was a bit broader than that: libvirt needs headers >= 3.12 for
all architectures, but AArch64, for which it requires 4.11.

The 3.12 requirement was overlooked when the package was added with
ccfc90e1010e, though, but was present in the comment.

So I've added that too.

> Fixes:
>  - http://autobuild.buildroot.org/results/85bf7b4dad73a748bf439e63874eb64d9a53088f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libvirt/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 2f191882cc..e231511906 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LIBVIRT_ARCH_SUPPORTS
>  	bool
> -	default y if BR2_aarch64
> +	default y if BR2_aarch64 && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11

I've moved that part to the main symbol, since it is more logical to
have there, especially since there is a more global dependency on
headers 3.12 now.

Applied to master, thanks.

And damn, I forgot to update the comment! Grr... :-(

Regards,
Yann E. MORIN.

>  	default y if BR2_i386
>  	default y if BR2_x86_64
>  	depends on BR2_USE_MMU # fork()
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot