All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
	a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
	gwendal@chromium.org, alexandre.belloni@bootlin.com,
	david@lechnology.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
	patrick.havelange@essensium.com, fabrice.gasnier@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com
Subject: Re: [PATCH v15 01/13] counter: 104-quad-8: Describe member 'lock' in 'quad8'
Date: Mon, 9 Aug 2021 20:26:37 +0100	[thread overview]
Message-ID: <20210809202637.4aac5c81@jic23-huawei> (raw)
In-Reply-To: <43b4acab9e238638c7067dd4a363a42f94c94ccb.1628511445.git.vilhelm.gray@gmail.com>

On Mon,  9 Aug 2021 21:37:26 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:

> This adds a kernel-doc comment line describing the 'lock' member of the
> 'quad8' structure.
> 
> Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Initially I was confused as to when Syed had acked a new patch, but
then realised you have pulled it out of the later spinlock conversion
patch which Syed had indeed acked, so fair enough.

Applied to the togreg branch of iio.git and (unlike yesterday)
pushed out as testing for 0-day to poke at it.
> ---
>  drivers/counter/104-quad-8.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 5283ff128c17..0caa60537b14 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -28,6 +28,7 @@ MODULE_PARM_DESC(base, "ACCES 104-QUAD-8 base addresses");
>  
>  /**
>   * struct quad8 - device private data structure
> + * @lock:		lock to prevent clobbering device states during R/W ops
>   * @counter:		instance of the counter_device
>   * @fck_prescaler:	array of filter clock prescaler configurations
>   * @preset:		array of preset values


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
	a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
	gwendal@chromium.org, alexandre.belloni@bootlin.com,
	david@lechnology.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
	patrick.havelange@essensium.com, fabrice.gasnier@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com
Subject: Re: [PATCH v15 01/13] counter: 104-quad-8: Describe member 'lock' in 'quad8'
Date: Mon, 9 Aug 2021 20:26:37 +0100	[thread overview]
Message-ID: <20210809202637.4aac5c81@jic23-huawei> (raw)
In-Reply-To: <43b4acab9e238638c7067dd4a363a42f94c94ccb.1628511445.git.vilhelm.gray@gmail.com>

On Mon,  9 Aug 2021 21:37:26 +0900
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:

> This adds a kernel-doc comment line describing the 'lock' member of the
> 'quad8' structure.
> 
> Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Initially I was confused as to when Syed had acked a new patch, but
then realised you have pulled it out of the later spinlock conversion
patch which Syed had indeed acked, so fair enough.

Applied to the togreg branch of iio.git and (unlike yesterday)
pushed out as testing for 0-day to poke at it.
> ---
>  drivers/counter/104-quad-8.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 5283ff128c17..0caa60537b14 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -28,6 +28,7 @@ MODULE_PARM_DESC(base, "ACCES 104-QUAD-8 base addresses");
>  
>  /**
>   * struct quad8 - device private data structure
> + * @lock:		lock to prevent clobbering device states during R/W ops
>   * @counter:		instance of the counter_device
>   * @fck_prescaler:	array of filter clock prescaler configurations
>   * @preset:		array of preset values


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-09 19:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 12:37 [PATCH v15 00/13] Introduce the Counter character device interface William Breathitt Gray
2021-08-09 12:37 ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 01/13] counter: 104-quad-8: Describe member 'lock' in 'quad8' William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 19:26   ` Jonathan Cameron [this message]
2021-08-09 19:26     ` Jonathan Cameron
2021-08-09 12:37 ` [PATCH v15 02/13] counter: Internalize sysfs interface code William Breathitt Gray
2021-08-15 16:31   ` Jonathan Cameron
2021-08-15 16:31     ` Jonathan Cameron
2021-08-09 12:37 ` [PATCH v15 03/13] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 04/13] docs: counter: Update " William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 05/13] counter: Move counter enums to uapi header William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 06/13] counter: Add character device interface William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 07/13] docs: counter: Document " William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-15 16:51   ` Jonathan Cameron
2021-08-15 16:51     ` Jonathan Cameron
2021-08-21 10:52     ` William Breathitt Gray
2021-08-21 10:52       ` William Breathitt Gray
2021-08-22  2:03       ` Akira Yokosawa
2021-08-22  2:03         ` Akira Yokosawa
2021-08-09 12:37 ` [PATCH v15 08/13] tools/counter: Create Counter tools William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 09/13] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-15 16:57   ` Jonathan Cameron
2021-08-15 16:57     ` Jonathan Cameron
2021-08-09 12:37 ` [PATCH v15 10/13] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 11/13] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 12/13] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 12:37 ` [PATCH v15 13/13] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-08-09 12:37   ` William Breathitt Gray
2021-08-09 19:34 ` [PATCH v15 00/13] Introduce the Counter character device interface Jonathan Cameron
2021-08-09 19:34   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809202637.4aac5c81@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=a.fatoum@pengutronix.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@st.com \
    --cc=david@lechnology.com \
    --cc=fabrice.gasnier@st.com \
    --cc=gwendal@chromium.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=kamel.bouhara@bootlin.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=patrick.havelange@essensium.com \
    --cc=syednwaris@gmail.com \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.