From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Roja Rani Yarubandi <rojay@codeaurora.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH v6 1/2] PM / Domains: Add support for 'required-opps' to set default perf state
Date: Tue, 10 Aug 2021 08:13:08 +0530 [thread overview]
Message-ID: <20210810024308.gurvzpbe2bc2bhky@vireshk-i7> (raw)
In-Reply-To: <2afd0fac-ed28-c090-a345-3fd4284b4125@codeaurora.org>
On 09-08-21, 16:38, Rajendra Nayak wrote:
> Sure, I can do that, apart from the error print, the function currently also
> returns a -EINVAL in case of the missing 'required-opps', are we suggesting
> we change that to not return an error also?
No.
> Since this is completely optional in the device node, we would want the function to
> ideally not return error and only do so in case 'required-opps' exists and the
> translation to performance state fails.
Not really. The function should return failure if the property isn't
there, but it shouldn't be EINVAL but ENODEV.
--
viresh
next prev parent reply other threads:[~2021-08-10 2:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 10:58 [PATCH v6 0/2] PM / Domains: Add support for 'required-opps' to set default perf state Rajendra Nayak
2021-08-04 10:58 ` [PATCH v6 1/2] " Rajendra Nayak
2021-08-06 9:32 ` Ulf Hansson
2021-08-09 11:08 ` Rajendra Nayak
2021-08-10 2:43 ` Viresh Kumar [this message]
2021-08-11 10:00 ` Rajendra Nayak
2021-08-11 10:07 ` Viresh Kumar
2021-08-11 10:52 ` Ulf Hansson
2021-08-11 11:19 ` Viresh Kumar
2021-08-09 22:26 ` Dmitry Osipenko
2021-08-09 22:44 ` Dmitry Osipenko
2021-08-09 23:46 ` Dmitry Osipenko
2021-08-10 0:37 ` Dmitry Osipenko
2021-08-11 9:45 ` Rajendra Nayak
2021-08-11 19:48 ` Dmitry Osipenko
2021-08-12 2:28 ` Dmitry Osipenko
2021-08-04 10:58 ` [PATCH v6 2/2] arm64: dts: sc7180: Add required-opps for i2c Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810024308.gurvzpbe2bc2bhky@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=rojay@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.