* [PATCH] drm/i915/gem/ttm: prefer kernel types
@ 2021-08-10 8:41 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2021-08-10 8:41 UTC (permalink / raw)
To: intel-gfx
Cc: dri-devel, jani.nikula, Thomas Hellström, Matthew Auld,
Maarten Lankhorst
Avoid uintXX_t types in the driver.
Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 771eb2963123..ffda88156e32 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
}
static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
- uint32_t page_flags)
+ u32 page_flags)
{
struct ttm_resource_manager *man =
ttm_manager_type(bo->bdev, bo->resource->mem_type);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types
@ 2021-08-10 8:41 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2021-08-10 8:41 UTC (permalink / raw)
To: intel-gfx
Cc: dri-devel, jani.nikula, Thomas Hellström, Matthew Auld,
Maarten Lankhorst
Avoid uintXX_t types in the driver.
Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 771eb2963123..ffda88156e32 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
}
static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
- uint32_t page_flags)
+ u32 page_flags)
{
struct ttm_resource_manager *man =
ttm_manager_type(bo->bdev, bo->resource->mem_type);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types
2021-08-10 8:41 ` [Intel-gfx] " Jani Nikula
(?)
@ 2021-08-10 10:25 ` Daniel Vetter
2021-08-10 11:51 ` Jani Nikula
-1 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2021-08-10 10:25 UTC (permalink / raw)
To: Jani Nikula
Cc: intel-gfx, dri-devel, Thomas Hellström, Matthew Auld,
Maarten Lankhorst
On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote:
> Avoid uintXX_t types in the driver.
>
> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 771eb2963123..ffda88156e32 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
> }
>
> static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
> - uint32_t page_flags)
> + u32 page_flags)
It's for the ttm_device_funcs ops table, I thinhk we should fix it there
and across the board?
Otherwise a bit ocd mismatch :-)
-Daniel
> {
> struct ttm_resource_manager *man =
> ttm_manager_type(bo->bdev, bo->resource->mem_type);
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types
2021-08-10 10:25 ` Daniel Vetter
@ 2021-08-10 11:51 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2021-08-10 11:51 UTC (permalink / raw)
To: Daniel Vetter
Cc: intel-gfx, dri-devel, Thomas Hellström, Matthew Auld,
Maarten Lankhorst
On Tue, 10 Aug 2021, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote:
>> Avoid uintXX_t types in the driver.
>>
>> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> index 771eb2963123..ffda88156e32 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
>> @@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
>> }
>>
>> static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
>> - uint32_t page_flags)
>> + u32 page_flags)
>
> It's for the ttm_device_funcs ops table, I thinhk we should fix it there
> and across the board?
>
> Otherwise a bit ocd mismatch :-)
Well, the above is the only uintXX_t reference in i915.
BR,
Jani.
> -Daniel
>
>> {
>> struct ttm_resource_manager *man =
>> ttm_manager_type(bo->bdev, bo->resource->mem_type);
>> --
>> 2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem/ttm: prefer kernel types
2021-08-10 8:41 ` [Intel-gfx] " Jani Nikula
(?)
(?)
@ 2021-08-10 12:29 ` Patchwork
-1 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2021-08-10 12:29 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4295 bytes --]
== Series Details ==
Series: drm/i915/gem/ttm: prefer kernel types
URL : https://patchwork.freedesktop.org/series/93541/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10464 -> Patchwork_20791
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20791 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20791, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20791:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_20791 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-rkl-guc: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@amdgpu/amd_basic@cs-gfx.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-rkl-guc: NOTRUN -> [SKIP][5] ([i915#3844] / [i915#579])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@i915_pm_rpm@module-reload.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-guc: NOTRUN -> [SKIP][6] ([i915#3301])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- fi-rkl-guc: NOTRUN -> [SKIP][7] ([i915#3291]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-1115g4: [FAIL][8] ([i915#1888]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rps@basic-api:
- fi-rkl-guc: [DMESG-WARN][10] ([i915#3925]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10464/fi-rkl-guc/igt@i915_pm_rps@basic-api.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/fi-rkl-guc/igt@i915_pm_rps@basic-api.html
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3844]: https://gitlab.freedesktop.org/drm/intel/issues/3844
[i915#3925]: https://gitlab.freedesktop.org/drm/intel/issues/3925
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Participating hosts (37 -> 33)
------------------------------
Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 fi-apl-guc
Build changes
-------------
* Linux: CI_DRM_10464 -> Patchwork_20791
CI-20190529: 20190529
CI_DRM_10464: 294a55f328023a4e36f46e5eb6c4859076efd850 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6165: df5d05d742275b049f6f3c852a86c4769966b126 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20791: 5f5e1301423731d5c2deee844b627636e6208b02 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5f5e13014237 drm/i915/gem/ttm: prefer kernel types
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20791/index.html
[-- Attachment #2: Type: text/html, Size: 5173 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-10 12:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 8:41 [PATCH] drm/i915/gem/ttm: prefer kernel types Jani Nikula
2021-08-10 8:41 ` [Intel-gfx] " Jani Nikula
2021-08-10 10:25 ` Daniel Vetter
2021-08-10 11:51 ` Jani Nikula
2021-08-10 12:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.