From: Hannes Reinecke <hare@suse.de> To: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@wdc.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 06/13] nvme-fabrics: decode 'authentication required' connect error Date: Tue, 10 Aug 2021 14:42:23 +0200 [thread overview] Message-ID: <20210810124230.12161-7-hare@suse.de> (raw) In-Reply-To: <20210810124230.12161-1-hare@suse.de> The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index a5469fd9d4c3..1e9900f72e66 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n", -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de> To: Christoph Hellwig <hch@lst.de> Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@wdc.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, linux-nvme@lists.infradead.org, linux-crypto@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCH 06/13] nvme-fabrics: decode 'authentication required' connect error Date: Tue, 10 Aug 2021 14:42:23 +0200 [thread overview] Message-ID: <20210810124230.12161-7-hare@suse.de> (raw) In-Reply-To: <20210810124230.12161-1-hare@suse.de> The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index a5469fd9d4c3..1e9900f72e66 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n", -- 2.29.2 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-08-10 12:43 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-10 12:42 [PATCHv2 00/13] nvme: In-band authentication support Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 01/13] crypto: add crypto_has_shash() Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 02/13] crypto: add crypto_has_kpp() Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 03/13] crypto/ffdhe: Finite Field DH Ephemeral Parameters Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 04/13] lib/base64: RFC4648-compliant base64 encoding Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 19:13 ` Eric Biggers 2021-08-10 19:13 ` Eric Biggers 2021-08-11 5:57 ` Hannes Reinecke 2021-08-11 5:57 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 05/13] nvme: add definitions for NVMe In-Band authentication Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke [this message] 2021-08-10 12:42 ` [PATCH 06/13] nvme-fabrics: decode 'authentication required' connect error Hannes Reinecke 2021-08-10 12:42 ` [PATCH 07/13] nvme: Implement In-Band authentication Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 08/13] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 09/13] nvmet: Parse fabrics commands on all queues Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 10/13] nvmet: Implement basic In-Band Authentication Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 11/13] nvmet-auth: Diffie-Hellman key exchange support Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 12/13] nvmet-auth: expire authentication sessions Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-10 12:42 ` [PATCH 13/13] nvme: add non-standard ECDH and curve25517 algorithms Hannes Reinecke 2021-08-10 12:42 ` Hannes Reinecke 2021-08-12 12:25 ` Christoph Hellwig 2021-08-12 12:25 ` Christoph Hellwig 2021-08-12 12:51 ` Hannes Reinecke 2021-08-12 12:51 ` Hannes Reinecke 2021-08-17 21:21 ` [PATCHv2 00/13] nvme: In-band authentication support Sagi Grimberg 2021-08-17 21:21 ` Sagi Grimberg 2021-08-18 5:44 ` Hannes Reinecke 2021-08-18 5:44 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210810124230.12161-7-hare@suse.de \ --to=hare@suse.de \ --cc=davem@davemloft.net \ --cc=hch@lst.de \ --cc=herbert@gondor.apana.org.au \ --cc=keith.busch@wdc.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.