Re: [PATCH v8] drm/bridge: add it6505 driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3560 bytes --]

Hi allen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc5 next-20210810]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/allen/drm-bridge-add-it6505-driver/20210810-193211
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9a73fa375d58fee5262dd16473c8e7522bdf44de
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/231426fd292ff0e8bdacd89be335c257fc57b6ad
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review allen/drm-bridge-add-it6505-driver/20210810-193211
        git checkout 231426fd292ff0e8bdacd89be335c257fc57b6ad
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/bridge/ite-it6505.c: In function 'it6505_bridge_atomic_enable':
   drivers/gpu/drm/bridge/ite-it6505.c:2906:15: error: implicit declaration of function 'drm_bridge_new_crtc_state'; did you mean 'drm_atomic_get_new_crtc_state'? [-Werror=implicit-function-declaration]
    2906 |  crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
         |               drm_atomic_get_new_crtc_state
>> drivers/gpu/drm/bridge/ite-it6505.c:2906:13: warning: assignment to 'const struct drm_crtc_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    2906 |  crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
         |             ^
   cc1: some warnings being treated as errors


vim +2906 drivers/gpu/drm/bridge/ite-it6505.c

  2888	
  2889	static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
  2890						struct drm_bridge_state *old_state)
  2891	{
  2892		struct it6505 *it6505 = bridge_to_it6505(bridge);
  2893		struct device *dev = &it6505->client->dev;
  2894		struct drm_atomic_state *state = old_state->base.state;
  2895		struct hdmi_avi_infoframe frame;
  2896		const struct drm_crtc_state *crtc_state;
  2897		const struct drm_display_mode *mode;
  2898		struct drm_connector *connector;
  2899		int ret;
  2900	
  2901		DRM_DEV_DEBUG_DRIVER(dev, "start");
  2902	
  2903		connector = drm_atomic_get_new_connector_for_encoder(state,
  2904								     bridge->encoder);
  2905	
> 2906		crtc_state = drm_bridge_new_crtc_state(bridge, old_state);
  2907		mode = &crtc_state->mode;
  2908		ret = drm_hdmi_avi_infoframe_from_display_mode(&frame,
  2909							       connector,
  2910							       mode);
  2911		if (ret)
  2912			dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
  2913	
  2914		it6505_update_video_parameter(it6505, mode);
  2915	
  2916		ret = it6505_send_video_infoframe(it6505, &frame);
  2917	
  2918		if (ret)
  2919			dev_err(dev, "Failed to send AVI infoframe: %d", ret);
  2920	
  2921		it6505_int_mask_enable(it6505);
  2922		it6505_video_reset(it6505);
  2923	}
  2924	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65587 bytes --]