From: Hsin-Yi Wang <hsinyi@chromium.org>
To: allen <allen.chen@ite.com.tw>
Cc: Hsin-Yi Wang <hsinyi@google.com>,
Kenneth Hung <Kenneth.Hung@ite.com.tw>,
Hermes Wu <Hermes.Wu@ite.com.tw>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8] drm/bridge: add it6505 driver
Date: Tue, 10 Aug 2021 19:38:30 +0800 [thread overview]
Message-ID: <CAJMQK-g9=7o750t4ZAyND7nqrRvx=tMqUs+-=1--M1CqGXvAdw@mail.gmail.com> (raw)
In-Reply-To: <20210810111124.247838-1-allen.chen@ite.com.tw>
On Tue, Aug 10, 2021 at 7:31 PM allen <allen.chen@ite.com.tw> wrote:
>
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen <allen.chen@ite.com.tw>
> Tested-by: Hsin-yi Wang <hsinyi@chromium.org>
> Signed-off-by: Hermes Wu <hermes.wu@ite.com.tw>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
--- <-- Add this line next time.
Add the change logs below this line so that they're not mixed with
commit messages.
> v7->v8:
> fixed "checkpatch --strict" error
> remove unused variable *edid
> remove mode_set() callback
> Documenting the individual bits of the interrupt mask values
> change it6505_dpcd_write parameter from unsigned long to u8
>
> This patch depends on https://patchwork.kernel.org/project/linux-mediatek/patch/20210722062246.2512666-4-sam@ravnborg.org/
> ---
> drivers/gpu/drm/bridge/Kconfig | 8 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/ite-it6505.c | 3333 +++++++++++++++++++++++++++
> 3 files changed, 3342 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 431b6e12a81fe..e1afe171075f5 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,14 @@ config DRM_DISPLAY_CONNECTOR
> on ARM-based platforms. Saying Y here when this driver is not needed
> will not cause any issue.
>
<snip>
> +
> + /* Register aux channel */
> + it6505->aux.name = "DP-AUX";
> + it6505->aux.dev = dev;
> + it6505->aux.transfer = it6505_aux_transfer;
> +
> + err = drm_dp_aux_register(&it6505->aux);
drm_dp_aux_register() checks if aux->drm_dev is null. Assign this
otherwise you'll see warnings.
> + if (err < 0) {
> + dev_err(dev, "Failed to register aux: %d", err);
> + return err;
> + }
<snip>
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: allen <allen.chen@ite.com.tw>
Cc: Hsin-Yi Wang <hsinyi@google.com>,
Kenneth Hung <Kenneth.Hung@ite.com.tw>,
Hermes Wu <Hermes.Wu@ite.com.tw>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8] drm/bridge: add it6505 driver
Date: Tue, 10 Aug 2021 19:38:30 +0800 [thread overview]
Message-ID: <CAJMQK-g9=7o750t4ZAyND7nqrRvx=tMqUs+-=1--M1CqGXvAdw@mail.gmail.com> (raw)
In-Reply-To: <20210810111124.247838-1-allen.chen@ite.com.tw>
On Tue, Aug 10, 2021 at 7:31 PM allen <allen.chen@ite.com.tw> wrote:
>
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen <allen.chen@ite.com.tw>
> Tested-by: Hsin-yi Wang <hsinyi@chromium.org>
> Signed-off-by: Hermes Wu <hermes.wu@ite.com.tw>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
--- <-- Add this line next time.
Add the change logs below this line so that they're not mixed with
commit messages.
> v7->v8:
> fixed "checkpatch --strict" error
> remove unused variable *edid
> remove mode_set() callback
> Documenting the individual bits of the interrupt mask values
> change it6505_dpcd_write parameter from unsigned long to u8
>
> This patch depends on https://patchwork.kernel.org/project/linux-mediatek/patch/20210722062246.2512666-4-sam@ravnborg.org/
> ---
> drivers/gpu/drm/bridge/Kconfig | 8 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/ite-it6505.c | 3333 +++++++++++++++++++++++++++
> 3 files changed, 3342 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 431b6e12a81fe..e1afe171075f5 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,14 @@ config DRM_DISPLAY_CONNECTOR
> on ARM-based platforms. Saying Y here when this driver is not needed
> will not cause any issue.
>
<snip>
> +
> + /* Register aux channel */
> + it6505->aux.name = "DP-AUX";
> + it6505->aux.dev = dev;
> + it6505->aux.transfer = it6505_aux_transfer;
> +
> + err = drm_dp_aux_register(&it6505->aux);
drm_dp_aux_register() checks if aux->drm_dev is null. Assign this
otherwise you'll see warnings.
> + if (err < 0) {
> + dev_err(dev, "Failed to register aux: %d", err);
> + return err;
> + }
<snip>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: allen <allen.chen@ite.com.tw>
Cc: Hsin-Yi Wang <hsinyi@google.com>,
Kenneth Hung <Kenneth.Hung@ite.com.tw>,
Hermes Wu <Hermes.Wu@ite.com.tw>,
Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8] drm/bridge: add it6505 driver
Date: Tue, 10 Aug 2021 19:38:30 +0800 [thread overview]
Message-ID: <CAJMQK-g9=7o750t4ZAyND7nqrRvx=tMqUs+-=1--M1CqGXvAdw@mail.gmail.com> (raw)
In-Reply-To: <20210810111124.247838-1-allen.chen@ite.com.tw>
On Tue, Aug 10, 2021 at 7:31 PM allen <allen.chen@ite.com.tw> wrote:
>
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen <allen.chen@ite.com.tw>
> Tested-by: Hsin-yi Wang <hsinyi@chromium.org>
> Signed-off-by: Hermes Wu <hermes.wu@ite.com.tw>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
--- <-- Add this line next time.
Add the change logs below this line so that they're not mixed with
commit messages.
> v7->v8:
> fixed "checkpatch --strict" error
> remove unused variable *edid
> remove mode_set() callback
> Documenting the individual bits of the interrupt mask values
> change it6505_dpcd_write parameter from unsigned long to u8
>
> This patch depends on https://patchwork.kernel.org/project/linux-mediatek/patch/20210722062246.2512666-4-sam@ravnborg.org/
> ---
> drivers/gpu/drm/bridge/Kconfig | 8 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/ite-it6505.c | 3333 +++++++++++++++++++++++++++
> 3 files changed, 3342 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 431b6e12a81fe..e1afe171075f5 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,14 @@ config DRM_DISPLAY_CONNECTOR
> on ARM-based platforms. Saying Y here when this driver is not needed
> will not cause any issue.
>
<snip>
> +
> + /* Register aux channel */
> + it6505->aux.name = "DP-AUX";
> + it6505->aux.dev = dev;
> + it6505->aux.transfer = it6505_aux_transfer;
> +
> + err = drm_dp_aux_register(&it6505->aux);
drm_dp_aux_register() checks if aux->drm_dev is null. Assign this
otherwise you'll see warnings.
> + if (err < 0) {
> + dev_err(dev, "Failed to register aux: %d", err);
> + return err;
> + }
<snip>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-10 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 11:11 [PATCH v8] drm/bridge: add it6505 driver allen
2021-08-10 11:11 ` allen
2021-08-10 11:11 ` allen
2021-08-10 11:11 ` allen
2021-08-10 11:38 ` Hsin-Yi Wang [this message]
2021-08-10 11:38 ` Hsin-Yi Wang
2021-08-10 11:38 ` Hsin-Yi Wang
2021-08-10 11:38 ` Hsin-Yi Wang
2021-08-10 14:56 ` kernel test robot
2021-10-06 3:53 ` allen.chen
2021-10-06 3:53 ` allen.chen
2021-10-06 3:53 ` allen.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMQK-g9=7o750t4ZAyND7nqrRvx=tMqUs+-=1--M1CqGXvAdw@mail.gmail.com' \
--to=hsinyi@chromium.org \
--cc=Hermes.Wu@ite.com.tw \
--cc=Jau-Chih.Tseng@ite.com.tw \
--cc=Kenneth.Hung@ite.com.tw \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=allen.chen@ite.com.tw \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.