All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: zhengxunli@mxic.com.tw
Cc: linux-spi@vger.kernel.org
Subject: [bug report] spi: mxic: patch for octal DTR mode support
Date: Wed, 11 Aug 2021 11:00:11 +0300	[thread overview]
Message-ID: <20210811080011.GA14773@kili> (raw)

Hello Zhengxun Li,

The patch d05aaa66ba3c: "spi: mxic: patch for octal DTR mode support"
from Aug 4, 2021, leads to the following
Smatch static checker warning:

	drivers/spi/spi-mxic.c:403 mxic_spi_mem_exec_op()
	warn: curly braces intended?

drivers/spi/spi-mxic.c
    390 	if (op->addr.nbytes)
    391 		ss_ctrl |= OP_ADDR_BYTES(op->addr.nbytes) |
    392 			   OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) |
    393 			   (op->addr.dtr ? OP_ADDR_DDR : 0);
    394 
    395 	if (op->dummy.nbytes)
    396 		ss_ctrl |= OP_DUMMY_CYC(op->dummy.nbytes);
    397 
    398 	if (op->data.nbytes) {
    399 		ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) |
    400 			   (op->data.dtr ? OP_DATA_DDR : 0);
    401 		if (op->data.dir == SPI_MEM_DATA_IN)
    402 			ss_ctrl |= OP_READ;
--> 403 			if (op->data.dtr)
    404 				ss_ctrl |= OP_DQS_EN;

Probably you recieved or are about to recieve a bunc of static checker
warnings about curly braces or indenting here.  It's hard to know what
was intended.

    405 	}
    406 
    407 	writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select));
    408 

regards,
dan carpenter

             reply	other threads:[~2021-08-11  8:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  8:00 Dan Carpenter [this message]
2021-08-11  8:47 ` [bug report] spi: mxic: patch for octal DTR mode support zhengxunli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811080011.GA14773@kili \
    --to=dan.carpenter@oracle.com \
    --cc=linux-spi@vger.kernel.org \
    --cc=zhengxunli@mxic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.