From: zhengxunli@mxic.com.tw
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: linux-spi@vger.kernel.org
Subject: Re: [bug report] spi: mxic: patch for octal DTR mode support
Date: Wed, 11 Aug 2021 16:47:10 +0800 [thread overview]
Message-ID: <OF61F65626.279A7E5D-ON4825872E.002F8099-4825872E.00304386@mxic.com.tw> (raw)
In-Reply-To: <20210811080011.GA14773@kili>
Hi Dan,
Thanks for your reply.
The "spi: mxic: add missing braces" fixed this issue.
"Dan Carpenter" <dan.carpenter@oracle.com> wrote on 2021/08/11 下午
04:00:11:
> "Dan Carpenter" <dan.carpenter@oracle.com>
> 2021/08/11 下午 04:00
>
> To
>
> zhengxunli@mxic.com.tw,
>
> cc
>
> linux-spi@vger.kernel.org
>
> Subject
>
> [bug report] spi: mxic: patch for octal DTR mode support
>
> Hello Zhengxun Li,
>
> The patch d05aaa66ba3c: "spi: mxic: patch for octal DTR mode support"
> from Aug 4, 2021, leads to the following
> Smatch static checker warning:
>
> drivers/spi/spi-mxic.c:403 mxic_spi_mem_exec_op()
> warn: curly braces intended?
>
> drivers/spi/spi-mxic.c
> 390 if (op->addr.nbytes)
> 391 ss_ctrl |= OP_ADDR_BYTES(op->addr.nbytes) |
> 392 OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) |
> 393 (op->addr.dtr ? OP_ADDR_DDR : 0);
> 394
> 395 if (op->dummy.nbytes)
> 396 ss_ctrl |= OP_DUMMY_CYC(op->dummy.nbytes);
> 397
> 398 if (op->data.nbytes) {
> 399 ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) |
> 400 (op->data.dtr ? OP_DATA_DDR : 0);
> 401 if (op->data.dir == SPI_MEM_DATA_IN)
> 402 ss_ctrl |= OP_READ;
> --> 403 if (op->data.dtr)
> 404 ss_ctrl |= OP_DQS_EN;
>
> Probably you recieved or are about to recieve a bunc of static checker
> warnings about curly braces or indenting here. It's hard to know what
> was intended.
>
> 405 }
> 406
> 407 writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select));
> 408
>
> regards,
> dan carpenter
Thanks,
Zhengxun
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
prev parent reply other threads:[~2021-08-11 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:00 [bug report] spi: mxic: patch for octal DTR mode support Dan Carpenter
2021-08-11 8:47 ` zhengxunli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF61F65626.279A7E5D-ON4825872E.002F8099-4825872E.00304386@mxic.com.tw \
--to=zhengxunli@mxic.com.tw \
--cc=dan.carpenter@oracle.com \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.