* [PATCH bpf-next] selftests/bpf: Fix running of XDP bonding tests
@ 2021-08-11 12:36 Jussi Maki
2021-08-11 14:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jussi Maki @ 2021-08-11 12:36 UTC (permalink / raw)
To: bpf; +Cc: daniel, Jussi Maki
An "innocent" cleanup in the last version of the XDP bonding
patchset moved the "test__start_subtest" calls to the test
main function, but I forgot to reverse the condition, which
lead to all tests being skipped. Fix it.
Signed-off-by: Jussi Maki <joamaki@gmail.com>
---
tools/testing/selftests/bpf/prog_tests/xdp_bonding.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c b/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c
index 6b186b4238d0..370d220288a6 100644
--- a/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c
+++ b/tools/testing/selftests/bpf/prog_tests/xdp_bonding.c
@@ -493,20 +493,20 @@ void test_xdp_bonding(void)
"xdp_redirect_multi_kern__open_and_load"))
goto out;
- if (!test__start_subtest("xdp_bonding_attach"))
+ if (test__start_subtest("xdp_bonding_attach"))
test_xdp_bonding_attach(&skeletons);
for (i = 0; i < ARRAY_SIZE(bond_test_cases); i++) {
struct bond_test_case *test_case = &bond_test_cases[i];
- if (!test__start_subtest(test_case->name))
+ if (test__start_subtest(test_case->name))
test_xdp_bonding_with_mode(
&skeletons,
test_case->mode,
test_case->xmit_policy);
}
- if (!test__start_subtest("xdp_bonding_redirect_multi"))
+ if (test__start_subtest("xdp_bonding_redirect_multi"))
test_xdp_bonding_redirect_multi(&skeletons);
out:
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] selftests/bpf: Fix running of XDP bonding tests
2021-08-11 12:36 [PATCH bpf-next] selftests/bpf: Fix running of XDP bonding tests Jussi Maki
@ 2021-08-11 14:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-11 14:20 UTC (permalink / raw)
To: Jussi Maki; +Cc: bpf, daniel
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 11 Aug 2021 12:36:27 +0000 you wrote:
> An "innocent" cleanup in the last version of the XDP bonding
> patchset moved the "test__start_subtest" calls to the test
> main function, but I forgot to reverse the condition, which
> lead to all tests being skipped. Fix it.
>
> Signed-off-by: Jussi Maki <joamaki@gmail.com>
>
> [...]
Here is the summary with links:
- [bpf-next] selftests/bpf: Fix running of XDP bonding tests
https://git.kernel.org/bpf/bpf-next/c/25dc3895baaa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-11 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 12:36 [PATCH bpf-next] selftests/bpf: Fix running of XDP bonding tests Jussi Maki
2021-08-11 14:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.