* [Buildroot] [PATCH 1/1] package/dbus-python: drop python2 dependency
@ 2021-08-11 16:00 Illia Bitkov
2021-08-13 13:11 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Illia Bitkov @ 2021-08-11 16:00 UTC (permalink / raw)
To: buildroot; +Cc: Illia Bitkov
Changes due to plans to depricate python2
Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
---
package/dbus-python/Config.in | 7 +++----
package/dbus-python/dbus-python.mk | 16 ----------------
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/package/dbus-python/Config.in b/package/dbus-python/Config.in
index 4bfb59ed91..ba77602058 100644
--- a/package/dbus-python/Config.in
+++ b/package/dbus-python/Config.in
@@ -3,16 +3,15 @@ config BR2_PACKAGE_DBUS_PYTHON
depends on BR2_USE_WCHAR # glib2
depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
depends on BR2_PACKAGE_DBUS
- depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+ depends on BR2_PACKAGE_PYTHON3
select BR2_PACKAGE_LIBGLIB2
# pyexpat: runtime dependency only
- select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
- select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+ select BR2_PACKAGE_PYTHON3_PYEXPAT
help
Python bindings for D-Bus
http://dbus.freedesktop.org/doc/dbus-python/
comment "dbus-python needs a toolchain w/ wchar, threads"
- depends on BR2_PACKAGE_DBUS && (BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3)
+ depends on BR2_PACKAGE_DBUS && BR2_PACKAGE_PYTHON3
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
index f4b8996d76..9528e08d66 100644
--- a/package/dbus-python/dbus-python.mk
+++ b/package/dbus-python/dbus-python.mk
@@ -12,21 +12,6 @@ DBUS_PYTHON_LICENSE_FILES = COPYING dbus-gmain/COPYING
DBUS_PYTHON_DEPENDENCIES = dbus libglib2
HOST_DBUS_PYTHON_DEPENDENCIES = host-dbus host-libglib2
-ifeq ($(BR2_PACKAGE_PYTHON),y)
-DBUS_PYTHON_DEPENDENCIES += python host-python
-
-DBUS_PYTHON_CONF_ENV += \
- PYTHON=$(HOST_DIR)/bin/python2 \
- PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python2-config --includes`" \
- PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python2-config --ldflags`"
-
-HOST_DBUS_PYTHON_DEPENDENCIES += host-python
-
-HOST_DBUS_PYTHON_CONF_ENV += \
- PYTHON=$(HOST_DIR)/bin/python2 \
- PYTHON_INCLUDES="`$(HOST_DIR)/usr/bin/python2-config --includes`" \
- PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python2-config --ldflags`"
-else
DBUS_PYTHON_DEPENDENCIES += python3 host-python3
DBUS_PYTHON_CONF_ENV += \
@@ -42,7 +27,6 @@ HOST_DBUS_PYTHON_CONF_ENV += \
PYTHON_INCLUDES="`$(HOST_DIR)/usr/bin/python3-config --includes`" \
PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python3-config --ldflags`" \
PYTHON_EXTRA_LIBS="`$(HOST_DIR)/usr/bin/python3-config --libs --embed`"
-endif
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dbus-python: drop python2 dependency
2021-08-11 16:00 [Buildroot] [PATCH 1/1] package/dbus-python: drop python2 dependency Illia Bitkov
@ 2021-08-13 13:11 ` Thomas Petazzoni
2021-08-13 14:02 ` Illia Bitkov
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-08-13 13:11 UTC (permalink / raw)
To: Illia Bitkov; +Cc: buildroot
On Wed, 11 Aug 2021 18:00:55 +0200
Illia Bitkov <illia.bitkov@mind.be> wrote:
> Changes due to plans to depricate python2
>
> Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
Could you explain a bit more why you are doing this? Is it because
dbus-python is no longer compatible with Python 2.x ? Or you're doing
this as part of the process of getting rid of Python 2.x support in
Buildroot entirely ?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dbus-python: drop python2 dependency
2021-08-13 13:11 ` Thomas Petazzoni
@ 2021-08-13 14:02 ` Illia Bitkov
0 siblings, 0 replies; 3+ messages in thread
From: Illia Bitkov @ 2021-08-13 14:02 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
Hello Thomas, All
Seems that I've put this patch here by error.
Yes, the idea to get rid of python2.x.
But anyway I think this patch shouldn't be merged
On Fri, Aug 13, 2021 at 3:11 PM Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:
> On Wed, 11 Aug 2021 18:00:55 +0200
> Illia Bitkov <illia.bitkov@mind.be> wrote:
>
> > Changes due to plans to depricate python2
> >
> > Signed-off-by: Illia Bitkov <illia.bitkov@mind.be>
>
> Could you explain a bit more why you are doing this? Is it because
> dbus-python is no longer compatible with Python 2.x ? Or you're doing
> this as part of the process of getting rid of Python 2.x support in
> Buildroot entirely ?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
[-- Attachment #1.2: Type: text/html, Size: 1473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 145 bytes --]
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-13 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 16:00 [Buildroot] [PATCH 1/1] package/dbus-python: drop python2 dependency Illia Bitkov
2021-08-13 13:11 ` Thomas Petazzoni
2021-08-13 14:02 ` Illia Bitkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.