[PATCH 1/2] Documentation/process/applying-patches: Activate linux-next man hyperlink

[PATCH 1/2] Documentation/process/applying-patches: Activate linux-next man hyperlink

[SeongJae Park]

From: SeongJae Park <sjpark@amazon.de>

There is a url for linux-next in the 'applying-patches.rst', but it's
surrounded by backquotes.  So the url doesn't have a hyperlink in the
built document.  To let readers easily move to the page, this commit
puts the url outside of the backquotes so that a hyperlink to the url
can be automatically made.

Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
 Documentation/process/applying-patches.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
index 2e7017bef4b8..c2121c1e55d7 100644
--- a/Documentation/process/applying-patches.rst
+++ b/Documentation/process/applying-patches.rst
@@ -389,7 +389,7 @@ The -mm patches are experimental patches released by Andrew Morton.
 
 In the past, -mm tree were used to also test subsystem patches, but this
 function is now done via the
-`linux-next <https://www.kernel.org/doc/man-pages/linux-next.html>`
+`linux-next` (https://www.kernel.org/doc/man-pages/linux-next.html)
 tree. The Subsystem maintainers push their patches first to linux-next,
 and, during the merge window, sends them directly to Linus.
 
-- 
2.17.1

[PATCH 2/2] Documentation/process/maintainer-pgp-guide: Replace broken link to PGP path finder

[SeongJae Park]

From: SeongJae Park <sjpark@amazon.de>

PGP pathfinder[1], which is suggested for finding a trust path to
unknown PGP keys by 'maintainer-pgp-guide.rst', is not working now.
This commit replaces it with other available tools.

[1] https://pgp.cs.uu.nl/

Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
 Documentation/process/maintainer-pgp-guide.rst | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
index 8f8f1fee92b8..29e7d7b1cd44 100644
--- a/Documentation/process/maintainer-pgp-guide.rst
+++ b/Documentation/process/maintainer-pgp-guide.rst
@@ -944,12 +944,11 @@ have on your keyring::
     uid           [ unknown] Linus Torvalds <torvalds@kernel.org>
     sub   rsa2048 2011-09-20 [E]
 
-Next, open the `PGP pathfinder`_. In the "From" field, paste the key
-fingerprint of Linus Torvalds from the output above. In the "To" field,
-paste the key-id you found via ``gpg --search`` of the unknown key, and
-check the results:
-
-- `Finding paths to Linus`_
+Next, find a trust path from Linus Torvalds to the key-id you found via ``gpg
+--search`` of the unknown key.  For this, you can use several tools including
+https://github.com/mricon/wotmate,
+https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git/tree/graphs, and
+https://the.earth.li/~noodles/pathfind.html.
 
 If you get a few decent trust paths, then it's a pretty good indication
 that it is a valid key. You can add it to your keyring from the
@@ -962,6 +961,3 @@ administrators of the PGP Pathfinder service to not be malicious (in
 fact, this goes against :ref:`devs_not_infra`). However, if you
 do not carefully maintain your own web of trust, then it is a marked
 improvement over blindly trusting keyservers.
-
-.. _`PGP pathfinder`: https://pgp.cs.uu.nl/
-.. _`Finding paths to Linus`: https://pgp.cs.uu.nl/paths/79BE3E4300411886/to/C94035C21B4F2AEB.html
-- 
2.17.1

Re: [PATCH 1/2] Documentation/process/applying-patches: Activate linux-next man hyperlink

[SeongJae Park]

From: SeongJae Park <sjpark@amazon.de>

Hello Jon,


I'm wondering if you had a chance to review this patchset.  Could you please
give me some comments?


Thanks,
SJ

On Thu, 12 Aug 2021 09:50:29 +0000 SeongJae Park <sj38.park@gmail.com> wrote:

> From: SeongJae Park <sjpark@amazon.de>
> 
> There is a url for linux-next in the 'applying-patches.rst', but it's
> surrounded by backquotes.  So the url doesn't have a hyperlink in the
> built document.  To let readers easily move to the page, this commit
> puts the url outside of the backquotes so that a hyperlink to the url
> can be automatically made.
> 
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  Documentation/process/applying-patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
> index 2e7017bef4b8..c2121c1e55d7 100644
> --- a/Documentation/process/applying-patches.rst
> +++ b/Documentation/process/applying-patches.rst
> @@ -389,7 +389,7 @@ The -mm patches are experimental patches released by Andrew Morton.
>  
>  In the past, -mm tree were used to also test subsystem patches, but this
>  function is now done via the
> -`linux-next <https://www.kernel.org/doc/man-pages/linux-next.html>`
> +`linux-next` (https://www.kernel.org/doc/man-pages/linux-next.html)
>  tree. The Subsystem maintainers push their patches first to linux-next,
>  and, during the merge window, sends them directly to Linus.
>  
> -- 
> 2.17.1

Re: [PATCH 1/2] Documentation/process/applying-patches: Activate linux-next man hyperlink

[Jonathan Corbet]

SeongJae Park <sj38.park@gmail.com> writes:

> From: SeongJae Park <sjpark@amazon.de>
>
> There is a url for linux-next in the 'applying-patches.rst', but it's
> surrounded by backquotes.  So the url doesn't have a hyperlink in the
> built document.  To let readers easily move to the page, this commit
> puts the url outside of the backquotes so that a hyperlink to the url
> can be automatically made.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  Documentation/process/applying-patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
> index 2e7017bef4b8..c2121c1e55d7 100644
> --- a/Documentation/process/applying-patches.rst
> +++ b/Documentation/process/applying-patches.rst
> @@ -389,7 +389,7 @@ The -mm patches are experimental patches released by Andrew Morton.
>  
>  In the past, -mm tree were used to also test subsystem patches, but this
>  function is now done via the
> -`linux-next <https://www.kernel.org/doc/man-pages/linux-next.html>`
> +`linux-next` (https://www.kernel.org/doc/man-pages/linux-next.html)
>  tree. The Subsystem maintainers push their patches first to linux-next,
>  and, during the merge window, sends them directly to Linus.

Applied, thanks.

jon

Re: [PATCH 2/2] Documentation/process/maintainer-pgp-guide: Replace broken link to PGP path finder

[Jonathan Corbet]

SeongJae Park <sj38.park@gmail.com> writes:

> From: SeongJae Park <sjpark@amazon.de>
>
> PGP pathfinder[1], which is suggested for finding a trust path to
> unknown PGP keys by 'maintainer-pgp-guide.rst', is not working now.
> This commit replaces it with other available tools.
>
> [1] https://pgp.cs.uu.nl/

This looks fine to me, but I'd like Konstantin [CC'd] to have a look and
let me know if he agrees...

Thanks,

jon

> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  Documentation/process/maintainer-pgp-guide.rst | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/process/maintainer-pgp-guide.rst b/Documentation/process/maintainer-pgp-guide.rst
> index 8f8f1fee92b8..29e7d7b1cd44 100644
> --- a/Documentation/process/maintainer-pgp-guide.rst
> +++ b/Documentation/process/maintainer-pgp-guide.rst
> @@ -944,12 +944,11 @@ have on your keyring::
>      uid           [ unknown] Linus Torvalds <torvalds@kernel.org>
>      sub   rsa2048 2011-09-20 [E]
>  
> -Next, open the `PGP pathfinder`_. In the "From" field, paste the key
> -fingerprint of Linus Torvalds from the output above. In the "To" field,
> -paste the key-id you found via ``gpg --search`` of the unknown key, and
> -check the results:
> -
> -- `Finding paths to Linus`_
> +Next, find a trust path from Linus Torvalds to the key-id you found via ``gpg
> +--search`` of the unknown key.  For this, you can use several tools including
> +https://github.com/mricon/wotmate,
> +https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git/tree/graphs, and
> +https://the.earth.li/~noodles/pathfind.html.
>  
>  If you get a few decent trust paths, then it's a pretty good indication
>  that it is a valid key. You can add it to your keyring from the
> @@ -962,6 +961,3 @@ administrators of the PGP Pathfinder service to not be malicious (in
>  fact, this goes against :ref:`devs_not_infra`). However, if you
>  do not carefully maintain your own web of trust, then it is a marked
>  improvement over blindly trusting keyservers.
> -
> -.. _`PGP pathfinder`: https://pgp.cs.uu.nl/
> -.. _`Finding paths to Linus`: https://pgp.cs.uu.nl/paths/79BE3E4300411886/to/C94035C21B4F2AEB.html
> -- 
> 2.17.1

Re: [PATCH 2/2] Documentation/process/maintainer-pgp-guide: Replace broken link to PGP path finder

[Konstantin Ryabitsev]

On Fri, Aug 20, 2021 at 11:12:09AM -0600, Jonathan Corbet wrote:
> This looks fine to me, but I'd like Konstantin [CC'd] to have a look and
> let me know if he agrees...

Yes, this looks good to me. The entire section needs a more in-depth rewrite,
but I'm not ready for that work yet, and this patch at least removes a dead
link and offers some alternatives.

Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

Thank you!
-K


> > -Next, open the `PGP pathfinder`_. In the "From" field, paste the key
> > -fingerprint of Linus Torvalds from the output above. In the "To" field,
> > -paste the key-id you found via ``gpg --search`` of the unknown key, and
> > -check the results:
> > -
> > -- `Finding paths to Linus`_
> > +Next, find a trust path from Linus Torvalds to the key-id you found via ``gpg
> > +--search`` of the unknown key.  For this, you can use several tools including
> > +https://github.com/mricon/wotmate,
> > +https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git/tree/graphs, and
> > +https://the.earth.li/~noodles/pathfind.html.
> >  
> >  If you get a few decent trust paths, then it's a pretty good indication
> >  that it is a valid key. You can add it to your keyring from the
> > @@ -962,6 +961,3 @@ administrators of the PGP Pathfinder service to not be malicious (in
> >  fact, this goes against :ref:`devs_not_infra`). However, if you
> >  do not carefully maintain your own web of trust, then it is a marked
> >  improvement over blindly trusting keyservers.
> > -
> > -.. _`PGP pathfinder`: https://pgp.cs.uu.nl/
> > -.. _`Finding paths to Linus`: https://pgp.cs.uu.nl/paths/79BE3E4300411886/to/C94035C21B4F2AEB.html

Re: [PATCH 2/2] Documentation/process/maintainer-pgp-guide: Replace broken link to PGP path finder

[Jonathan Corbet]

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> On Fri, Aug 20, 2021 at 11:12:09AM -0600, Jonathan Corbet wrote:
>> This looks fine to me, but I'd like Konstantin [CC'd] to have a look and
>> let me know if he agrees...
>
> Yes, this looks good to me. The entire section needs a more in-depth rewrite,
> but I'm not ready for that work yet, and this patch at least removes a dead
> link and offers some alternatives.
>
> Reviewed-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

Thanks for having a look - patch applied.

jon