From: "Paul E. McKenney" <paulmck@kernel.org> To: Valentin Schneider <valentin.schneider@arm.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org, linux-rt-users@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Steven Rostedt <rostedt@goodmis.org>, Daniel Bristot de Oliveira <bristot@redhat.com>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Frederic Weisbecker <frederic@kernel.org>, Josh Triplett <josh@joshtriplett.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Davidlohr Bueso <dave@stgolabs.net>, Lai Jiangshan <jiangshanlai@gmail.com>, Joel Fernandes <joel@joelfernandes.org>, Anshuman Khandual <anshuman.khandual@arm.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Steven Price <steven.price@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Boqun Feng <boqun.feng@gmail.com>, Mike Galbraith <efault@gmx.de> Subject: Re: [PATCH v3 1/4] rcutorture: Don't disable softirqs with preemption disabled when PREEMPT_RT Date: Thu, 12 Aug 2021 09:47:30 -0700 [thread overview] Message-ID: <20210812164730.GX4126399@paulmck-ThinkPad-P17-Gen-1> (raw) In-Reply-To: <20210811201354.1976839-2-valentin.schneider@arm.com> On Wed, Aug 11, 2021 at 09:13:51PM +0100, Valentin Schneider wrote: > Running RCU torture with CONFIG_PREEMPT_RT under v5.14-rc4-rt6 triggers: > > [ 8.755472] DEBUG_LOCKS_WARN_ON(this_cpu_read(softirq_ctrl.cnt)) > [ 8.755482] WARNING: CPU: 1 PID: 137 at kernel/softirq.c:172 __local_bh_disable_ip (kernel/softirq.c:172 (discriminator 31)) > [ 8.755500] Modules linked in: > [ 8.755506] CPU: 1 PID: 137 Comm: rcu_torture_rea Not tainted 5.14.0-rc4-rt6 #171 > [ 8.755514] Hardware name: ARM Juno development board (r0) (DT) > [ 8.755518] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--) > [ 8.755622] Call trace: > [ 8.755624] __local_bh_disable_ip (kernel/softirq.c:172 (discriminator 31)) > [ 8.755633] rcutorture_one_extend (kernel/rcu/rcutorture.c:1453) > [ 8.755640] rcu_torture_one_read (kernel/rcu/rcutorture.c:1601 kernel/rcu/rcutorture.c:1645) > [ 8.755645] rcu_torture_reader (kernel/rcu/rcutorture.c:1737) > [ 8.755650] kthread (kernel/kthread.c:327) > [ 8.755656] ret_from_fork (arch/arm64/kernel/entry.S:783) > [ 8.755663] irq event stamp: 11959 > [ 8.755666] hardirqs last enabled at (11959): __rcu_read_unlock (kernel/rcu/tree_plugin.h:695 kernel/rcu/tree_plugin.h:451) > [ 8.755675] hardirqs last disabled at (11958): __rcu_read_unlock (kernel/rcu/tree_plugin.h:661 kernel/rcu/tree_plugin.h:451) > [ 8.755683] softirqs last enabled at (11950): __local_bh_enable_ip (./arch/arm64/include/asm/irqflags.h:85 kernel/softirq.c:261) > [ 8.755692] softirqs last disabled at (11942): rcutorture_one_extend (./include/linux/bottom_half.h:19 kernel/rcu/rcutorture.c:1441) > > Per this warning, softirqs cannot be disabled in a non-preemptible region > under CONFIG_PREEMPT_RT. Adjust RCU torture accordingly. > > Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> Looks sensible for -rt, but of course does not apply on mainline or -rcu. Acked-by: Paul E. McKenney <paulmck@kernel.org> > --- > kernel/rcu/rcutorture.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c > index eecd1caef71d..4f3db1d3170d 100644 > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -1548,6 +1548,8 @@ rcutorture_extend_mask(int oldmask, struct torture_random_state *trsp) > * them on non-RT. > */ > if (IS_ENABLED(CONFIG_PREEMPT_RT)) { > + /* Can't disable bh in atomic context under PREEMPT_RT */ > + mask &= ~(RCUTORTURE_RDR_ATOM_BH | RCUTORTURE_RDR_ATOM_RBH); > /* > * Can't release the outermost rcu lock in an irq disabled > * section without preemption also being disabled, if irqs > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@kernel.org> To: Valentin Schneider <valentin.schneider@arm.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org, linux-rt-users@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Steven Rostedt <rostedt@goodmis.org>, Daniel Bristot de Oliveira <bristot@redhat.com>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Frederic Weisbecker <frederic@kernel.org>, Josh Triplett <josh@joshtriplett.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Davidlohr Bueso <dave@stgolabs.net>, Lai Jiangshan <jiangshanlai@gmail.com>, Joel Fernandes <joel@joelfernandes.org>, Anshuman Khandual <anshuman.khandual@arm.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Steven Price <steven.price@arm.com>, Ard Biesheuvel <ardb@kernel.org>, Boqun Feng <boqun.feng@gmail.com>, Mike Galbraith <efault@gmx.de> Subject: Re: [PATCH v3 1/4] rcutorture: Don't disable softirqs with preemption disabled when PREEMPT_RT Date: Thu, 12 Aug 2021 09:47:30 -0700 [thread overview] Message-ID: <20210812164730.GX4126399@paulmck-ThinkPad-P17-Gen-1> (raw) In-Reply-To: <20210811201354.1976839-2-valentin.schneider@arm.com> On Wed, Aug 11, 2021 at 09:13:51PM +0100, Valentin Schneider wrote: > Running RCU torture with CONFIG_PREEMPT_RT under v5.14-rc4-rt6 triggers: > > [ 8.755472] DEBUG_LOCKS_WARN_ON(this_cpu_read(softirq_ctrl.cnt)) > [ 8.755482] WARNING: CPU: 1 PID: 137 at kernel/softirq.c:172 __local_bh_disable_ip (kernel/softirq.c:172 (discriminator 31)) > [ 8.755500] Modules linked in: > [ 8.755506] CPU: 1 PID: 137 Comm: rcu_torture_rea Not tainted 5.14.0-rc4-rt6 #171 > [ 8.755514] Hardware name: ARM Juno development board (r0) (DT) > [ 8.755518] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--) > [ 8.755622] Call trace: > [ 8.755624] __local_bh_disable_ip (kernel/softirq.c:172 (discriminator 31)) > [ 8.755633] rcutorture_one_extend (kernel/rcu/rcutorture.c:1453) > [ 8.755640] rcu_torture_one_read (kernel/rcu/rcutorture.c:1601 kernel/rcu/rcutorture.c:1645) > [ 8.755645] rcu_torture_reader (kernel/rcu/rcutorture.c:1737) > [ 8.755650] kthread (kernel/kthread.c:327) > [ 8.755656] ret_from_fork (arch/arm64/kernel/entry.S:783) > [ 8.755663] irq event stamp: 11959 > [ 8.755666] hardirqs last enabled at (11959): __rcu_read_unlock (kernel/rcu/tree_plugin.h:695 kernel/rcu/tree_plugin.h:451) > [ 8.755675] hardirqs last disabled at (11958): __rcu_read_unlock (kernel/rcu/tree_plugin.h:661 kernel/rcu/tree_plugin.h:451) > [ 8.755683] softirqs last enabled at (11950): __local_bh_enable_ip (./arch/arm64/include/asm/irqflags.h:85 kernel/softirq.c:261) > [ 8.755692] softirqs last disabled at (11942): rcutorture_one_extend (./include/linux/bottom_half.h:19 kernel/rcu/rcutorture.c:1441) > > Per this warning, softirqs cannot be disabled in a non-preemptible region > under CONFIG_PREEMPT_RT. Adjust RCU torture accordingly. > > Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> Looks sensible for -rt, but of course does not apply on mainline or -rcu. Acked-by: Paul E. McKenney <paulmck@kernel.org> > --- > kernel/rcu/rcutorture.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c > index eecd1caef71d..4f3db1d3170d 100644 > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -1548,6 +1548,8 @@ rcutorture_extend_mask(int oldmask, struct torture_random_state *trsp) > * them on non-RT. > */ > if (IS_ENABLED(CONFIG_PREEMPT_RT)) { > + /* Can't disable bh in atomic context under PREEMPT_RT */ > + mask &= ~(RCUTORTURE_RDR_ATOM_BH | RCUTORTURE_RDR_ATOM_RBH); > /* > * Can't release the outermost rcu lock in an irq disabled > * section without preemption also being disabled, if irqs > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-12 16:47 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 20:13 [PATCH v3 0/4] rcu, arm64: PREEMPT_RT fixlets Valentin Schneider 2021-08-11 20:13 ` Valentin Schneider 2021-08-11 20:13 ` [PATCH v3 1/4] rcutorture: Don't disable softirqs with preemption disabled when PREEMPT_RT Valentin Schneider 2021-08-11 20:13 ` Valentin Schneider 2021-08-12 16:47 ` Paul E. McKenney [this message] 2021-08-12 16:47 ` Paul E. McKenney 2021-08-17 12:13 ` Sebastian Andrzej Siewior 2021-08-17 12:13 ` Sebastian Andrzej Siewior 2021-08-17 13:17 ` Sebastian Andrzej Siewior 2021-08-17 13:17 ` Sebastian Andrzej Siewior 2021-08-17 14:40 ` [PATCH] rcutorture: Avoid problematic critical section nesting on RT Sebastian Andrzej Siewior 2021-08-17 14:40 ` Sebastian Andrzej Siewior 2021-08-18 22:46 ` Paul E. McKenney 2021-08-18 22:46 ` Paul E. McKenney 2021-08-19 15:35 ` Sebastian Andrzej Siewior 2021-08-19 15:35 ` Sebastian Andrzej Siewior 2021-08-19 15:39 ` Sebastian Andrzej Siewior 2021-08-19 15:39 ` Sebastian Andrzej Siewior 2021-08-19 15:47 ` Sebastian Andrzej Siewior 2021-08-19 15:47 ` Sebastian Andrzej Siewior 2021-08-19 18:20 ` Paul E. McKenney 2021-08-19 18:20 ` Paul E. McKenney 2021-08-19 18:45 ` Sebastian Andrzej Siewior 2021-08-19 18:45 ` Sebastian Andrzej Siewior 2021-08-20 4:11 ` Scott Wood 2021-08-20 4:11 ` Scott Wood 2021-08-20 7:11 ` Sebastian Andrzej Siewior 2021-08-20 7:11 ` Sebastian Andrzej Siewior 2021-08-20 7:42 ` [PATCH v2] rcutorture: Avoid problematic critical section nesting on PREEMPT_RT Sebastian Andrzej Siewior 2021-08-20 7:42 ` Sebastian Andrzej Siewior 2021-08-20 22:10 ` Paul E. McKenney 2021-08-20 22:10 ` Paul E. McKenney 2021-08-20 3:23 ` [PATCH] rcutorture: Avoid problematic critical section nesting on RT Scott Wood 2021-08-20 3:23 ` Scott Wood 2021-08-20 6:54 ` Sebastian Andrzej Siewior 2021-08-20 6:54 ` Sebastian Andrzej Siewior 2021-08-11 20:13 ` [PATCH v3 2/4] sched: Introduce migratable() Valentin Schneider 2021-08-11 20:13 ` Valentin Schneider 2021-08-17 14:43 ` Sebastian Andrzej Siewior 2021-08-17 14:43 ` Sebastian Andrzej Siewior 2021-08-22 17:31 ` Valentin Schneider 2021-08-22 17:31 ` Valentin Schneider 2021-08-17 17:09 ` Sebastian Andrzej Siewior 2021-08-17 17:09 ` Sebastian Andrzej Siewior 2021-08-17 19:30 ` Phil Auld 2021-08-17 19:30 ` Phil Auld 2021-08-22 18:14 ` Valentin Schneider 2021-08-22 18:14 ` Valentin Schneider 2022-01-26 16:56 ` Sebastian Andrzej Siewior 2022-01-26 16:56 ` Sebastian Andrzej Siewior 2022-01-26 18:10 ` Valentin Schneider 2022-01-26 18:10 ` Valentin Schneider 2022-01-27 10:07 ` Sebastian Andrzej Siewior 2022-01-27 10:07 ` Sebastian Andrzej Siewior 2022-01-27 18:23 ` Valentin Schneider 2022-01-27 18:23 ` Valentin Schneider 2022-01-27 19:27 ` Valentin Schneider 2022-01-27 19:27 ` Valentin Schneider 2022-02-04 9:24 ` Sebastian Andrzej Siewior 2022-02-04 9:24 ` Sebastian Andrzej Siewior 2021-08-11 20:13 ` [PATCH v3 3/4] rcu/nocb: Protect NOCB state via local_lock() under PREEMPT_RT Valentin Schneider 2021-08-11 20:13 ` Valentin Schneider 2021-08-13 0:20 ` Paul E. McKenney 2021-08-13 0:20 ` Paul E. McKenney 2021-08-13 18:48 ` Valentin Schneider 2021-08-13 18:48 ` Valentin Schneider 2021-08-24 13:00 ` Frederic Weisbecker 2021-08-17 15:36 ` Sebastian Andrzej Siewior 2021-08-17 15:36 ` Sebastian Andrzej Siewior 2021-08-22 18:15 ` Valentin Schneider 2021-08-22 18:15 ` Valentin Schneider 2021-09-21 14:05 ` Thomas Gleixner 2021-09-21 14:05 ` Thomas Gleixner 2021-09-21 21:12 ` rcu/tree: Protect rcu_rdp_is_offloaded() invocations on RT Thomas Gleixner 2021-09-21 23:36 ` Frederic Weisbecker 2021-09-21 23:36 ` Frederic Weisbecker 2021-09-22 2:18 ` Paul E. McKenney 2021-09-22 2:18 ` Paul E. McKenney 2021-09-22 11:31 ` Frederic Weisbecker 2021-09-22 11:31 ` Frederic Weisbecker 2021-09-21 23:45 ` Frederic Weisbecker 2021-09-21 23:45 ` Frederic Weisbecker 2021-09-22 6:32 ` Sebastian Andrzej Siewior 2021-09-22 6:32 ` Sebastian Andrzej Siewior 2021-09-22 11:10 ` Frederic Weisbecker 2021-09-22 11:10 ` Frederic Weisbecker 2021-09-22 11:27 ` Sebastian Andrzej Siewior 2021-09-22 11:27 ` Sebastian Andrzej Siewior 2021-09-22 11:38 ` Frederic Weisbecker 2021-09-22 11:38 ` Frederic Weisbecker 2021-09-22 13:02 ` Sebastian Andrzej Siewior 2021-09-22 13:02 ` Sebastian Andrzej Siewior 2021-09-23 10:02 ` Frederic Weisbecker 2021-09-23 10:02 ` Frederic Weisbecker 2021-09-30 9:00 ` Valentin Schneider 2021-09-30 9:00 ` Valentin Schneider 2021-09-30 10:53 ` Frederic Weisbecker 2021-09-30 10:53 ` Frederic Weisbecker 2021-09-30 13:22 ` Valentin Schneider 2021-09-30 13:22 ` Valentin Schneider 2021-08-11 20:13 ` [PATCH v3 4/4] arm64: mm: Make arch_faults_on_old_pte() check for migratability Valentin Schneider 2021-08-11 20:13 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210812164730.GX4126399@paulmck-ThinkPad-P17-Gen-1 \ --to=paulmck@kernel.org \ --cc=anshuman.khandual@arm.com \ --cc=ardb@kernel.org \ --cc=bigeasy@linutronix.de \ --cc=boqun.feng@gmail.com \ --cc=bristot@redhat.com \ --cc=catalin.marinas@arm.com \ --cc=dave@stgolabs.net \ --cc=efault@gmx.de \ --cc=frederic@kernel.org \ --cc=jiangshanlai@gmail.com \ --cc=joel@joelfernandes.org \ --cc=josh@joshtriplett.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rt-users@vger.kernel.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=rcu@vger.kernel.org \ --cc=rostedt@goodmis.org \ --cc=steven.price@arm.com \ --cc=tglx@linutronix.de \ --cc=valentin.schneider@arm.com \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.