From: kernel test robot <lkp@intel.com> To: JafarAkhondali <jafar.akhoondali@gmail.com>, Hans de Goede <hdegoede@redhat.com>, jlee@suse.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, mgross@linux.intel.com Cc: kbuild-all@lists.01.org, JafarAkhondali <jafar.akhoondali@gmail.com> Subject: Re: [PATCH v5] platform/x86: acer-wmi: Add Turbo Mode support for Acer PH315-53 Date: Fri, 13 Aug 2021 00:43:35 +0800 [thread overview] Message-ID: <202108130011.9S7iFX4u-lkp@intel.com> (raw) In-Reply-To: <20210812125307.1749207-1-jafar.akhoondali@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2632 bytes --] Hi JafarAkhondali, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.14-rc5 next-20210812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1746f4db513563bb22e0ba0c419d0c90912dfae1 config: i386-randconfig-a015-20210812 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/292cfa3c9af2eb61b782c6d94d08d35300318ca3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347 git checkout 292cfa3c9af2eb61b782c6d94d08d35300318ca3 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/platform/x86/acer-wmi.c:1466:6: warning: no previous prototype for 'WMID_gaming_set_fan_mode' [-Wmissing-prototypes] 1466 | void WMID_gaming_set_fan_mode(u8 fan_mode) | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/WMID_gaming_set_fan_mode +1466 drivers/platform/x86/acer-wmi.c 1465 > 1466 void WMID_gaming_set_fan_mode(u8 fan_mode) 1467 { 1468 /* fan_mode = 1 is used for auto, fan_mode = 2 used for turbo*/ 1469 u64 gpu_fan_config1 = 0, gpu_fan_config2 = 0; 1470 int i; 1471 1472 if (quirks->cpu_fans > 0) 1473 gpu_fan_config2 |= 1; 1474 for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i) 1475 gpu_fan_config2 |= 1 << (i + 1); 1476 for (i = 0; i < quirks->gpu_fans; ++i) 1477 gpu_fan_config2 |= 1 << (i + 3); 1478 if (quirks->cpu_fans > 0) 1479 gpu_fan_config1 |= fan_mode; 1480 for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i) 1481 gpu_fan_config1 |= fan_mode << (2 * i + 2); 1482 for (i = 0; i < quirks->gpu_fans; ++i) 1483 gpu_fan_config1 |= fan_mode << (2 * i + 6); 1484 WMID_gaming_set_u64(gpu_fan_config2 | gpu_fan_config1 << 16, ACER_CAP_TURBO_FAN); 1485 } 1486 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 42845 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v5] platform/x86: acer-wmi: Add Turbo Mode support for Acer PH315-53 Date: Fri, 13 Aug 2021 00:43:35 +0800 [thread overview] Message-ID: <202108130011.9S7iFX4u-lkp@intel.com> (raw) In-Reply-To: <20210812125307.1749207-1-jafar.akhoondali@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2692 bytes --] Hi JafarAkhondali, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.14-rc5 next-20210812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1746f4db513563bb22e0ba0c419d0c90912dfae1 config: i386-randconfig-a015-20210812 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/292cfa3c9af2eb61b782c6d94d08d35300318ca3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review JafarAkhondali/platform-x86-acer-wmi-Add-Turbo-Mode-support-for-Acer-PH315-53/20210812-212347 git checkout 292cfa3c9af2eb61b782c6d94d08d35300318ca3 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/platform/x86/acer-wmi.c:1466:6: warning: no previous prototype for 'WMID_gaming_set_fan_mode' [-Wmissing-prototypes] 1466 | void WMID_gaming_set_fan_mode(u8 fan_mode) | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/WMID_gaming_set_fan_mode +1466 drivers/platform/x86/acer-wmi.c 1465 > 1466 void WMID_gaming_set_fan_mode(u8 fan_mode) 1467 { 1468 /* fan_mode = 1 is used for auto, fan_mode = 2 used for turbo*/ 1469 u64 gpu_fan_config1 = 0, gpu_fan_config2 = 0; 1470 int i; 1471 1472 if (quirks->cpu_fans > 0) 1473 gpu_fan_config2 |= 1; 1474 for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i) 1475 gpu_fan_config2 |= 1 << (i + 1); 1476 for (i = 0; i < quirks->gpu_fans; ++i) 1477 gpu_fan_config2 |= 1 << (i + 3); 1478 if (quirks->cpu_fans > 0) 1479 gpu_fan_config1 |= fan_mode; 1480 for (i = 0; i < (quirks->cpu_fans + quirks->gpu_fans); ++i) 1481 gpu_fan_config1 |= fan_mode << (2 * i + 2); 1482 for (i = 0; i < quirks->gpu_fans; ++i) 1483 gpu_fan_config1 |= fan_mode << (2 * i + 6); 1484 WMID_gaming_set_u64(gpu_fan_config2 | gpu_fan_config1 << 16, ACER_CAP_TURBO_FAN); 1485 } 1486 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 42845 bytes --]
next prev parent reply other threads:[~2021-08-12 16:44 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-12 12:53 [PATCH v5] platform/x86: acer-wmi: Add Turbo Mode support for Acer PH315-53 JafarAkhondali 2021-08-12 16:43 ` kernel test robot [this message] 2021-08-12 16:43 ` kernel test robot 2021-08-12 17:57 ` kernel test robot 2021-08-12 17:57 ` kernel test robot 2021-08-12 20:15 ` Hans de Goede 2021-08-13 11:22 ` Hans de Goede 2021-08-14 11:40 ` Jafar Akhondali 2021-08-15 13:50 ` Hans de Goede 2021-08-12 16:43 kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202108130011.9S7iFX4u-lkp@intel.com \ --to=lkp@intel.com \ --cc=hdegoede@redhat.com \ --cc=jafar.akhoondali@gmail.com \ --cc=jlee@suse.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mgross@linux.intel.com \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.