Re: [PATCH 2/3] dm integrity: log audit events for dm-integrity target

From: kernel test robot <lkp@intel.com>
To: "Michael Weiß" <michael.weiss@aisec.fraunhofer.de>
Cc: kbuild-all@lists.01.org, Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Song Liu <song@kernel.org>,
	Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-audit@redhat.com
Subject: Re: [PATCH 2/3] dm integrity: log audit events for dm-integrity target
Date: Fri, 13 Aug 2021 01:20:54 +0800	[thread overview]
Message-ID: <202108130142.Ou58PULb-lkp@intel.com> (raw)
In-Reply-To: <20210812145748.4460-3-michael.weiss@aisec.fraunhofer.de>

[-- Attachment #1: Type: text/plain, Size: 3756 bytes --]

Hi "Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on dm/for-next]
[also build test ERROR on song-md/md-next pcmoore-audit/next v5.14-rc5 next-20210812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michael-Wei/dm-audit-event-logging/20210812-230045
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: h8300-randconfig-r032-20210812 (attached as .config)
compiler: h8300-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6fbfa051e144cc5cb000f7de14ee5b0e83d82b57
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Wei/dm-audit-event-logging/20210812-230045
        git checkout 6fbfa051e144cc5cb000f7de14ee5b0e83d82b57
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/md/dm-integrity.c:26:
>> drivers/md/dm-audit.h:24:1: error: expected identifier or '(' before '{' token
      24 | {
         | ^
   drivers/md/dm-audit.h:29:1: error: expected identifier or '(' before '{' token
      29 | {
         | ^
>> drivers/md/dm-audit.h:21:20: warning: 'dm_audit_log_bio' used but never defined
      21 | static inline void dm_audit_log_bio(const char *dm_msg_prefix, const char *op,
         |                    ^~~~~~~~~~~~~~~~
>> drivers/md/dm-audit.h:26:20: warning: 'dm_audit_log_target' used but never defined
      26 | static inline void dm_audit_log_target(const char *dm_msg_prefix,
         |                    ^~~~~~~~~~~~~~~~~~~

vim +24 drivers/md/dm-audit.h

a409dd36b7054b Michael Weiß 2021-08-12  14  
a409dd36b7054b Michael Weiß 2021-08-12  15  #ifdef CONFIG_DM_AUDIT
a409dd36b7054b Michael Weiß 2021-08-12  16  void dm_audit_log_bio(const char *dm_msg_prefix, const char *op,
a409dd36b7054b Michael Weiß 2021-08-12  17  		      struct bio *bio, sector_t sector, int result);
a409dd36b7054b Michael Weiß 2021-08-12  18  void dm_audit_log_target(const char *dm_msg_prefix, const char *op,
a409dd36b7054b Michael Weiß 2021-08-12  19  			 struct dm_target *ti, int result);
a409dd36b7054b Michael Weiß 2021-08-12  20  #else
a409dd36b7054b Michael Weiß 2021-08-12 @21  static inline void dm_audit_log_bio(const char *dm_msg_prefix, const char *op,
a409dd36b7054b Michael Weiß 2021-08-12  22  				    struct bio *bio, sector_t sector,
a409dd36b7054b Michael Weiß 2021-08-12  23  				    int result);
a409dd36b7054b Michael Weiß 2021-08-12 @24  {
a409dd36b7054b Michael Weiß 2021-08-12  25  }
a409dd36b7054b Michael Weiß 2021-08-12 @26  static inline void dm_audit_log_target(const char *dm_msg_prefix,
a409dd36b7054b Michael Weiß 2021-08-12  27  				       const char *op, struct dm_target *ti,
a409dd36b7054b Michael Weiß 2021-08-12  28  				       int result);
a409dd36b7054b Michael Weiß 2021-08-12  29  {
a409dd36b7054b Michael Weiß 2021-08-12  30  }
a409dd36b7054b Michael Weiß 2021-08-12  31  #endif
a409dd36b7054b Michael Weiß 2021-08-12  32  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 21996 bytes --]