* [PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey
@ 2021-08-13 12:49 Heinrich Schuchardt
2021-08-13 13:31 ` Daniel Kiper
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2021-08-13 12:49 UTC (permalink / raw)
To: Daniel Kiper; +Cc: grub-devel, Heinrich Schuchardt, Heinrich Schuchardt
Avoid a warning
lib/libgcrypt-grub/cipher/rijndael.c:229:9:
warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
229 | ;
| ^
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
grub-core/lib/libgcrypt/cipher/rijndael.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/grub-core/lib/libgcrypt/cipher/rijndael.c b/grub-core/lib/libgcrypt/cipher/rijndael.c
index 559550b50..9d884c9d3 100644
--- a/grub-core/lib/libgcrypt/cipher/rijndael.c
+++ b/grub-core/lib/libgcrypt/cipher/rijndael.c
@@ -227,7 +227,9 @@ do_setkey (RIJNDAEL_context *ctx, const byte *key, const unsigned keylen)
KC = 4;
if (0)
- ;
+ {
+ ;
+ }
#ifdef USE_PADLOCK
else if ((_gcry_get_hw_features () & HWF_PADLOCK_AES))
{
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey
2021-08-13 12:49 [PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey Heinrich Schuchardt
@ 2021-08-13 13:31 ` Daniel Kiper
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2021-08-13 13:31 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: grub-devel, Heinrich Schuchardt
On Fri, Aug 13, 2021 at 02:49:10PM +0200, Heinrich Schuchardt wrote:
> Avoid a warning
>
> lib/libgcrypt-grub/cipher/rijndael.c:229:9:
> warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> 229 | ;
> | ^
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Thank you for the fixes.
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-13 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 12:49 [PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey Heinrich Schuchardt
2021-08-13 13:31 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.