All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: kbuild-all@lists.01.org, lorenzo.bianconi@redhat.com,
	davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, shayagr@amazon.com,
	john.fastabend@gmail.com, dsahern@kernel.org
Subject: [RFC PATCH] bpf: bpf_xdp_get_buff_len_proto can be static
Date: Fri, 13 Aug 2021 23:18:08 +0800	[thread overview]
Message-ID: <20210813151808.GA61736@170502314c35> (raw)
In-Reply-To: <a742a962e3843b1ee85ed56ca934f15f61366a71.1628854454.git.lorenzo@kernel.org>

net/core/filter.c:3801:29: warning: symbol 'bpf_xdp_get_buff_len_proto' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 filter.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index 93ce775eaadfc..0c496d155aee1 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -3798,7 +3798,7 @@ BPF_CALL_1(bpf_xdp_get_buff_len, struct  xdp_buff*, xdp)
 	return len;
 }
 
-const struct bpf_func_proto bpf_xdp_get_buff_len_proto = {
+static const struct bpf_func_proto bpf_xdp_get_buff_len_proto = {
 	.func		= bpf_xdp_get_buff_len,
 	.gpl_only	= false,
 	.ret_type	= RET_INTEGER,

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] bpf: bpf_xdp_get_buff_len_proto can be static
Date: Fri, 13 Aug 2021 23:18:08 +0800	[thread overview]
Message-ID: <20210813151808.GA61736@170502314c35> (raw)
In-Reply-To: <a742a962e3843b1ee85ed56ca934f15f61366a71.1628854454.git.lorenzo@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

net/core/filter.c:3801:29: warning: symbol 'bpf_xdp_get_buff_len_proto' was not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 filter.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index 93ce775eaadfc..0c496d155aee1 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -3798,7 +3798,7 @@ BPF_CALL_1(bpf_xdp_get_buff_len, struct  xdp_buff*, xdp)
 	return len;
 }
 
-const struct bpf_func_proto bpf_xdp_get_buff_len_proto = {
+static const struct bpf_func_proto bpf_xdp_get_buff_len_proto = {
 	.func		= bpf_xdp_get_buff_len,
 	.gpl_only	= false,
 	.ret_type	= RET_INTEGER,

  parent reply	other threads:[~2021-08-13 15:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 11:47 [PATCH v11 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 01/18] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 02/18] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 03/18] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 04/18] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 05/18] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 06/18] net: marvell: rely on " Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 07/18] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 08/18] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 09/18] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 10/18] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 11/18] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-08-13 15:18   ` kernel test robot
2021-08-13 15:18     ` kernel test robot
2021-08-13 15:18   ` kernel test robot [this message]
2021-08-13 15:18     ` [RFC PATCH] bpf: bpf_xdp_get_buff_len_proto can be static kernel test robot
2021-08-13 11:47 ` [PATCH v11 bpf-next 12/18] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 13/18] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 14/18] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 15/18] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 16/18] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 17/18] net: xdp: introduce bpf_xdp_adjust_data helper Lorenzo Bianconi
2021-08-18 12:31   ` Toke Høiland-Jørgensen
2021-08-18 12:47     ` Lorenzo Bianconi
2021-08-18 12:58       ` Toke Høiland-Jørgensen
2021-08-18 13:37         ` Lorenzo Bianconi
2021-08-13 11:47 ` [PATCH v11 bpf-next 18/18] bpf: add bpf_xdp_adjust_data selftest Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813151808.GA61736@170502314c35 \
    --to=lkp@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shayagr@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.