From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gdb: fix build of gdb on riscv
Date: Sun, 15 Aug 2021 17:57:43 +0200 [thread overview]
Message-ID: <20210815175743.012d125f@windsurf> (raw)
In-Reply-To: <20210813142626.2941588-1-fontaine.fabrice@gmail.com>
On Fri, 13 Aug 2021 16:26:26 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> +# recent gdb versions (>= 10) have gdbserver moved at the top-level,
> +# which requires a different build logic.
> +ifeq ($(BR2_PACKAGE_HOST_GDB):$(BR2_riscv),:y)
> +GDB_GDBSERVER_TOPLEVEL = y
> +endif
> +
> GDB_LICENSE = GPL-2.0+, LGPL-2.0+, GPL-3.0+, LGPL-3.0+
> GDB_LICENSE_FILES = COPYING COPYING.LIB COPYING3 COPYING3.LIB
> GDB_CPE_ID_VENDOR = gnu
While I understand the idea, I'm not entirely sure it's the most
logical way. What about instead changing the current:
ifeq ($(BR2_GDB_VERSION_10),y)
GDB_GDBSERVER_TOPLEVEL = y
endif
by:
ifeq ($(GDB_VERSION_10),10.1)
GDB_GDBSERVER_TOPLEVEL = y
endif
This way, it really expresses what we want: gdb version 10.x require a
different build logic.
Alternatively, we could do a hidden Config.in boolean:
config BR2_PACKAGE_GDB_TOPLEVEL
bool
default y if BR2_GDB_VERSION_10
default y if !BR2_PACKAGE_HOST_GDB && BR2_riscv
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-15 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 14:26 [Buildroot] [PATCH 1/1] package/gdb: fix build of gdb on riscv Fabrice Fontaine
2021-08-15 15:57 ` Thomas Petazzoni [this message]
2021-08-15 16:07 ` Fabrice Fontaine
2021-08-18 20:33 ` Thomas Petazzoni
2021-08-18 21:16 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815175743.012d125f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.