Re: [Buildroot] [PATCH 1/1] package/gdb: fix build of gdb on riscv

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Fabrice,

On Sun, 15 Aug 2021 18:07:56 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > While I understand the idea, I'm not entirely sure it's the most
> > logical way. What about instead changing the current:
> >
> > ifeq ($(BR2_GDB_VERSION_10),y)
> > GDB_GDBSERVER_TOPLEVEL = y
> > endif
> >
> > by:
> >
> > ifeq ($(GDB_VERSION_10),10.1)
> > GDB_GDBSERVER_TOPLEVEL = y
> > endif  
> This one won't work as GDB_VERSION_10 is not defined if host-gdb is
> not selected.

Sorry, I meant to do:

ifeq ($(GDB_VERSION),10.1)

which would work in all cases.

> > This way, it really expresses what we want: gdb version 10.x require a
> > different build logic.
> >
> > Alternatively, we could do a hidden Config.in boolean:
> >
> > config BR2_PACKAGE_GDB_TOPLEVEL
> >         bool
> >         default y if BR2_GDB_VERSION_10
> >         default y if !BR2_PACKAGE_HOST_GDB && BR2_riscv  
>
> I'll test this one but I think that it should work.

But I find this alternative a bit better. Looking forward to the patch!

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot