All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: lgirdwood@gmail.com, ulf.hansson@linaro.org,
	lee.jones@linaro.org, zhangchangzhong@huawei.com,
	heiko@sntech.de, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] regulator: core: notify regulator enable with the voltage value
Date: Mon, 16 Aug 2021 13:00:59 +0100	[thread overview]
Message-ID: <20210816120059.GA4253@sirena.org.uk> (raw)
In-Reply-To: <20210816032003.1162779-3-jay.xu@rock-chips.com>


[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

On Mon, Aug 16, 2021 at 11:20:01AM +0800, Jianqun Xu wrote:

> +			ret = _regulator_get_voltage(rdev);
> +			if (ret < 0)
> +				ret = 0;
> +
>  			_notifier_call_chain(rdev, REGULATOR_EVENT_ENABLE,
> -					     NULL);
> +					     &ret);

This is going to be really expensive for devices without a cache and
it's going to be *very* rarely used if ever.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: lgirdwood@gmail.com, ulf.hansson@linaro.org,
	lee.jones@linaro.org, zhangchangzhong@huawei.com,
	heiko@sntech.de, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] regulator: core: notify regulator enable with the voltage value
Date: Mon, 16 Aug 2021 13:00:59 +0100	[thread overview]
Message-ID: <20210816120059.GA4253@sirena.org.uk> (raw)
In-Reply-To: <20210816032003.1162779-3-jay.xu@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

On Mon, Aug 16, 2021 at 11:20:01AM +0800, Jianqun Xu wrote:

> +			ret = _regulator_get_voltage(rdev);
> +			if (ret < 0)
> +				ret = 0;
> +
>  			_notifier_call_chain(rdev, REGULATOR_EVENT_ENABLE,
> -					     NULL);
> +					     &ret);

This is going to be really expensive for devices without a cache and
it's going to be *very* rarely used if ever.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-08-16 12:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  3:19 [PATCH 0/4] regulator pre-enable Jianqun Xu
2021-08-16  3:19 ` Jianqun Xu
2021-08-16  3:20 ` [PATCH 1/4] regulator: add PRE_ENABLE event define Jianqun Xu
2021-08-16  3:20   ` Jianqun Xu
2021-08-16  3:20 ` [PATCH 2/4] regulator: core: notify regulator enable with the voltage value Jianqun Xu
2021-08-16  3:20   ` Jianqun Xu
2021-08-16 12:00   ` Mark Brown [this message]
2021-08-16 12:00     ` Mark Brown
2021-08-17  3:17     ` jay.xu
2021-08-17  3:23       ` jay.xu
2021-08-16  3:20 ` [PATCH 3/4] regulator: core: add pre-enable event notify to regulator Jianqun Xu
2021-08-16  3:20   ` Jianqun Xu
2021-08-16  3:20 ` [PATCH 4/4] soc: rockchip: io-domain: do more thing about regulator notify Jianqun Xu
2021-08-16  3:20   ` Jianqun Xu
2021-08-16 12:39   ` Ulf Hansson
2021-08-16 12:39     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210816120059.GA4253@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangchangzhong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.