[PATCH 1/2] monitor: Fix Maximum PDU type in CIS Test Param

[PATCH 1/2] monitor: Fix Maximum PDU type in CIS Test Param

[mariusz.skamra]

From: Mariusz Skamra <mariusz.skamra@codecoup.pl>

The Maximum PDU in CIS Test parameters is 2 byte value.
---
 monitor/bt.h     | 4 ++--
 monitor/packet.c | 8 +++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/monitor/bt.h b/monitor/bt.h
index 738bc294b..0bc5718a0 100644
--- a/monitor/bt.h
+++ b/monitor/bt.h
@@ -2681,8 +2681,8 @@ struct bt_hci_cis_params_test {
 	uint8_t  nse;
 	uint16_t m_sdu;
 	uint16_t s_sdu;
-	uint8_t  m_pdu;
-	uint8_t  s_pdu;
+	uint16_t m_pdu;
+	uint16_t s_pdu;
 	uint8_t  m_phy;
 	uint8_t  s_phy;
 	uint8_t  m_bn;
diff --git a/monitor/packet.c b/monitor/packet.c
index 025b7e9b0..210c03259 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -8063,12 +8063,14 @@ static void print_cis_params_test(const void *data, int i)
 
 	print_field("CIS ID: 0x%2.2x", cis->cis_id);
 	print_field("NSE: 0x%2.2x", cis->nse);
-	print_field("Master to Slave Maximum SDU: 0x%4.4x", cis->m_sdu);
+	print_field("Master to Slave Maximum SDU: 0x%4.4x",
+						le16_to_cpu(cis->m_sdu));
 	print_field("Slave to Master Maximum SDU: 0x%4.4x",
 						le16_to_cpu(cis->s_sdu));
-	print_field("Master to Slave Maximum PDU: 0x%2.2x",
+	print_field("Master to Slave Maximum PDU: 0x%4.4x",
 						le16_to_cpu(cis->m_pdu));
-	print_field("Slave to Master Maximum PDU: 0x%2.2x", cis->s_pdu);
+	print_field("Slave to Master Maximum PDU: 0x%4.4x",
+						le16_to_cpu(cis->s_pdu));
 	print_le_phy("Master to Slave PHY", cis->m_phy);
 	print_le_phy("Slave to Master PHY", cis->s_phy);
 	print_field("Master to Slave Burst Number: 0x%2.2x", cis->m_bn);
-- 
2.31.1

[PATCH 2/2] monitor: Fix logging of CIG Test SDU Interval param

[mariusz.skamra]

From: Mariusz Skamra <mariusz.skamra@codecoup.pl>

This fixes log of SDU interval in StoM direction.
---
 monitor/packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 210c03259..74d9a87a3 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -8083,7 +8083,7 @@ static void le_set_cig_params_test_cmd(const void *data, uint8_t size)
 
 	print_field("CIG ID: 0x%2.2x", cmd->cig_id);
 	print_usec_interval("Master to Slave SDU Interval", cmd->m_interval);
-	print_usec_interval("Master to Slave SDU Interval", cmd->s_interval);
+	print_usec_interval("Slave to Master SDU Interval", cmd->s_interval);
 	print_field("Master to Slave Flush Timeout: 0x%2.2x", cmd->m_ft);
 	print_field("Slave to Master Flush Timeout: 0x%2.2x", cmd->s_ft);
 	print_field("ISO Interval: %.2f ms (0x%4.4x)",
-- 
2.31.1

RE: [1/2] monitor: Fix Maximum PDU type in CIS Test Param

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=532127

---Test result---

Test Summary:
CheckPatch                    PASS      0.56 seconds
GitLint                       PASS      0.21 seconds
Prep - Setup ELL              PASS      40.89 seconds
Build - Prep                  PASS      0.12 seconds
Build - Configure             PASS      7.25 seconds
Build - Make                  PASS      180.58 seconds
Make Check                    PASS      8.94 seconds
Make Distcheck                PASS      215.74 seconds
Build w/ext ELL - Configure   PASS      7.36 seconds
Build w/ext ELL - Make        PASS      170.85 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth