From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, pali@kernel.org
Subject: Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART
Date: Mon, 16 Aug 2021 15:01:40 +0200 [thread overview]
Message-ID: <20210816150140.5a622211@dellmb> (raw)
In-Reply-To: <446b9f6d-70d0-04fc-ea4c-edbd876a194e@denx.de>
On Mon, 16 Aug 2021 14:50:15 +0200
Stefan Roese <sr@denx.de> wrote:
> > - disable_mcu_watchdog();
> > + /*
> > + * If not booting from UART, MCU watchdog was not disabled
> > in SPL,
> > + * disable it now.
> > + */
> > + if (get_boot_device() != BOOT_DEVICE_UART)
> > + disable_mcu_watchdog();
>
> Why do you disable the MCU watchdog here in U-Boot proper?
Hi Stefan,
this is just where it was before.
But looking at the prompt
SoC: MV88F6820-A0 at 1600 MHz
DRAM: 2 GiB (800 MHz, 32-bit, 2T, ECC not enabled)
Disabling MCU watchdog... disabled
WDT: Started with servicing (60s timeout)
it looks like U-Boot's watchdog is being enabled after MCU watchdog.
It would be better to enable U-Boot's WDT before disabling MCU watchdog.
I will send another patch that moves it to another function,
board_late_init for example.
Shall I resend this series with this new patch?
Marek
next prev parent reply other threads:[~2021-08-16 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 12:27 [PATCH u-boot-mvebu 0/3] turris_omnia: Disable MCU watchdog in SPL when booting over UART Marek Behún
2021-08-16 12:27 ` [PATCH u-boot-mvebu 1/3] arm: mvebu: Move get_boot_device() to cpu.c and make visible Marek Behún
2021-08-16 12:27 ` [PATCH u-boot-mvebu 2/3] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro Marek Behún
2021-08-16 12:27 ` [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART Marek Behún
2021-08-16 12:50 ` Stefan Roese
2021-08-16 13:01 ` Marek Behún [this message]
2021-08-16 13:07 ` Stefan Roese
2021-08-16 13:11 ` Marek Behún
2021-08-16 13:13 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816150140.5a622211@dellmb \
--to=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.