[PATCH 0/3] MAINTAINERS: Split Audio section

[PATCH 0/3] MAINTAINERS: Split Audio section

[Philippe Mathieu-Daudé]

Split the current 'Audio' entry in multiple ones, allowing developers
with different interests to add their contact to the relevant entries.

Philippe Mathieu-Daudé (3):
  MAINTAINERS: Split Audio backends VS frontends
  MAINTAINERS: Remove SPICE from Audio backends section
  MAINTAINERS: Split Audio backends sections

 MAINTAINERS | 61 +++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 54 insertions(+), 7 deletions(-)

-- 
2.31.1

[PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6b3697962c1..9ec6baa7e4c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
 
 Devices
 -------
+Overall Audio frontends
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: hw/audio/
+F: include/hw/audio/
+F: tests/qtest/ac97-test.c
+F: tests/qtest/es1370-test.c
+F: tests/qtest/intel-hda-test.c
+F: tests/qtest/fuzz-sb16-test.c
+
 Xilinx CAN
 M: Vikram Garhwal <fnu.vikram@xilinx.com>
 M: Francisco Iglesias <francisco.iglesias@xilinx.com>
@@ -2256,17 +2266,11 @@ F: include/net/can_*.h
 
 Subsystems
 ----------
-Audio
+Overall Audio backends
 M: Gerd Hoffmann <kraxel@redhat.com>
 S: Odd Fixes
 F: audio/
-F: hw/audio/
-F: include/hw/audio/
 F: qapi/audio.json
-F: tests/qtest/ac97-test.c
-F: tests/qtest/es1370-test.c
-F: tests/qtest/intel-hda-test.c
-F: tests/qtest/fuzz-sb16-test.c
 
 Block layer core
 M: Kevin Wolf <kwolf@redhat.com>
-- 
2.31.1

[PATCH 2/3] MAINTAINERS: Remove SPICE from Audio backends section

[Philippe Mathieu-Daudé]

SPICE audio is already covered in the SPICE section,
so remove it from the Audio backends one.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9ec6baa7e4c..f18fcd76450 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2270,6 +2270,7 @@ Overall Audio backends
 M: Gerd Hoffmann <kraxel@redhat.com>
 S: Odd Fixes
 F: audio/
+X: audio/spiceaudio.c
 F: qapi/audio.json
 
 Block layer core
-- 
2.31.1

[PATCH 3/3] MAINTAINERS: Split Audio backends sections

[Philippe Mathieu-Daudé]

Split the Audio backends into multiple sections (OS / framework /
library), allowing developers with different interests to add their
contact to the relevant entries.

Suggested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f18fcd76450..94dea726e05 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2270,9 +2270,51 @@ Overall Audio backends
 M: Gerd Hoffmann <kraxel@redhat.com>
 S: Odd Fixes
 F: audio/
+X: audio/alsaaudio.c
+X: audio/coreaudio.c
+X: audio/dsound*
+X: audio/jackaudio.c
+X: audio/ossaudio.c
+X: audio/paaudio.c
+X: audio/sdlaudio.c
 X: audio/spiceaudio.c
 F: qapi/audio.json
 
+ALSA Audio backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/alsaaudio.c
+
+Core Audio framework backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/coreaudio.c
+
+DSound Audio backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/dsound*
+
+JACK Audio Connection Kit backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/jackaudio.c
+
+Open Sound System (OSS) Audio backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/ossaudio.c
+
+PulseAudio backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/paaudio.c
+
+SDL Audio backend
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: audio/sdlaudio.c
+
 Block layer core
 M: Kevin Wolf <kwolf@redhat.com>
 M: Hanna Reitz <hreitz@redhat.com>
-- 
2.31.1

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Christian Schoenebeck]

On Montag, 16. August 2021 21:10:12 CEST Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b3697962c1..9ec6baa7e4c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
> 
>  Devices
>  -------
> +Overall Audio frontends
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: hw/audio/
> +F: include/hw/audio/
> +F: tests/qtest/ac97-test.c
> +F: tests/qtest/es1370-test.c
> +F: tests/qtest/intel-hda-test.c
> +F: tests/qtest/fuzz-sb16-test.c
> +

I would call that "Audio Hardware Emulation" instead of "Overall Audio 
frontends".

And probably it would make sense to further subdivide this section into the 
individual hardware models (Sound Blaster, Adlib, PC Speaker, VIA AC97, ...), 
similar to patch 3. Could be split subsequently as well of course.

>  Xilinx CAN
>  M: Vikram Garhwal <fnu.vikram@xilinx.com>
>  M: Francisco Iglesias <francisco.iglesias@xilinx.com>
> @@ -2256,17 +2266,11 @@ F: include/net/can_*.h
> 
>  Subsystems
>  ----------
> -Audio
> +Overall Audio backends
>  M: Gerd Hoffmann <kraxel@redhat.com>
>  S: Odd Fixes
>  F: audio/
> -F: hw/audio/
> -F: include/hw/audio/
>  F: qapi/audio.json
> -F: tests/qtest/ac97-test.c
> -F: tests/qtest/es1370-test.c
> -F: tests/qtest/intel-hda-test.c
> -F: tests/qtest/fuzz-sb16-test.c
> 
>  Block layer core
>  M: Kevin Wolf <kwolf@redhat.com>

Likewise I would call this section "Shared/common QEMU audio library/
subsystem" or something like that instead of "Overall Audio backends".

Best regards,
Christian Schoenebeck

Re: [PATCH 2/3] MAINTAINERS: Remove SPICE from Audio backends section

[Christian Schoenebeck]

On Montag, 16. August 2021 21:10:13 CEST Philippe Mathieu-Daudé wrote:
> SPICE audio is already covered in the SPICE section,
> so remove it from the Audio backends one.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9ec6baa7e4c..f18fcd76450 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2270,6 +2270,7 @@ Overall Audio backends
>  M: Gerd Hoffmann <kraxel@redhat.com>
>  S: Odd Fixes
>  F: audio/
> +X: audio/spiceaudio.c
>  F: qapi/audio.json
> 
>  Block layer core

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck

Re: [PATCH 3/3] MAINTAINERS: Split Audio backends sections

[Christian Schoenebeck]

On Montag, 16. August 2021 21:10:14 CEST Philippe Mathieu-Daudé wrote:
> Split the Audio backends into multiple sections (OS / framework /
> library), allowing developers with different interests to add their
> contact to the relevant entries.
> 
> Suggested-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f18fcd76450..94dea726e05 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2270,9 +2270,51 @@ Overall Audio backends
>  M: Gerd Hoffmann <kraxel@redhat.com>
>  S: Odd Fixes
>  F: audio/
> +X: audio/alsaaudio.c
> +X: audio/coreaudio.c
> +X: audio/dsound*
> +X: audio/jackaudio.c
> +X: audio/ossaudio.c
> +X: audio/paaudio.c
> +X: audio/sdlaudio.c
>  X: audio/spiceaudio.c
>  F: qapi/audio.json
> 
> +ALSA Audio backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/alsaaudio.c
> +
> +Core Audio framework backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/coreaudio.c
> +
> +DSound Audio backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/dsound*
> +
> +JACK Audio Connection Kit backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/jackaudio.c
> +
> +Open Sound System (OSS) Audio backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/ossaudio.c
> +
> +PulseAudio backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/paaudio.c
> +
> +SDL Audio backend
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: audio/sdlaudio.c
> +
>  Block layer core
>  M: Kevin Wolf <kwolf@redhat.com>
>  M: Hanna Reitz <hreitz@redhat.com>

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Gerd Hoffmann]

  Hi,

> > +Overall Audio frontends

> I would call that "Audio Hardware Emulation" instead of "Overall Audio 
> frontends".

> > +Overall Audio backends

> Likewise I would call this section "Shared/common QEMU audio library/
> subsystem" or something like that instead of "Overall Audio backends".

Well, frontend/backend is common qemu terminology, with "frontend" being
the emulated/virtual device as seen by the guest and "backend" being the 
host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

take care,
  Gerd

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Christian Schoenebeck]

On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
>   Hi,
> 
> > > +Overall Audio frontends
> > 
> > I would call that "Audio Hardware Emulation" instead of "Overall Audio
> > frontends".
> > 
> > > +Overall Audio backends
> > 
> > Likewise I would call this section "Shared/common QEMU audio library/
> > subsystem" or something like that instead of "Overall Audio backends".
> 
> Well, frontend/backend is common qemu terminology, with "frontend" being
> the emulated/virtual device as seen by the guest and "backend" being the
> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
> 
> take care,
>   Gerd

Yeah, I was seeing this (like usual) more from an external/new developer 
perspective where the semantic for "frontend"/"backend" is not that obvious 
here.

But okay ...

Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Philippe Mathieu-Daudé]

On 8/17/21 6:12 PM, Christian Schoenebeck wrote:
> On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
>>   Hi,
>>
>>>> +Overall Audio frontends
>>>
>>> I would call that "Audio Hardware Emulation" instead of "Overall Audio
>>> frontends".
>>>
>>>> +Overall Audio backends
>>>
>>> Likewise I would call this section "Shared/common QEMU audio library/
>>> subsystem" or something like that instead of "Overall Audio backends".
>>
>> Well, frontend/backend is common qemu terminology, with "frontend" being
>> the emulated/virtual device as seen by the guest and "backend" being the
>> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
>>
>> take care,
>>   Gerd
> 
> Yeah, I was seeing this (like usual) more from an external/new developer 
> perspective where the semantic for "frontend"/"backend" is not that obvious 
> here.

"Audio Backends" is in the "Subsystems" meta-section, and
"Audio Frontends" in the "Devices" one.

Maybe we using the === separator for meta-sections (like rST)
instead of --- would help seeing the difference.

I don't want to use parenthesis in the descriptions because
this then breaks the get_maintainer.pl output when parsed
by (git) scripts.

> 
> But okay ...
> 
> Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> 
> Best regards,
> Christian Schoenebeck
> 
> 

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

[Christian Schoenebeck]

On Dienstag, 17. August 2021 19:57:21 CEST Philippe Mathieu-Daudé wrote:
> On 8/17/21 6:12 PM, Christian Schoenebeck wrote:
> > On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
> >>   Hi,
> >>   
> >>>> +Overall Audio frontends
> >>> 
> >>> I would call that "Audio Hardware Emulation" instead of "Overall Audio
> >>> frontends".
> >>> 
> >>>> +Overall Audio backends
> >>> 
> >>> Likewise I would call this section "Shared/common QEMU audio library/
> >>> subsystem" or something like that instead of "Overall Audio backends".
> >> 
> >> Well, frontend/backend is common qemu terminology, with "frontend" being
> >> the emulated/virtual device as seen by the guest and "backend" being the
> >> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
> >> 
> >> take care,
> >> 
> >>   Gerd
> > 
> > Yeah, I was seeing this (like usual) more from an external/new developer
> > perspective where the semantic for "frontend"/"backend" is not that
> > obvious
> > here.
> 
> "Audio Backends" is in the "Subsystems" meta-section, and
> "Audio Frontends" in the "Devices" one.
> 
> Maybe we using the === separator for meta-sections (like rST)
> instead of --- would help seeing the difference.

No need for now. On the long-term the MAINTAINERS structure might be improved 
in some way to make specific tree structures more clear, but for now it's Ok.

Thanks!

Best regards,
Christian Schoenebeck