All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/adl_p: Also disable underrun recovery with MSO
@ 2021-08-16 20:41 Matt Roper
  2021-08-17 16:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Matt Roper @ 2021-08-16 20:41 UTC (permalink / raw)
  To: intel-gfx; +Cc: matthew.d.roper, Ville Syrjälä

One of the cases that the bspec lists for when underrun recovery must be
disabled is "COG;" that note actually refers to eDP multi-segmented
operation (MSO).  Let's ensure the this additional restriction is
honored by the driver.

Bspec: 50351
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: ba3b049f4774 ("drm/i915/adl_p: Allow underrun recovery when possible")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a257e5dc381c..134a6acbd8fb 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2226,6 +2226,9 @@ static bool underrun_recovery_supported(const struct intel_crtc_state *crtc_stat
 	if (crtc_state->has_psr2)
 		return false;
 
+	if (crtc_state->splitter.enable)
+		return false;
+
 	return true;
 }
 
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-08-18 21:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 20:41 [Intel-gfx] [PATCH] drm/i915/adl_p: Also disable underrun recovery with MSO Matt Roper
2021-08-17 16:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-08-17 16:26   ` Matt Roper
2021-08-17 17:17     ` Vudum, Lakshminarayana
2021-08-17 16:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-17 18:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-18 21:35 ` [Intel-gfx] [PATCH] " Souza, Jose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.