Re: [PATCH v3 2/6] input: add Qualcomm SPMI haptics driver

From: kernel test robot <lkp@intel.com>
To: Caleb Connolly <caleb@connolly.tech>
Cc: kbuild-all@lists.01.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 2/6] input: add Qualcomm SPMI haptics driver
Date: Tue, 17 Aug 2021 10:12:06 +0800	[thread overview]
Message-ID: <202108171000.nTvnwsra-lkp@intel.com> (raw)
In-Reply-To: <20210816221931.1998187-3-caleb@connolly.tech>

[-- Attachment #1: Type: text/plain, Size: 2997 bytes --]

Hi Caleb,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on input/next v5.14-rc6 next-20210816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Caleb-Connolly/input-Introduce-support-for-SPMI-haptics-found-on-Qcom-PMICs/20210817-062200
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4fe3986969c516117a071eb5f9df141c6fc95b69
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Caleb-Connolly/input-Introduce-support-for-SPMI-haptics-found-on-Qcom-PMICs/20210817-062200
        git checkout 4fe3986969c516117a071eb5f9df141c6fc95b69
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/input/misc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/input/misc/qcom-spmi-haptics.c:196: warning: Function parameter or member 'haptics_input_dev' not described in 'spmi_haptics'
   drivers/input/misc/qcom-spmi-haptics.c:634: warning: Excess function parameter 'enable' description in 'spmi_haptics_enable'
>> drivers/input/misc/qcom-spmi-haptics.c:679: warning: expecting prototype for spmi_haptics_enable(). Prototype was for spmi_haptics_disable() instead

vim +679 drivers/input/misc/qcom-spmi-haptics.c

   671	
   672	/**
   673	 * spmi_haptics_enable - handler to start/stop vibration
   674	 * @haptics: pointer to haptics struct
   675	 * @enable: state to set
   676	 * Returns: 0 on success, < 0 on failure
   677	 */
   678	static int spmi_haptics_disable(struct spmi_haptics *haptics)
 > 679	{
   680		int ret;
   681	
   682		mutex_lock(&haptics->play_lock);
   683	
   684		ret = spmi_haptics_write_play_control(haptics, HAP_STOP);
   685		if (ret < 0) {
   686			dev_err(haptics->dev, "Error disabling play, ret=%d\n", ret);
   687			goto out;
   688		}
   689	
   690		ret = spmi_haptics_module_enable(haptics, false);
   691		if (ret < 0) {
   692			dev_err(haptics->dev, "Error disabling module, ret=%d\n", ret);
   693			goto out;
   694		}
   695	
   696	out:
   697		mutex_unlock(&haptics->play_lock);
   698		return ret;
   699	}
   700	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77944 bytes --]