From: Keith Busch <kbusch@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Dell.Client.Kernel@dell.com
Subject: Re: SK hynix BC511: warning: nvme nvme0: missing or invalid SUBNQN field.
Date: Tue, 17 Aug 2021 10:02:22 -0700 [thread overview]
Message-ID: <20210817170222.GA224912@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <f3f78d3c-d3f7-67f5-4263-f306b4f623d1@molgen.mpg.de>
On Tue, Aug 17, 2021 at 06:53:15PM +0200, Paul Menzel wrote:
> [cc: +Dell.Client.Kernel@dell.com as it’s a Dell device]
> Am 17.08.21 um 18:16 schrieb Keith Busch:
> > On Tue, Aug 17, 2021 at 05:10:40PM +0200, Paul Menzel wrote:
> > > On a Dell OptiPlex 7780 AIO/04G47W (BIOS 1.6.3 03/08/2021) Linux 5.10.47
> > > shows the warning below:
> > >
> > > $ dmesg | grep nvme
> > > [ 3.015392] nvme 0000:02:00.0: platform quirk: setting simple suspend
> > > [ 3.021861] nvme nvme0: pci function 0000:02:00.0
> > > [ 3.026593] ahci 0000:00:17.0: version 3.0
> > > [ 3.026922] ahci 0000:00:17.0: AHCI 0001.0301 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
> > > [ 3.035020] ahci 0000:00:17.0: flags: 64bit ncq sntf pm clo only pio slum part ems deso sadm sds apst
> > > [ 3.035219] nvme nvme0: missing or invalid SUBNQN field.
> > > [ 3.044518] scsi host0: ahci
> > > [ 3.051632] nvme nvme0: 12/0/0 default/read/poll queues
> > > [ 3.052590] ata1: SATA max UDMA/133 abar m2048@0xd1339000 port 0xd1339100 irq 125
> > > [ 3.058538] nvme0n1: p1 p2 p3
> > >
> > > Should it be added to the quirk list in `drivers/nvme/host/pci.c` or is it a
> > > real issues, the manufacturer should fix? If so, do you have SK Hynix
> > > contacts?
> >
> > It would be great if device makers would be spec compliant, but the
> > driver will continue to work with the device the same whether you add
> > the quirk or not.
>
> Could you please point me to the NVMe specification section, so I can refer
> to it, when contacting the manufacturer?
In the section for "Identify Controller Data Structure" (section
5.17.2.1, figure 257 in spec version 2.0), the NQN definition says:
"Support for this field is mandatory if the controller supports revision
1.2.1 or later"
The driver does confirm the controller's reported revision meets this
requirement before emitting the warning.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Dell.Client.Kernel@dell.com
Subject: Re: SK hynix BC511: warning: nvme nvme0: missing or invalid SUBNQN field.
Date: Tue, 17 Aug 2021 10:02:22 -0700 [thread overview]
Message-ID: <20210817170222.GA224912@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <f3f78d3c-d3f7-67f5-4263-f306b4f623d1@molgen.mpg.de>
On Tue, Aug 17, 2021 at 06:53:15PM +0200, Paul Menzel wrote:
> [cc: +Dell.Client.Kernel@dell.com as it’s a Dell device]
> Am 17.08.21 um 18:16 schrieb Keith Busch:
> > On Tue, Aug 17, 2021 at 05:10:40PM +0200, Paul Menzel wrote:
> > > On a Dell OptiPlex 7780 AIO/04G47W (BIOS 1.6.3 03/08/2021) Linux 5.10.47
> > > shows the warning below:
> > >
> > > $ dmesg | grep nvme
> > > [ 3.015392] nvme 0000:02:00.0: platform quirk: setting simple suspend
> > > [ 3.021861] nvme nvme0: pci function 0000:02:00.0
> > > [ 3.026593] ahci 0000:00:17.0: version 3.0
> > > [ 3.026922] ahci 0000:00:17.0: AHCI 0001.0301 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
> > > [ 3.035020] ahci 0000:00:17.0: flags: 64bit ncq sntf pm clo only pio slum part ems deso sadm sds apst
> > > [ 3.035219] nvme nvme0: missing or invalid SUBNQN field.
> > > [ 3.044518] scsi host0: ahci
> > > [ 3.051632] nvme nvme0: 12/0/0 default/read/poll queues
> > > [ 3.052590] ata1: SATA max UDMA/133 abar m2048@0xd1339000 port 0xd1339100 irq 125
> > > [ 3.058538] nvme0n1: p1 p2 p3
> > >
> > > Should it be added to the quirk list in `drivers/nvme/host/pci.c` or is it a
> > > real issues, the manufacturer should fix? If so, do you have SK Hynix
> > > contacts?
> >
> > It would be great if device makers would be spec compliant, but the
> > driver will continue to work with the device the same whether you add
> > the quirk or not.
>
> Could you please point me to the NVMe specification section, so I can refer
> to it, when contacting the manufacturer?
In the section for "Identify Controller Data Structure" (section
5.17.2.1, figure 257 in spec version 2.0), the NQN definition says:
"Support for this field is mandatory if the controller supports revision
1.2.1 or later"
The driver does confirm the controller's reported revision meets this
requirement before emitting the warning.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-08-17 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 15:10 SK hynix BC511: warning: nvme nvme0: missing or invalid SUBNQN field Paul Menzel
2021-08-17 15:10 ` Paul Menzel
2021-08-17 16:16 ` Keith Busch
2021-08-17 16:16 ` Keith Busch
2021-08-17 16:53 ` Paul Menzel
2021-08-17 16:53 ` Paul Menzel
2021-08-17 17:02 ` Keith Busch [this message]
2021-08-17 17:02 ` Keith Busch
2021-10-11 13:08 ` Paul Menzel
2021-10-11 13:08 ` Paul Menzel
2021-10-11 18:00 ` Keith Busch
2021-10-11 18:00 ` Keith Busch
2021-10-19 9:01 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817170222.GA224912@dhcp-10-100-145-180.wdc.com \
--to=kbusch@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.