[hare-scsi-devel:eh-rework.v2 50/51] drivers/scsi/scsi_error.c:859:13: warning: conflicting types for '__scsi_report_device_reset'; have 'void(struct scsi_device *, void *)'

* [hare-scsi-devel:eh-rework.v2 50/51] drivers/scsi/scsi_error.c:859:13: warning: conflicting types for '__scsi_report_device_reset'; have 'void(struct scsi_device *, void *)'
@ 2021-08-17 12:58 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-08-17 12:58 UTC (permalink / raw)
  To: Hannes Reinecke; +Cc: kbuild-all, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 4556 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git eh-rework.v2
head:   7603e2e1f37e470064b8c865b5d6470137baa79b
commit: 7285b348b4837b6bcbeffaf829372e63cd180b09 [50/51] scsi: Do not allocate scsi command in scsi_ioctl_reset()
config: parisc-randconfig-r021-20210816 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=7285b348b4837b6bcbeffaf829372e63cd180b09
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel eh-rework.v2
        git checkout 7285b348b4837b6bcbeffaf829372e63cd180b09
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/scsi_error.c: In function 'scsi_try_host_reset':
   drivers/scsi/scsi_error.c:821:25: error: implicit declaration of function '__scsi_report_device_reset'; did you mean 'scsi_report_device_reset'? [-Werror=implicit-function-declaration]
     821 |                         __scsi_report_device_reset(sdev);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |                         scsi_report_device_reset
   drivers/scsi/scsi_error.c: At top level:
>> drivers/scsi/scsi_error.c:859:13: warning: conflicting types for '__scsi_report_device_reset'; have 'void(struct scsi_device *, void *)'
     859 | static void __scsi_report_device_reset(struct scsi_device *sdev, void *data)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c:859:13: error: static declaration of '__scsi_report_device_reset' follows non-static declaration
   drivers/scsi/scsi_error.c:821:25: note: previous implicit declaration of '__scsi_report_device_reset' with type 'void(struct scsi_device *, void *)'
     821 |                         __scsi_report_device_reset(sdev);
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c: In function 'scsi_try_target_reset':
   drivers/scsi/scsi_error.c:893:33: error: too few arguments to function '__scsi_report_device_reset'
     893 |                                 __scsi_report_device_reset(sdev);
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c:859:13: note: declared here
     859 | static void __scsi_report_device_reset(struct scsi_device *sdev, void *data)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c: At top level:
   drivers/scsi/scsi_error.c:1217:6: warning: no previous prototype for '__scsi_eh_finish_cmd' [-Wmissing-prototypes]
    1217 | void __scsi_eh_finish_cmd(struct scsi_cmnd *scmd, struct list_head *done_q,
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/scsi/scsi_error.c: In function 'scsi_ioctl_reset':
   drivers/scsi/scsi_error.c:2443:1: warning: label 'out_put_autopm_host' defined but not used [-Wunused-label]
    2443 | out_put_autopm_host:
         | ^~~~~~~~~~~~~~~~~~~
   At top level:
   drivers/scsi/scsi_error.c:2365:1: warning: 'scsi_reset_provider_done_command' defined but not used [-Wunused-function]
    2365 | scsi_reset_provider_done_command(struct scsi_cmnd *scmd)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +859 drivers/scsi/scsi_error.c

292148f8bb2b5d Brian King    2007-01-30  858  
30bd7df8ced23e Mike Christie 2008-02-29 @859  static void __scsi_report_device_reset(struct scsi_device *sdev, void *data)
30bd7df8ced23e Mike Christie 2008-02-29  860  {
30bd7df8ced23e Mike Christie 2008-02-29  861  	sdev->was_reset = 1;
30bd7df8ced23e Mike Christie 2008-02-29  862  	sdev->expecting_cc_ua = 1;
30bd7df8ced23e Mike Christie 2008-02-29  863  }
30bd7df8ced23e Mike Christie 2008-02-29  864  

:::::: The code at line 859 was first introduced by commit
:::::: 30bd7df8ced23eefec87a5cda96dc99b002ed9da [SCSI] scsi_error: add target reset handler

:::::: TO: Mike Christie <michaelc@cs.wisc.edu>
:::::: CC: James Bottomley <James.Bottomley@HansenPartnership.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29966 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread