From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1
Date: Wed, 18 Aug 2021 11:07:59 +0200 [thread overview]
Message-ID: <20210818090759.defewtmx3l3ku3rd@gilmour> (raw)
In-Reply-To: <20210805045716.46141-2-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Wed, Aug 04, 2021 at 11:57:15PM -0500, Samuel Holland wrote:
> D1 keeps the same register layout and clock sources as the R329, but it
> adds a key field which must be set to update the watchdog's "CFG" and
> "MODE" registers. Therefore it is not backward-compatible.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Samuel Holland <samuel@sholland.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1
Date: Wed, 18 Aug 2021 11:07:59 +0200 [thread overview]
Message-ID: <20210818090759.defewtmx3l3ku3rd@gilmour> (raw)
In-Reply-To: <20210805045716.46141-2-samuel@sholland.org>
[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]
On Wed, Aug 04, 2021 at 11:57:15PM -0500, Samuel Holland wrote:
> D1 keeps the same register layout and clock sources as the R329, but it
> adds a key field which must be set to update the watchdog's "CFG" and
> "MODE" registers. Therefore it is not backward-compatible.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-18 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 4:57 [PATCH v2 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329 Samuel Holland
2021-08-05 4:57 ` Samuel Holland
2021-08-05 4:57 ` [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1 Samuel Holland
2021-08-05 4:57 ` Samuel Holland
2021-08-18 9:07 ` Maxime Ripard [this message]
2021-08-18 9:07 ` Maxime Ripard
2021-08-28 16:23 ` Guenter Roeck
2021-08-28 16:23 ` Guenter Roeck
2021-08-05 4:57 ` [PATCH v2 3/3] watchdog: sunxi_wdt: Add support " Samuel Holland
2021-08-05 4:57 ` Samuel Holland
2021-08-18 9:08 ` Maxime Ripard
2021-08-18 9:08 ` Maxime Ripard
2021-08-13 17:46 ` [PATCH v2 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329 Rob Herring
2021-08-13 17:46 ` Rob Herring
2021-08-18 9:07 ` Maxime Ripard
2021-08-18 9:07 ` Maxime Ripard
2021-08-20 4:04 ` Samuel Holland
2021-08-20 4:04 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818090759.defewtmx3l3ku3rd@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.