* [PATCH linux-next] firmware: edd: fix Coccinelle warnings
@ 2021-08-20 6:05 CGEL
0 siblings, 0 replies; only message in thread
From: CGEL @ 2021-08-20 6:05 UTC (permalink / raw)
To: linux-kernel; +Cc: jing yangyang, Zeal Robot
From: jing yangyang <jing.yangyang@zte.com.cn>
WARNING !A || A && B is equivalent to !A || B
This issue was detected with the help of Coccinelle.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
drivers/firmware/edd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 14d0970..e8b409e 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -694,8 +694,7 @@ static void edd_populate_dir(struct edd_device * edev)
int i;
for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
- if (!attr->test ||
- (attr->test && attr->test(edev)))
+ if (!attr->test || attr->test(edev))
error = sysfs_create_file(&edev->kobj,&attr->attr);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-20 6:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 6:05 [PATCH linux-next] firmware: edd: fix Coccinelle warnings CGEL
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.