From: Barry Song <21cnbao@gmail.com>
To: 21cnbao@gmail.com, bhelgaas@google.com, corbet@lwn.net
Cc: Jonathan.Cameron@huawei.com, bilbao@vt.edu,
gregkh@linuxfoundation.org, leon@kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linuxarm@huawei.com, luzmaximilian@gmail.com,
mchehab+huawei@kernel.org, schnelle@linux.ibm.com,
song.bao.hua@hisilicon.com
Subject: [PATCH v2 0/2] PCI/MSI: Clarify the IRQ sysfs ABI for PCI devices
Date: Sat, 21 Aug 2021 10:37:42 +1200 [thread overview]
Message-ID: <20210820223744.8439-1-21cnbao@gmail.com> (raw)
From: Barry Song <song.bao.hua@hisilicon.com>
/sys/bus/pci/devices/.../irq has been there for many years but it has never
been documented. This patch is trying to document it. Plus, irq ABI is very
confusing at this moment especially for MSI and MSI-x cases. MSI sets irq
to the first number in the vector, but MSI-X does nothing for this though
it saves default_irq in msix_setup_entries(). Weird the saved default_irq
for MSI-X is never used in pci_msix_shutdown(), which is quite different
with pci_msi_shutdown(). Thus, this patch also moves to show the first IRQ
number which is from the first msi_entry for MSI-X. Hopefully, this can
make irq ABI more clear and more consistent.
-v2:
- split into two patches according to Bjorn's comments;
- Add Greg's Acked-by, thanks for reviewing!
-v1:
https://lore.kernel.org/lkml/20210813122650.25764-1-21cnbao@gmail.com/#t
Barry Song (2):
PCI/MSI: Fix the confusing IRQ sysfs ABI for MSI-X
Documentation: ABI: sysfs-bus-pci: Add description for IRQ entry
Documentation/ABI/testing/sysfs-bus-pci | 8 ++++++++
drivers/pci/msi.c | 6 ++++++
2 files changed, 14 insertions(+)
--
1.8.3.1
next reply other threads:[~2021-08-20 22:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 22:37 Barry Song [this message]
2021-08-20 22:37 ` [PATCH v2 1/2] PCI/MSI: Fix the confusing IRQ sysfs ABI for MSI-X Barry Song
2021-08-20 23:33 ` Bjorn Helgaas
2021-08-21 10:42 ` Marc Zyngier
2021-08-21 22:14 ` Barry Song
2021-08-21 22:41 ` Barry Song
2021-08-23 10:33 ` Marc Zyngier
2021-08-24 19:25 ` Bjorn Helgaas
2021-08-23 10:30 ` Marc Zyngier
2021-08-23 11:03 ` Barry Song
2021-08-23 11:28 ` Marc Zyngier
2021-08-23 22:46 ` Barry Song
2021-08-24 19:34 ` Bjorn Helgaas
2021-08-25 9:45 ` Marc Zyngier
2021-08-24 20:51 ` Barry Song
2021-08-24 21:29 ` Barry Song
2021-08-25 10:24 ` Marc Zyngier
2021-08-24 22:51 ` Barry Song
2021-08-20 22:37 ` [PATCH v2 2/2] Documentation: ABI: sysfs-bus-pci: Add description for IRQ entry Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820223744.8439-1-21cnbao@gmail.com \
--to=21cnbao@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=bilbao@vt.edu \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luzmaximilian@gmail.com \
--cc=mchehab+huawei@kernel.org \
--cc=schnelle@linux.ibm.com \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.