[Buildroot] [PATCH] package/libmodsecurity: fix build failure on m68k_cf

[Buildroot] [PATCH] package/libmodsecurity: fix build failure on m68k_cf

[Giulio Benetti]

This package has -fPIC gcc option set by default but we can't use it on
m68k_cf since it doesn't support it throwing a gcc build failure. So let's
disable it by passing -fno-PIC.

Fixes:
http://autobuild.buildroot.net/results/b92980a563fe7ee331e70f288ce041be0bf29d40/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libmodsecurity/libmodsecurity.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/package/libmodsecurity/libmodsecurity.mk b/package/libmodsecurity/libmodsecurity.mk
index 66e7e522a1..be46eb6e02 100644
--- a/package/libmodsecurity/libmodsecurity.mk
+++ b/package/libmodsecurity/libmodsecurity.mk
@@ -52,4 +52,14 @@ else
 LIBMODSECURITY_CONF_OPTS += --without-maxmind
 endif
 
+LIBMODSECURITY_CXXFLAGS = $(TARGET_CXXFLAGS)
+
+# m68k_cf can't use -fPIC that libmodsecurity forces to use, so we need
+# to disable it to avoid a build failure.
+ifeq ($(BR2_m68k_cf),y)
+LIBMODSECURITY_CXXFLAGS += -fno-PIC
+endif
+
+LIBMODSECURITY_CONF_OPTS += CXXFLAGS="$(LIBMODSECURITY_CXXFLAGS)"
+
 $(eval $(autotools-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libmodsecurity: fix build failure on m68k_cf

[Arnout Vandecappelle]

On 22/08/2021 01:06, Giulio Benetti wrote:
> This package has -fPIC gcc option set by default but we can't use it on
> m68k_cf since it doesn't support it throwing a gcc build failure. So let's
> disable it by passing -fno-PIC.
> 
> Fixes:
> http://autobuild.buildroot.net/results/b92980a563fe7ee331e70f288ce041be0bf29d40/

 Applied to master, thanks.

 I just changed the subject line from "fix" to "disable -fPIC". Most changes are
fixes, so that's obvious, and "disable -fPIC" is given a lot more information in
few words.

 Regards,
 Arnout

> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libmodsecurity/libmodsecurity.mk | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/package/libmodsecurity/libmodsecurity.mk b/package/libmodsecurity/libmodsecurity.mk
> index 66e7e522a1..be46eb6e02 100644
> --- a/package/libmodsecurity/libmodsecurity.mk
> +++ b/package/libmodsecurity/libmodsecurity.mk
> @@ -52,4 +52,14 @@ else
>  LIBMODSECURITY_CONF_OPTS += --without-maxmind
>  endif
>  
> +LIBMODSECURITY_CXXFLAGS = $(TARGET_CXXFLAGS)
> +
> +# m68k_cf can't use -fPIC that libmodsecurity forces to use, so we need
> +# to disable it to avoid a build failure.
> +ifeq ($(BR2_m68k_cf),y)
> +LIBMODSECURITY_CXXFLAGS += -fno-PIC
> +endif
> +
> +LIBMODSECURITY_CONF_OPTS += CXXFLAGS="$(LIBMODSECURITY_CXXFLAGS)"
> +
>  $(eval $(autotools-package))
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libmodsecurity: fix build failure on m68k_cf

[Giulio Benetti]

On 8/24/21 12:25 AM, Arnout Vandecappelle wrote:
> 
> 
> On 22/08/2021 01:06, Giulio Benetti wrote:
>> This package has -fPIC gcc option set by default but we can't use it on
>> m68k_cf since it doesn't support it throwing a gcc build failure. So let's
>> disable it by passing -fno-PIC.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/b92980a563fe7ee331e70f288ce041be0bf29d40/
> 
>   Applied to master, thanks.
> 
>   I just changed the subject line from "fix" to "disable -fPIC". Most changes are
> fixes, so that's obvious, and "disable -fPIC" is given a lot more information in
> few words.

Ah yes, thank you. This almost sent me to nut, because it seemed a gcc 
bug instead it was this and I've written commit log too fast!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>   Regards,
>   Arnout
> 
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/libmodsecurity/libmodsecurity.mk | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/package/libmodsecurity/libmodsecurity.mk b/package/libmodsecurity/libmodsecurity.mk
>> index 66e7e522a1..be46eb6e02 100644
>> --- a/package/libmodsecurity/libmodsecurity.mk
>> +++ b/package/libmodsecurity/libmodsecurity.mk
>> @@ -52,4 +52,14 @@ else
>>   LIBMODSECURITY_CONF_OPTS += --without-maxmind
>>   endif
>>   
>> +LIBMODSECURITY_CXXFLAGS = $(TARGET_CXXFLAGS)
>> +
>> +# m68k_cf can't use -fPIC that libmodsecurity forces to use, so we need
>> +# to disable it to avoid a build failure.
>> +ifeq ($(BR2_m68k_cf),y)
>> +LIBMODSECURITY_CXXFLAGS += -fno-PIC
>> +endif
>> +
>> +LIBMODSECURITY_CONF_OPTS += CXXFLAGS="$(LIBMODSECURITY_CXXFLAGS)"
>> +
>>   $(eval $(autotools-package))
>>

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libmodsecurity: fix build failure on m68k_cf

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > This package has -fPIC gcc option set by default but we can't use it on
 > m68k_cf since it doesn't support it throwing a gcc build failure. So let's
 > disable it by passing -fno-PIC.

 > Fixes:
 > http://autobuild.buildroot.net/results/b92980a563fe7ee331e70f288ce041be0bf29d40/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot