* [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5
@ 2021-08-22 19:46 Romain Naour
2021-08-24 22:02 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Romain Naour @ 2021-08-22 19:46 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour
This version bump is needed to pass the ATF test with
hardening option enabled (-fstack-protector-strong)
With the version v2.2, ATF fail due to undefined references:
./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to `__stack_chk_guard'
arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to `__stack_chk_guard'
arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to `__stack_chk_guard'
arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to `__stack_chk_fail'
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
support/testing/tests/boot/test_atf.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/testing/tests/boot/test_atf.py b/support/testing/tests/boot/test_atf.py
index a9d5b67ac7..4fcb9b241c 100644
--- a/support/testing/tests/boot/test_atf.py
+++ b/support/testing/tests/boot/test_atf.py
@@ -10,7 +10,7 @@ class TestATFVexpress(infra.basetest.BRTest):
BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware.git"
- BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.2"
+ BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.5"
BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="juno"
BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP=y
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33=y
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5
2021-08-22 19:46 [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5 Romain Naour
@ 2021-08-24 22:02 ` Thomas Petazzoni
2021-08-25 11:12 ` Romain Naour
2021-08-28 11:59 ` Arnout Vandecappelle
2021-09-07 12:59 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2021-08-24 22:02 UTC (permalink / raw)
To: Romain Naour; +Cc: buildroot
On Sun, 22 Aug 2021 21:46:44 +0200
Romain Naour <romain.naour@gmail.com> wrote:
> This version bump is needed to pass the ATF test with
> hardening option enabled (-fstack-protector-strong)
>
> With the version v2.2, ATF fail due to undefined references:
>
> ./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
> arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to `__stack_chk_fail'
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Isn't this fixed since ccac9a5bbbd7374187a0f0017101ece0c202851d perhaps ?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5
2021-08-24 22:02 ` Thomas Petazzoni
@ 2021-08-25 11:12 ` Romain Naour
0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2021-08-25 11:12 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
Hello Thomas,
Le 25/08/2021 à 00:02, Thomas Petazzoni a écrit :
> On Sun, 22 Aug 2021 21:46:44 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
>
>> This version bump is needed to pass the ATF test with
>> hardening option enabled (-fstack-protector-strong)
>>
>> With the version v2.2, ATF fail due to undefined references:
>>
>> ./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
>> arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to `__stack_chk_guard'
>> arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to `__stack_chk_guard'
>> arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to `__stack_chk_guard'
>> arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to `__stack_chk_fail'
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>
> Isn't this fixed since ccac9a5bbbd7374187a0f0017101ece0c202851d perhaps ?
No, it was reproduced with this pipeline after this commit:
https://gitlab.com/kubu93/buildroot/-/pipelines/357079960/
Best regards,
Romain
>
> Thomas
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5
2021-08-22 19:46 [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5 Romain Naour
2021-08-24 22:02 ` Thomas Petazzoni
@ 2021-08-28 11:59 ` Arnout Vandecappelle
2021-09-07 12:59 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-08-28 11:59 UTC (permalink / raw)
To: Romain Naour, buildroot
On 22/08/2021 21:46, Romain Naour wrote:
> This version bump is needed to pass the ATF test with
> hardening option enabled (-fstack-protector-strong)
>
> With the version v2.2, ATF fail due to undefined references:
>
> ./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
> arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to `__stack_chk_fail'
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
I've added a reference to the build failure
(https://gitlab.com/buildroot.org/buildroot/-/jobs/1524842591), explained a bit
why it fails, and applied to master, thanks.
Regards,
Arnout
> ---
> support/testing/tests/boot/test_atf.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/testing/tests/boot/test_atf.py b/support/testing/tests/boot/test_atf.py
> index a9d5b67ac7..4fcb9b241c 100644
> --- a/support/testing/tests/boot/test_atf.py
> +++ b/support/testing/tests/boot/test_atf.py
> @@ -10,7 +10,7 @@ class TestATFVexpress(infra.basetest.BRTest):
> BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/ARM-software/arm-trusted-firmware.git"
> - BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.2"
> + BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="v2.5"
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="juno"
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP=y
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33=y
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5
2021-08-22 19:46 [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5 Romain Naour
2021-08-24 22:02 ` Thomas Petazzoni
2021-08-28 11:59 ` Arnout Vandecappelle
@ 2021-09-07 12:59 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-09-07 12:59 UTC (permalink / raw)
To: Romain Naour; +Cc: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> This version bump is needed to pass the ATF test with
> hardening option enabled (-fstack-protector-strong)
> With the version v2.2, ATF fail due to undefined references:
> ./build/juno/release/bl2u/arm_tzc400.o: In function `arm_tzc400_setup':
> arm_tzc400.c:(.text.arm_tzc400_setup+0x10): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0x18): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xb8): undefined reference to `__stack_chk_guard'
> arm_tzc400.c:(.text.arm_tzc400_setup+0xcc): undefined reference to `__stack_chk_fail'
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-07 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22 19:46 [Buildroot] [PATCH] support/testing: test_atf: bump the custom version to v2.5 Romain Naour
2021-08-24 22:02 ` Thomas Petazzoni
2021-08-25 11:12 ` Romain Naour
2021-08-28 11:59 ` Arnout Vandecappelle
2021-09-07 12:59 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.