All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Holland <samuel@sholland.org>
To: Bin Meng <bmeng.cn@gmail.com>, Simon Glass <sjg@chromium.org>,
	Stefan Roese <sr@denx.de>,
	u-boot@lists.denx.de
Cc: "Jagan Teki" <jagan@amarulasolutions.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Chee Hong Ang" <chee.hong.ang@intel.com>,
	GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	"Harald Seiler" <hws@denx.de>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Priyanka Jain" <priyanka.jain@nxp.com>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Siew Chin Lim" <elly.siew.chin.lim@intel.com>,
	"Teresa Remmet" <t.remmet@phytec.de>,
	"Weijie Gao" <weijie.gao@mediatek.com>
Subject: [PATCH 2/4] sysreset: Mark driver probe functions as static
Date: Sun, 22 Aug 2021 15:41:19 -0500	[thread overview]
Message-ID: <20210822204121.42625-3-samuel@sholland.org> (raw)
In-Reply-To: <20210822204121.42625-1-samuel@sholland.org>

These driver probe functions are not (and should not be) called from
outside the respective driver source files. Therefore, the functions
should be marked static.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/sysreset/sysreset_resetctl.c | 2 +-
 drivers/sysreset/sysreset_syscon.c   | 2 +-
 drivers/sysreset/sysreset_watchdog.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/sysreset/sysreset_resetctl.c b/drivers/sysreset/sysreset_resetctl.c
index c039521eb43..25bd5c9a7ff 100644
--- a/drivers/sysreset/sysreset_resetctl.c
+++ b/drivers/sysreset/sysreset_resetctl.c
@@ -26,7 +26,7 @@ static struct sysreset_ops resetctl_reboot_ops = {
 	.request = resetctl_reboot_request,
 };
 
-int resetctl_reboot_probe(struct udevice *dev)
+static int resetctl_reboot_probe(struct udevice *dev)
 {
 	struct resetctl_reboot_priv *priv = dev_get_priv(dev);
 
diff --git a/drivers/sysreset/sysreset_syscon.c b/drivers/sysreset/sysreset_syscon.c
index 28fdfb09781..525faf2f89e 100644
--- a/drivers/sysreset/sysreset_syscon.c
+++ b/drivers/sysreset/sysreset_syscon.c
@@ -39,7 +39,7 @@ static struct sysreset_ops syscon_reboot_ops = {
 	.request = syscon_reboot_request,
 };
 
-int syscon_reboot_probe(struct udevice *dev)
+static int syscon_reboot_probe(struct udevice *dev)
 {
 	struct syscon_reboot_priv *priv = dev_get_priv(dev);
 	int err;
diff --git a/drivers/sysreset/sysreset_watchdog.c b/drivers/sysreset/sysreset_watchdog.c
index 0dc2d8b9b65..c7ae368d41a 100644
--- a/drivers/sysreset/sysreset_watchdog.c
+++ b/drivers/sysreset/sysreset_watchdog.c
@@ -29,7 +29,7 @@ static struct sysreset_ops wdt_reboot_ops = {
 	.request = wdt_reboot_request,
 };
 
-int wdt_reboot_probe(struct udevice *dev)
+static int wdt_reboot_probe(struct udevice *dev)
 {
 	struct wdt_reboot_priv *priv = dev_get_priv(dev);
 	int err;
-- 
2.31.1


  parent reply	other threads:[~2021-08-22 20:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22 20:41 [PATCH 0/4] Improved sysreset/watchdog uclass integration Samuel Holland
2021-08-22 20:41 ` [PATCH 1/4] sysreset: Add uclass Kconfig dependency to drivers Samuel Holland
2021-10-27 10:05   ` Heinrich Schuchardt
2021-08-22 20:41 ` Samuel Holland [this message]
2021-10-28  8:34   ` [PATCH 2/4] sysreset: Mark driver probe functions as static Heinrich Schuchardt
2021-08-22 20:41 ` [PATCH 3/4] sysreset: watchdog: Move watchdog reference to plat data Samuel Holland
2021-10-28 11:17   ` Heinrich Schuchardt
2021-10-31 23:46     ` Simon Glass
2021-08-22 20:41 ` [PATCH 4/4] watchdog: Automatically register device with sysreset Samuel Holland
2021-10-28 11:26   ` Heinrich Schuchardt
2021-10-31 23:46   ` Simon Glass
2021-11-04  3:49     ` Samuel Holland
2021-11-04 15:11       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210822204121.42625-3-samuel@sholland.org \
    --to=samuel@sholland.org \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=andre.przywara@arm.com \
    --cc=bmeng.cn@gmail.com \
    --cc=chee.hong.ang@intel.com \
    --cc=elly.siew.chin.lim@intel.com \
    --cc=hws@denx.de \
    --cc=jagan@amarulasolutions.com \
    --cc=ley.foon.tan@intel.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=priyanka.jain@nxp.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sebastian.reichel@collabora.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=t.remmet@phytec.de \
    --cc=u-boot@lists.denx.de \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.