All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
To: Samuel Holland <samuel@sholland.org>
Cc: "Jagan Teki" <jagan@amarulasolutions.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Chee Hong Ang" <chee.hong.ang@intel.com>,
	GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	"Harald Seiler" <hws@denx.de>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Priyanka Jain" <priyanka.jain@nxp.com>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Siew Chin Lim" <elly.siew.chin.lim@intel.com>,
	"Teresa Remmet" <t.remmet@phytec.de>,
	"Weijie Gao" <weijie.gao@mediatek.com>,
	u-boot@lists.denx.de, "Stefan Roese" <sr@denx.de>,
	"Simon Glass" <sjg@chromium.org>, "Bin Meng" <bmeng.cn@gmail.com>
Subject: Re: [PATCH 1/4] sysreset: Add uclass Kconfig dependency to drivers
Date: Wed, 27 Oct 2021 12:05:03 +0200	[thread overview]
Message-ID: <9dc1b57c-446d-b258-b552-130a56823890@canonical.com> (raw)
In-Reply-To: <20210822204121.42625-2-samuel@sholland.org>

On 8/22/21 22:41, Samuel Holland wrote:
> The drivers enabled by SYSRESET_SYSCON, SYSRESET_WATCHDOG, and
> SYSRESET_RESETCTL do nothing beyond providing sysreset uclass ops.
> Therefore, they should depend on the sysreset uclass.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>   drivers/sysreset/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig
> index ac77ffbc8be..fdc858ccbac 100644
> --- a/drivers/sysreset/Kconfig
> +++ b/drivers/sysreset/Kconfig
> @@ -106,8 +106,6 @@ config SYSRESET_TI_SCI
>   	  This enables the system reset driver support over TI System Control
>   	  Interface available on some new TI's SoCs.
>   
> -endif
> -
>   config SYSRESET_SYSCON
>   	bool "Enable support for mfd syscon reboot driver"
>   	select REGMAP
> @@ -127,6 +125,8 @@ config SYSRESET_RESETCTL
>   	help
>   	  Reboot support using generic reset controller.
>   
> +endif
> +

All sysreset drivers in directory drivers/sysreset/ require 
sysreset-uclass.o. Please, move this endif to the very end of the 
Kconfig file.

Best regards

Heinrich

>   config SYSRESET_X86
>   	bool "Enable support for x86 processor reboot driver"
>   	depends on X86
> 


  reply	other threads:[~2021-10-27 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-22 20:41 [PATCH 0/4] Improved sysreset/watchdog uclass integration Samuel Holland
2021-08-22 20:41 ` [PATCH 1/4] sysreset: Add uclass Kconfig dependency to drivers Samuel Holland
2021-10-27 10:05   ` Heinrich Schuchardt [this message]
2021-08-22 20:41 ` [PATCH 2/4] sysreset: Mark driver probe functions as static Samuel Holland
2021-10-28  8:34   ` Heinrich Schuchardt
2021-08-22 20:41 ` [PATCH 3/4] sysreset: watchdog: Move watchdog reference to plat data Samuel Holland
2021-10-28 11:17   ` Heinrich Schuchardt
2021-10-31 23:46     ` Simon Glass
2021-08-22 20:41 ` [PATCH 4/4] watchdog: Automatically register device with sysreset Samuel Holland
2021-10-28 11:26   ` Heinrich Schuchardt
2021-10-31 23:46   ` Simon Glass
2021-11-04  3:49     ` Samuel Holland
2021-11-04 15:11       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dc1b57c-446d-b258-b552-130a56823890@canonical.com \
    --to=heinrich.schuchardt@canonical.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=andre.przywara@arm.com \
    --cc=bmeng.cn@gmail.com \
    --cc=chee.hong.ang@intel.com \
    --cc=elly.siew.chin.lim@intel.com \
    --cc=hws@denx.de \
    --cc=jagan@amarulasolutions.com \
    --cc=ley.foon.tan@intel.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=priyanka.jain@nxp.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=samuel@sholland.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=t.remmet@phytec.de \
    --cc=u-boot@lists.denx.de \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.