From: Mark Brown <broonie@kernel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller
Date: Mon, 23 Aug 2021 12:19:38 +0100 [thread overview]
Message-ID: <20210823111938.GC4380@sirena.org.uk> (raw)
In-Reply-To: <3469189.PC3msRC2N5@archbook>
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Sat, Aug 21, 2021 at 10:45:52PM +0200, Nicolas Frattaroli wrote:
> On Freitag, 20. August 2021 21:02:16 CEST Pierre-Louis Bossart wrote:
> > > + regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
> > > + /* Wait on the clear operation to finish */
> > > + while (val) {
> > delay needed here?
> The rockchip_i2s.c code doesn't have a delay here either, but I can
> add one of 1 usec for good measure, it seems weird to retry the
> read as fast as it can.
You should probably have a cpu_relax() in there at least.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: alsa-devel@alsa-project.org, Heiko Stuebner <heiko@sntech.de>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
linux-rockchip@lists.infradead.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller
Date: Mon, 23 Aug 2021 12:19:38 +0100 [thread overview]
Message-ID: <20210823111938.GC4380@sirena.org.uk> (raw)
In-Reply-To: <3469189.PC3msRC2N5@archbook>
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Sat, Aug 21, 2021 at 10:45:52PM +0200, Nicolas Frattaroli wrote:
> On Freitag, 20. August 2021 21:02:16 CEST Pierre-Louis Bossart wrote:
> > > + regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
> > > + /* Wait on the clear operation to finish */
> > > + while (val) {
> > delay needed here?
> The rockchip_i2s.c code doesn't have a delay here either, but I can
> add one of 1 usec for good measure, it seems weird to retry the
> read as fast as it can.
You should probably have a cpu_relax() in there at least.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller
Date: Mon, 23 Aug 2021 12:19:38 +0100 [thread overview]
Message-ID: <20210823111938.GC4380@sirena.org.uk> (raw)
In-Reply-To: <3469189.PC3msRC2N5@archbook>
[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]
On Sat, Aug 21, 2021 at 10:45:52PM +0200, Nicolas Frattaroli wrote:
> On Freitag, 20. August 2021 21:02:16 CEST Pierre-Louis Bossart wrote:
> > > + regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
> > > + /* Wait on the clear operation to finish */
> > > + while (val) {
> > delay needed here?
> The rockchip_i2s.c code doesn't have a delay here either, but I can
> add one of 1 usec for good measure, it seems weird to retry the
> read as fast as it can.
You should probably have a cpu_relax() in there at least.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller
Date: Mon, 23 Aug 2021 12:19:38 +0100 [thread overview]
Message-ID: <20210823111938.GC4380@sirena.org.uk> (raw)
In-Reply-To: <3469189.PC3msRC2N5@archbook>
[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]
On Sat, Aug 21, 2021 at 10:45:52PM +0200, Nicolas Frattaroli wrote:
> On Freitag, 20. August 2021 21:02:16 CEST Pierre-Louis Bossart wrote:
> > > + regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
> > > + /* Wait on the clear operation to finish */
> > > + while (val) {
> > delay needed here?
> The rockchip_i2s.c code doesn't have a delay here either, but I can
> add one of 1 usec for good measure, it seems weird to retry the
> read as fast as it can.
You should probably have a cpu_relax() in there at least.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-23 11:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 18:27 [PATCH v2 0/4] Rockchip I2S/TDM controller Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 19:02 ` Pierre-Louis Bossart
2021-08-20 19:02 ` Pierre-Louis Bossart
2021-08-20 19:02 ` Pierre-Louis Bossart
2021-08-21 20:45 ` Nicolas Frattaroli
2021-08-21 20:45 ` Nicolas Frattaroli
2021-08-21 20:45 ` Nicolas Frattaroli
2021-08-23 11:19 ` Mark Brown [this message]
2021-08-23 11:19 ` Mark Brown
2021-08-23 11:19 ` Mark Brown
2021-08-23 11:19 ` Mark Brown
2021-08-23 15:02 ` Pierre-Louis Bossart
2021-08-23 15:02 ` Pierre-Louis Bossart
2021-08-23 15:02 ` Pierre-Louis Bossart
2021-08-23 12:03 ` Philipp Zabel
2021-08-23 12:03 ` Philipp Zabel
2021-08-23 12:03 ` Philipp Zabel
2021-08-23 12:03 ` Philipp Zabel
2021-08-23 14:35 ` Nicolas Frattaroli
2021-08-23 14:35 ` Nicolas Frattaroli
2021-08-23 14:35 ` Nicolas Frattaroli
2021-08-23 14:35 ` Nicolas Frattaroli
2021-08-23 16:03 ` Philipp Zabel
2021-08-23 16:03 ` Philipp Zabel
2021-08-23 16:03 ` Philipp Zabel
2021-08-23 16:03 ` Philipp Zabel
2021-08-24 2:42 ` [PATCH v2 1/4] ASoC: rockchip: add support for i2s-tdm controller【请注意，邮件由linux-rockchip-bounces+sugar.zhang=rock-chips.com@lists.infradead.org代发】 sugar zhang
2021-08-20 18:27 ` [PATCH v2 2/4] dt-bindings: sound: add rockchip i2s-tdm binding Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-24 16:42 ` Rob Herring
2021-08-24 16:42 ` Rob Herring
2021-08-24 16:42 ` Rob Herring
2021-08-24 16:42 ` Rob Herring
2021-08-20 18:27 ` [PATCH v2 3/4] arm64: dts: rockchip: add i2s1 on rk356x Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` [PATCH v2 4/4] arm64: dts: rockchip: add analog audio on Quartz64 Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
2021-08-20 18:27 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823111938.GC4380@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.