* arm: mvebu: dts: Armada8k enable mdio
@ 2021-08-24 8:14 sven.auhagen
2021-09-10 6:55 ` Stefan Roese
0 siblings, 1 reply; 3+ messages in thread
From: sven.auhagen @ 2021-08-24 8:14 UTC (permalink / raw)
To: u-boot
From: Sven Auhagen <Sven.Auhagen@voleatech.de>
Since mvpp2 is using the new mdio driver and the cp110 has been
synced with the linux upstream, the mdio has to enabled in the
device tree file.
This is missing for some device tree files and therefore the
network cards do not come online.
Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
---
arch/arm/dts/armada-7040-db.dts | 1 +
arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
arch/arm/dts/armada-8040-db.dts | 1 +
arch/arm/dts/armada-8040-mcbin.dts | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-7040-db.dts b/arch/arm/dts/armada-7040-db.dts
index b158f92349..9104042359 100644
--- a/arch/arm/dts/armada-7040-db.dts
+++ b/arch/arm/dts/armada-7040-db.dts
@@ -175,6 +175,7 @@
};
&cp0_mdio {
+ status = "okay";
phy0: ethernet-phy@0 {
reg = <0>;
};
diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
index 6a586dbbba..79ee871c5a 100644
--- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
@@ -295,6 +295,7 @@
};
&cp1_mdio {
+ status = "okay";
phy0: ethernet-phy@0 {
reg = <0>;
};
diff --git a/arch/arm/dts/armada-8040-db.dts b/arch/arm/dts/armada-8040-db.dts
index 51c2f23f4d..2686e00242 100644
--- a/arch/arm/dts/armada-8040-db.dts
+++ b/arch/arm/dts/armada-8040-db.dts
@@ -270,6 +270,7 @@
};
&cp0_mdio {
+ status = "okay";
phy1: ethernet-phy@1 {
reg = <1>;
};
diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts
index 2184648318..b0bed77ae6 100644
--- a/arch/arm/dts/armada-8040-mcbin.dts
+++ b/arch/arm/dts/armada-8040-mcbin.dts
@@ -155,6 +155,7 @@
};
&cp0_mdio {
+ status = "okay";
ge_phy: ethernet-phy@0 {
reg = <0>;
};
--
2.30.1 (Apple Git-130)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: arm: mvebu: dts: Armada8k enable mdio
2021-08-24 8:14 arm: mvebu: dts: Armada8k enable mdio sven.auhagen
@ 2021-09-10 6:55 ` Stefan Roese
2021-09-10 7:25 ` François Ozog
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Roese @ 2021-09-10 6:55 UTC (permalink / raw)
To: sven.auhagen, u-boot
On 24.08.21 10:14, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <Sven.Auhagen@voleatech.de>
>
> Since mvpp2 is using the new mdio driver and the cp110 has been
> synced with the linux upstream, the mdio has to enabled in the
> device tree file.
> This is missing for some device tree files and therefore the
> network cards do not come online.
>
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> arch/arm/dts/armada-7040-db.dts | 1 +
> arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
> arch/arm/dts/armada-8040-db.dts | 1 +
> arch/arm/dts/armada-8040-mcbin.dts | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/armada-7040-db.dts b/arch/arm/dts/armada-7040-db.dts
> index b158f92349..9104042359 100644
> --- a/arch/arm/dts/armada-7040-db.dts
> +++ b/arch/arm/dts/armada-7040-db.dts
> @@ -175,6 +175,7 @@
> };
>
> &cp0_mdio {
> + status = "okay";
> phy0: ethernet-phy@0 {
> reg = <0>;
> };
> diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> index 6a586dbbba..79ee871c5a 100644
> --- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> @@ -295,6 +295,7 @@
> };
>
> &cp1_mdio {
> + status = "okay";
> phy0: ethernet-phy@0 {
> reg = <0>;
> };
> diff --git a/arch/arm/dts/armada-8040-db.dts b/arch/arm/dts/armada-8040-db.dts
> index 51c2f23f4d..2686e00242 100644
> --- a/arch/arm/dts/armada-8040-db.dts
> +++ b/arch/arm/dts/armada-8040-db.dts
> @@ -270,6 +270,7 @@
> };
>
> &cp0_mdio {
> + status = "okay";
> phy1: ethernet-phy@1 {
> reg = <1>;
> };
> diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts
> index 2184648318..b0bed77ae6 100644
> --- a/arch/arm/dts/armada-8040-mcbin.dts
> +++ b/arch/arm/dts/armada-8040-mcbin.dts
> @@ -155,6 +155,7 @@
> };
>
> &cp0_mdio {
> + status = "okay";
> ge_phy: ethernet-phy@0 {
> reg = <0>;
> };
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arm: mvebu: dts: Armada8k enable mdio
2021-09-10 6:55 ` Stefan Roese
@ 2021-09-10 7:25 ` François Ozog
0 siblings, 0 replies; 3+ messages in thread
From: François Ozog @ 2021-09-10 7:25 UTC (permalink / raw)
Cc: sven.auhagen, U-Boot Mailing List, Stefan Roese
Hi Simon,
That's typically what SystemReady want to avoid/address. The board MDIO has
always been "Okay". Linux may not have been able to deal with it.
So the right way to handle that is:
- there is a board DT "attached" to the board
- TFA adjusts the DRAM aspect (SPL, core boot...)
- OP-TEE adjust Secure DRAM aspects (Trusty, Q-SEE...)
- U-Boot adjusts to the booted OS (turn off MDIO if the booted OS does not
support it) or administrative desires. U-Boot is also in the best position
to deal with hats, capes...
- OS selects what it can handle
This way, there is a single source for DTB, no nightmare to sync up all
involved projects.
On Fri, 10 Sept 2021 at 08:56, Stefan Roese <sr@denx.de> wrote:
> On 24.08.21 10:14, sven.auhagen@voleatech.de wrote:
> > From: Sven Auhagen <Sven.Auhagen@voleatech.de>
> >
> > Since mvpp2 is using the new mdio driver and the cp110 has been
> > synced with the linux upstream, the mdio has to enabled in the
> > device tree file.
> > This is missing for some device tree files and therefore the
> > network cards do not come online.
> >
> > Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
> Thanks,
> Stefan
>
> > ---
> > arch/arm/dts/armada-7040-db.dts | 1 +
> > arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
> > arch/arm/dts/armada-8040-db.dts | 1 +
> > arch/arm/dts/armada-8040-mcbin.dts | 1 +
> > 4 files changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/armada-7040-db.dts
> b/arch/arm/dts/armada-7040-db.dts
> > index b158f92349..9104042359 100644
> > --- a/arch/arm/dts/armada-7040-db.dts
> > +++ b/arch/arm/dts/armada-7040-db.dts
> > @@ -175,6 +175,7 @@
> > };
> >
> > &cp0_mdio {
> > + status = "okay";
> > phy0: ethernet-phy@0 {
> > reg = <0>;
> > };
> > diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > index 6a586dbbba..79ee871c5a 100644
> > --- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > +++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > @@ -295,6 +295,7 @@
> > };
> >
> > &cp1_mdio {
> > + status = "okay";
> > phy0: ethernet-phy@0 {
> > reg = <0>;
> > };
> > diff --git a/arch/arm/dts/armada-8040-db.dts
> b/arch/arm/dts/armada-8040-db.dts
> > index 51c2f23f4d..2686e00242 100644
> > --- a/arch/arm/dts/armada-8040-db.dts
> > +++ b/arch/arm/dts/armada-8040-db.dts
> > @@ -270,6 +270,7 @@
> > };
> >
> > &cp0_mdio {
> > + status = "okay";
> > phy1: ethernet-phy@1 {
> > reg = <1>;
> > };
> > diff --git a/arch/arm/dts/armada-8040-mcbin.dts
> b/arch/arm/dts/armada-8040-mcbin.dts
> > index 2184648318..b0bed77ae6 100644
> > --- a/arch/arm/dts/armada-8040-mcbin.dts
> > +++ b/arch/arm/dts/armada-8040-mcbin.dts
> > @@ -155,6 +155,7 @@
> > };
> >
> > &cp0_mdio {
> > + status = "okay";
> > ge_phy: ethernet-phy@0 {
> > reg = <0>;
> > };
> >
>
>
> Viele Grüße,
> Stefan
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
>
--
François-Frédéric Ozog | *Director Business Development*
T: +33.67221.6485
francois.ozog@linaro.org | Skype: ffozog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-10 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 8:14 arm: mvebu: dts: Armada8k enable mdio sven.auhagen
2021-09-10 6:55 ` Stefan Roese
2021-09-10 7:25 ` François Ozog
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.