* [PATCH] board: ea: mx7ulp_com: allow setting CONFIG_BOOTCOMMAND in defconfig
@ 2021-08-25 13:37 Oleksandr Suvorov
2021-08-25 13:47 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Oleksandr Suvorov @ 2021-08-25 13:37 UTC (permalink / raw)
To: u-boot; +Cc: Fabio Estevam, Ricardo Salveti, Oleksandr Suvorov
From: Ricardo Salveti <ricardo@foundries.io>
Allow replacing the board defined CONFIG_BOOTCOMMAND via defconfig.
Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
---
include/configs/mx7ulp_com.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/mx7ulp_com.h b/include/configs/mx7ulp_com.h
index 28672c4f94..85ae513ffb 100644
--- a/include/configs/mx7ulp_com.h
+++ b/include/configs/mx7ulp_com.h
@@ -69,10 +69,12 @@
"bootz ${loadaddr} - ${fdt_addr}; " \
"fi;\0" \
+#ifndef CONFIG_BOOTCOMMAND
#define CONFIG_BOOTCOMMAND \
"if run loadimage; then " \
"run mmcboot; " \
"fi; " \
+#endif
#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] board: ea: mx7ulp_com: allow setting CONFIG_BOOTCOMMAND in defconfig
2021-08-25 13:37 [PATCH] board: ea: mx7ulp_com: allow setting CONFIG_BOOTCOMMAND in defconfig Oleksandr Suvorov
@ 2021-08-25 13:47 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2021-08-25 13:47 UTC (permalink / raw)
To: Oleksandr Suvorov; +Cc: u-boot, Fabio Estevam, Ricardo Salveti
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Wed, Aug 25, 2021 at 04:37:49PM +0300, Oleksandr Suvorov wrote:
> From: Ricardo Salveti <ricardo@foundries.io>
>
> Allow replacing the board defined CONFIG_BOOTCOMMAND via defconfig.
>
> Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
> ---
>
> include/configs/mx7ulp_com.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/mx7ulp_com.h b/include/configs/mx7ulp_com.h
> index 28672c4f94..85ae513ffb 100644
> --- a/include/configs/mx7ulp_com.h
> +++ b/include/configs/mx7ulp_com.h
> @@ -69,10 +69,12 @@
> "bootz ${loadaddr} - ${fdt_addr}; " \
> "fi;\0" \
>
> +#ifndef CONFIG_BOOTCOMMAND
> #define CONFIG_BOOTCOMMAND \
> "if run loadimage; then " \
> "run mmcboot; " \
> "fi; " \
> +#endif
>
> #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
Please just move this to the defconfig. It's not a long/complex
command, which is the general (understandable) excuse to not migrate it.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-25 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 13:37 [PATCH] board: ea: mx7ulp_com: allow setting CONFIG_BOOTCOMMAND in defconfig Oleksandr Suvorov
2021-08-25 13:47 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.