From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: michael.chan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors
Date: Wed, 25 Aug 2021 18:44:51 -0700 [thread overview]
Message-ID: <20210825184451.2cf343c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210826004208.porufhkzwtc3zgny@skbuf>
On Thu, 26 Aug 2021 03:42:08 +0300 Vladimir Oltean wrote:
> On Wed, Aug 25, 2021 at 05:35:37PM -0700, Jakub Kicinski wrote:
> > On Thu, 26 Aug 2021 03:22:57 +0300 Vladimir Oltean wrote:
> > > 'Could you consider adding "driver" stats under RTM_GETSTATS,
> > > or a similar new structured interface over ethtool?
> > >
> > > Looks like the statistic in question has pretty clear semantics,
> > > and may be more broadly useful.'
> >
> > It's commonly reported per ring, I need for make a home for these
> > first by adding that damn netlink queue API. It's my next project.
> >
> > I can drop the ethtool stat from this patch if you have a strong
> > preference.
>
> I don't have any strong preference, far from it. What would you do if
> you were reviewing somebody else's patch which made the same change?
If someone else posted this patch I'd probably not complain, as I said
there is no well suited API, and my knee jerk expectation was it should
be reported in the per-queue API which doesn't exist.
When you'd seem me complain is when drivers expose in -S stats which
have proper APIs or when higher layer/common code is trying to piggy
back on -S instead of creating its own structured interface.
I don't see value in tracking this particular statistic in production
settings, maybe that's also affecting my judgment here. But since
that's the case I'll just drop it.
If you have any feedback on my suggestions, reviews, comments etc.
please do share on- or off-list at any time. No need to wait a year
until I post a vaguely similar patch ;)
next prev parent reply other threads:[~2021-08-26 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:18 [PATCH net-next 0/3] bnxt: add rx discards stats for oom and netpool Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 1/3] bnxt: reorder logic in bnxt_get_stats64() Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 2/3] bnxt: count packets discarded because of netpoll Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors Jakub Kicinski
2021-08-26 0:22 ` Vladimir Oltean
2021-08-26 0:35 ` Jakub Kicinski
2021-08-26 0:42 ` Vladimir Oltean
2021-08-26 1:44 ` Jakub Kicinski [this message]
2021-08-26 12:46 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825184451.2cf343c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.