From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: michael.chan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors
Date: Thu, 26 Aug 2021 03:22:57 +0300 [thread overview]
Message-ID: <20210826002257.yffn4cf2dtyr23q3@skbuf> (raw)
In-Reply-To: <20210825231830.2748915-4-kuba@kernel.org>
Hi Jakub,
On Wed, Aug 25, 2021 at 04:18:30PM -0700, Jakub Kicinski wrote:
> Count packets dropped due to buffer or skb allocation errors.
> Report as part of rx_dropped, and per-queue in ethtool
> (retaining only the former across down/up cycles).
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 +++++++++++++-
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
> drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 +
> 3 files changed, 15 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index 25f1327aedb6..f8a28021389b 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -188,6 +188,7 @@ static const char * const bnxt_rx_sw_stats_str[] = {
> "rx_l4_csum_errors",
> "rx_resets",
> "rx_buf_errors",
> + "rx_oom_discards",
'Could you consider adding "driver" stats under RTM_GETSTATS,
or a similar new structured interface over ethtool?
Looks like the statistic in question has pretty clear semantics,
and may be more broadly useful.'
https://patchwork.ozlabs.org/project/netdev/patch/20201017213611.2557565-2-vladimir.oltean@nxp.com/
> };
>
> static const char * const bnxt_cmn_sw_stats_str[] = {
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-08-26 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 23:18 [PATCH net-next 0/3] bnxt: add rx discards stats for oom and netpool Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 1/3] bnxt: reorder logic in bnxt_get_stats64() Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 2/3] bnxt: count packets discarded because of netpoll Jakub Kicinski
2021-08-25 23:18 ` [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors Jakub Kicinski
2021-08-26 0:22 ` Vladimir Oltean [this message]
2021-08-26 0:35 ` Jakub Kicinski
2021-08-26 0:42 ` Vladimir Oltean
2021-08-26 1:44 ` Jakub Kicinski
2021-08-26 12:46 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826002257.yffn4cf2dtyr23q3@skbuf \
--to=olteanv@gmail.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.